[GitHub] [maven-fluido-skin] hboutemy commented on a diff in pull request #33: rework ITs to better integrate into skin documentation

[GitBox <gi...@apache.org>]

hboutemy commented on code in PR #33:
URL: https://github.com/apache/maven-fluido-skin/pull/33#discussion_r891091915


##########
src/site/site.xml:
##########
@@ -27,9 +27,7 @@ under the License.
   <skin>
     <groupId>org.apache.maven.skins</groupId>
     <artifactId>maven-fluido-skin</artifactId>
-    <!-- TODO check with next parent, and next m-site-p -->
-    <!-- <version>${project.version}</version> -->
-    <version>1.10.0</version>
+    <version>${project.version}</version><!-- keep using current version, even if it implies running mvn -Prun-its,reporting install site -->
   </skin>

Review Comment:
   1. having the skin release using an older skin release is not easy to understand
   2. if we do this, we absolutely need to remove the sample page, because it does not test the current skin release https://maven.apache.org/skins/maven-fluido-skin/sample.html
   3. project is built with the same command as any project: it's just the site that has a little unusual requirement



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org