You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/09/06 01:15:38 UTC

[GitHub] [tvm] masahi opened a new pull request, #12706: [Node][Metaschedule] Allow ignoring NDArray raw data in StructuralEqual / Hash

masahi opened a new pull request, #12706:
URL: https://github.com/apache/tvm/pull/12706

   Thanks for contributing to TVM!   Please refer to guideline https://tvm.apache.org/docs/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @ them in the pull request thread.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] masahi commented on pull request #12706: [Node][Metaschedule] Allow ignoring NDArray raw data in StructuralEqual / Hash

Posted by GitBox <gi...@apache.org>.
masahi commented on PR #12706:
URL: https://github.com/apache/tvm/pull/12706#issuecomment-1280434289

   Superceded by https://github.com/apache/tvm/pull/13091


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] tqchen commented on pull request #12706: [Node][Metaschedule] Allow ignoring NDArray raw data in StructuralEqual / Hash

Posted by GitBox <gi...@apache.org>.
tqchen commented on PR #12706:
URL: https://github.com/apache/tvm/pull/12706#issuecomment-1237566235

   thanks @masahi . I thin this belongs to a more general topic of canonicalizing the workload keys. While adding such option would indeed resolve this particular case, it would be good to think about if we can have a more generalized approach(for future cases that needs canonicalization, e.g. those that have followup elem-wise patterns which allows some form of reuse)
   
   One possible approach is to have a CanonicalizeWorkloadKey which takes a TIR and Canonicalizes that into a different one(e.g. change alloc_const to a the function parameter which contains a buffer). Depends on how fast we can do this, we can choose to introduce the flag. 
   
   This also helps us to prevent possible future cases that can choose to schedule transform depending on the const value content
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] masahi commented on pull request #12706: [Node][Metaschedule] Allow ignoring NDArray raw data in StructuralEqual / Hash

Posted by GitBox <gi...@apache.org>.
masahi commented on PR #12706:
URL: https://github.com/apache/tvm/pull/12706#issuecomment-1237576762

   @tqchen Thanks, I like the idea of the canonicalized key.
   
   Last week I discussed with @zxybazh on the possibility of identifying two subgraphs with the identical anchor op workload (conv2d -> add and conv2d -> add -> add etc) as being equal, to reduce the tuning time like you suggested. I can imagine that, moving away from using the raw Relay / TIR mod as a workload key is a good direction toward that goal.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] masahi closed pull request #12706: [Node][Metaschedule] Allow ignoring NDArray raw data in StructuralEqual / Hash

Posted by GitBox <gi...@apache.org>.
masahi closed pull request #12706: [Node][Metaschedule] Allow ignoring NDArray raw data in StructuralEqual / Hash
URL: https://github.com/apache/tvm/pull/12706


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org