You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "vinoyang (Jira)" <ji...@apache.org> on 2020/01/29 11:10:00 UTC
[jira] [Commented] (FLINK-13619) Update
FlinkKafkaProducerMigrationOperatorTest to restore from 1.9 savepoint
[ https://issues.apache.org/jira/browse/FLINK-13619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17025811#comment-17025811 ]
vinoyang commented on FLINK-13619:
----------------------------------
[~trohrmann] [~pnowojski] [~aljoscha]
Given the confusion it caused earlier. I suggest moving [this comment|https://github.com/apache/flink/blob/master/flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducerMigrationOperatorTest.java#L50] to the doc of the {{FlinkKafkaProducerMigrationOperatorTest}} class. Last time, it made me confused.
Additionally, we can add more details about renaming the generated binary file to the format {{kafka-0.11-migration-kafka-producer-flink-" + version + "-snapshot}} that {{getOperatorSnapshotPath}} returned.
This will make it more friendly to developer.
WDYT?
> Update FlinkKafkaProducerMigrationOperatorTest to restore from 1.9 savepoint
> ----------------------------------------------------------------------------
>
> Key: FLINK-13619
> URL: https://issues.apache.org/jira/browse/FLINK-13619
> Project: Flink
> Issue Type: Sub-task
> Components: Connectors / Kafka, Tests
> Affects Versions: 1.10.0
> Reporter: Till Rohrmann
> Assignee: vinoyang
> Priority: Blocker
> Labels: pull-request-available
> Fix For: 1.10.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Update {{FlinkKafkaProducerMigrationOperatorTest}} to restore from 1.9 savepoint.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)