You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by ppoulosk <gi...@git.apache.org> on 2015/03/05 16:02:22 UTC
[GitHub] storm pull request: [STORM-477] Add warning for invalid JAVA_HOME
GitHub user ppoulosk opened a pull request:
https://github.com/apache/storm/pull/457
[STORM-477] Add warning for invalid JAVA_HOME
This adds a check in the python script to ensure that JAVA_HOME points to an installation of storm, and prints an error message if it is not properly set.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ppoulosk/storm STORM-477
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/457.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #457
----
commit fc3dd60798c158a26380a931b31325249ca7af16
Author: Paul Poulosky <pp...@yahoo-inc.com>
Date: 2015-03-05T14:58:38Z
Add warning for invalid JAVA_HOME
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-477] Add warning for invalid JAVA_HOME
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/457
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-477] Add warning for invalid JAVA_HOME
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/457#discussion_r26263810
--- Diff: bin/storm ---
@@ -82,6 +82,8 @@ CONFFILE = ""
JAR_JVM_OPTS = shlex.split(os.getenv('STORM_JAR_JVM_OPTS', ''))
JAVA_HOME = os.getenv('JAVA_HOME', None)
JAVA_CMD = 'java' if not JAVA_HOME else os.path.join(JAVA_HOME, 'bin', 'java')
+if JAVA_HOME and not os.path.exists(JAVA_CMD):
+ print "WARNING: Check JAVA_HOME. Could not find java at %s." % JAVA_HOME
--- End diff --
I personally would rather have storm exit with an error here instead of just a warning.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-477] Add warning for invalid JAVA_HOME
Posted by kishorvpatil <gi...@git.apache.org>.
Github user kishorvpatil commented on the pull request:
https://github.com/apache/storm/pull/457#issuecomment-115756416
@ppoulosk Thank you for the patch. This is merged into the master now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-477] Add warning for invalid JAVA_HOME
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/457#issuecomment-106586323
@ppoulosk any update on this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-477] Add warning for invalid JAVA_HOME
Posted by ppoulosk <gi...@git.apache.org>.
Github user ppoulosk commented on the pull request:
https://github.com/apache/storm/pull/457#issuecomment-108532639
Upmerged and addressed code comment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-477] Add warning for invalid JAVA_HOME
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/457#issuecomment-108567623
+1 looks good to me
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-477] Add warning for invalid JAVA_HOME
Posted by kishorvpatil <gi...@git.apache.org>.
Github user kishorvpatil commented on the pull request:
https://github.com/apache/storm/pull/457#issuecomment-110489805
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---