You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2021/02/05 15:02:39 UTC

[GitHub] [mynewt-core] kasjer commented on a change in pull request #2401: hw/mcu/dialog: Keep GPIO mux powered if non-GPIO pins enabled

kasjer commented on a change in pull request #2401:
URL: https://github.com/apache/mynewt-core/pull/2401#discussion_r571030345



##########
File path: hw/mcu/dialog/da1469x/src/hal_gpio.c
##########
@@ -90,6 +90,7 @@ static struct hal_gpio_irq hal_gpio_irqs[HAL_GPIO_MAX_IRQ];
 #if MYNEWT_VAL(MCU_GPIO_RETAINABLE_NUM) >= 0
 static uint32_t g_mcu_gpio_latch_state[2];
 static uint8_t g_mcu_gpio_retained_num;
+static uint32_t g_mcu_gpio_can_sleep;

Review comment:
       for now this variable is used only with values 0/1 maybe uint32_t is too much




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org