[GitHub] [mynewt-nimble] rymanluk commented on a change in pull request #466: nimble/ll: Fix aux_data ref counter [WIP]

[GitBox <gi...@apache.org>]

rymanluk commented on a change in pull request #466: nimble/ll: Fix aux_data ref counter [WIP]
URL: https://github.com/apache/mynewt-nimble/pull/466#discussion_r291174721
 
 

 ##########
 File path: nimble/controller/src/ble_ll_scan.c
 ##########
 @@ -3100,7 +3051,8 @@ ble_ll_scan_rx_pkt_in(uint8_t ptype, struct os_mbuf *om, struct ble_mbuf_hdr *hd
             if (BLE_MBUF_HDR_WAIT_AUX(hdr)) {
                 hdr->rxinfo.flags &= ~BLE_MBUF_HDR_F_AUX_PTR_WAIT;
                 if (ble_ll_sched_rmv_elem(&aux_data->sch) == 0) {
-                    ble_ll_scan_aux_data_unref(aux_data);
+                    ble_ll_scan_aux_data_unref(aux_data->sch.cb_arg);
 
 Review comment:
   I've pushed changed code which now have comment about this.  Basically, in here we remove scheduled item which contains its `aux_data` as a `cb_arg` and this is what we want to unref.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services