You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by "thorstenhirsch (via GitHub)" <gi...@apache.org> on 2023/06/12 20:20:33 UTC

[GitHub] [activemq-artemis] thorstenhirsch opened a new pull request, #4504: ARTEMIS-4310 Add Alpine/Java17 based Docker image

thorstenhirsch opened a new pull request, #4504:
URL: https://github.com/apache/activemq-artemis/pull/4504

   This new Dockerfile uses Alpine Linux as base image, so the resulting image is smaller. Also, it makes use of Java 17.
   
   It's not multi-stage. It's basically a copy of Dockerfile-ubuntu-11, but with Alpine-specific commands.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [activemq-artemis] thorstenhirsch commented on pull request #4504: ARTEMIS-4310 Add Alpine/Java17 based Docker image

Posted by "thorstenhirsch (via GitHub)" <gi...@apache.org>.
thorstenhirsch commented on PR #4504:
URL: https://github.com/apache/activemq-artemis/pull/4504#issuecomment-1631393718

   Happened when squashing the commits. :-(
   Again... fixed, this time by amending the last commit.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [activemq-artemis] jbertram commented on pull request #4504: ARTEMIS-4310 Add Alpine/Java17 based Docker image

Posted by "jbertram (via GitHub)" <gi...@apache.org>.
jbertram commented on PR #4504:
URL: https://github.com/apache/activemq-artemis/pull/4504#issuecomment-1631202079

   @thorstenhirsch, yes exactly. Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [activemq-artemis] thorstenhirsch commented on pull request #4504: ARTEMIS-4310 Add Alpine/Java17 based Docker image

Posted by "thorstenhirsch (via GitHub)" <gi...@apache.org>.
thorstenhirsch commented on PR #4504:
URL: https://github.com/apache/activemq-artemis/pull/4504#issuecomment-1631193190

   Like so...?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [activemq-artemis] jbertram commented on pull request #4504: ARTEMIS-4310 Add Alpine/Java17 based Docker image

Posted by "jbertram (via GitHub)" <gi...@apache.org>.
jbertram commented on PR #4504:
URL: https://github.com/apache/activemq-artemis/pull/4504#issuecomment-1631226120

   I just noticed that the `Dockerfile-alpine-17` file you added is in the root directory rather than in the `artemis-docker` directory with the other Docker files. Can you move the `Dockerfile-alpine-17` file to the `artemis-docker` directory?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [activemq-artemis] jbertram merged pull request #4504: ARTEMIS-4310 Add Alpine/Java17 based Docker image

Posted by "jbertram (via GitHub)" <gi...@apache.org>.
jbertram merged PR #4504:
URL: https://github.com/apache/activemq-artemis/pull/4504


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [activemq-artemis] guptatapan commented on pull request #4504: ARTEMIS-4310 Add Alpine/Java17 based Docker image

Posted by "guptatapan (via GitHub)" <gi...@apache.org>.
guptatapan commented on PR #4504:
URL: https://github.com/apache/activemq-artemis/pull/4504#issuecomment-1593021043

   @thorstenhirsch Does AIO work for you with Alpine?
   I tried it sometime back and it defaulted to use NIO at startup.
   libaio was installed, but I could not get much time to look at it


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [activemq-artemis] jbertram commented on pull request #4504: ARTEMIS-4310 Add Alpine/Java17 based Docker image

Posted by "jbertram (via GitHub)" <gi...@apache.org>.
jbertram commented on PR #4504:
URL: https://github.com/apache/activemq-artemis/pull/4504#issuecomment-1631063564

   @thorstenhirsch, can you squash the commits down into just one?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [activemq-artemis] thorstenhirsch commented on pull request #4504: ARTEMIS-4310 Add Alpine/Java17 based Docker image

Posted by "thorstenhirsch (via GitHub)" <gi...@apache.org>.
thorstenhirsch commented on PR #4504:
URL: https://github.com/apache/activemq-artemis/pull/4504#issuecomment-1588038476

   The only testing I did so far was sending some AMQP messages from a QPID ProtonJ2 client.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [activemq-artemis] jbertram commented on a diff in pull request #4504: ARTEMIS-4310 Add Alpine/Java17 based Docker image

Posted by "jbertram (via GitHub)" <gi...@apache.org>.
jbertram commented on code in PR #4504:
URL: https://github.com/apache/activemq-artemis/pull/4504#discussion_r1235648255


##########
artemis-docker/Dockerfile-alpine-17:
##########
@@ -0,0 +1,71 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+# ActiveMQ Artemis
+
+FROM eclipse-temurin:17-jdk-alpine
+LABEL maintainer="T. Hirsch"

Review Comment:
   This should be "Apache ActiveMQ Team" since you're contributing it to the project.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [activemq-artemis] thorstenhirsch commented on pull request #4504: ARTEMIS-4310 Add Alpine/Java17 based Docker image

Posted by "thorstenhirsch (via GitHub)" <gi...@apache.org>.
thorstenhirsch commented on PR #4504:
URL: https://github.com/apache/activemq-artemis/pull/4504#issuecomment-1589852446

   ./artemis-image looks useful, but I want to use "my" Docker image for an Artemis cluster with Java 17


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [activemq-artemis] thorstenhirsch commented on a diff in pull request #4504: ARTEMIS-4310 Add Alpine/Java17 based Docker image

Posted by "thorstenhirsch (via GitHub)" <gi...@apache.org>.
thorstenhirsch commented on code in PR #4504:
URL: https://github.com/apache/activemq-artemis/pull/4504#discussion_r1235952240


##########
artemis-docker/Dockerfile-alpine-17:
##########
@@ -0,0 +1,71 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+# ActiveMQ Artemis
+
+FROM eclipse-temurin:17-jdk-alpine
+LABEL maintainer="T. Hirsch"

Review Comment:
   fixed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [activemq-artemis] thorstenhirsch commented on pull request #4504: ARTEMIS-4310 Add Alpine/Java17 based Docker image

Posted by "thorstenhirsch (via GitHub)" <gi...@apache.org>.
thorstenhirsch commented on PR #4504:
URL: https://github.com/apache/activemq-artemis/pull/4504#issuecomment-1594970508

   Yes, I just checked it: `Journal Type: ASYNCIO` (on a Linux host). I didn't really know if this really means libaio, so I also checked what Artemis says on my Mac: `NIO`.
   
   So, yes, it looks like Artemis works successfully with libaio in the Alpine Linux image.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [activemq-artemis] clebertsuconic commented on pull request #4504: ARTEMIS-4310 Add Alpine/Java17 based Docker image

Posted by "clebertsuconic (via GitHub)" <gi...@apache.org>.
clebertsuconic commented on PR #4504:
URL: https://github.com/apache/activemq-artemis/pull/4504#issuecomment-1589159415

   You should take a look on ./artemis-image that was added by @gtully 
   
   
   The idea is to not need the ./artemis create before running a server. There will be a new EmbeddedServer that's being used by that image. 
   
   
   it's an effort to simplify the images. Can you take a look?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org