You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by Gillardo <gi...@git.apache.org> on 2015/07/09 13:29:32 UTC
[GitHub] cordova-plugin-camera pull request: Focus control and nicer UI for...
GitHub user Gillardo opened a pull request:
https://github.com/apache/cordova-plugin-camera/pull/106
Focus control and nicer UI for Windows Phone
Create a Take button as well as having the Cancel button. Made the buttons "bootstrap" like, but using styles and not css.
When the cancel button is pressed, the event of Cancelled is reported, which matches all the other platforms.
Added focus control when the screen is clicked.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Gillardo/cordova-plugin-camera master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-camera/pull/106.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #106
----
commit 07b0e826732b73f75de1e434ec39847877b208e5
Author: Gillardo <da...@gmail.com>
Date: 2015-07-09T11:27:32Z
Focus control and nice UI
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: Focus control and nicer UI for...
Posted by Gillardo <gi...@git.apache.org>.
Github user Gillardo commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/106#discussion_r34288832
--- Diff: src/windows/CameraProxy.js ---
@@ -370,10 +395,11 @@ function takePictureFromCameraWP(successCallback, errorCallback, args) {
if (sensor !== null) {
sensor.addEventListener("orientationchanged", onOrientationChange);
}
- capturePreview.addEventListener('click', captureAction);
+ //capturePreview.addEventListener('click', captureAction);
--- End diff --
I will do another commit for u. Probably tomorrow morning now.
I am already signed up and sent my license off as contributed to other
cordova plug in projects
On 9 Jul 2015 7:41 pm, "Murat Sutunc" <no...@github.com> wrote:
> In src/windows/CameraProxy.js
> <https://github.com/apache/cordova-plugin-camera/pull/106#discussion_r34288565>
> :
>
> > @@ -370,10 +395,11 @@ function takePictureFromCameraWP(successCallback, errorCallback, args) {
> > if (sensor !== null) {
> > sensor.addEventListener("orientationchanged", onOrientationChange);
> > }
> > - capturePreview.addEventListener('click', captureAction);
> > + //capturePreview.addEventListener('click', captureAction);
>
> you can iterate with a new commit, I can merge them. Also before I can
> merge your changes, you need to sign Apache's Contributor License Agreement
> (can be done online): http://www.apache.org/licenses/#clas
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/cordova-plugin-camera/pull/106/files#r34288565>
> .
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: Focus control and nicer UI for...
Posted by Gillardo <gi...@git.apache.org>.
Github user Gillardo commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/106#issuecomment-120301455
Believe i have done what you asked?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: Focus control and nicer UI for...
Posted by vladimir-kotikov <gi...@git.apache.org>.
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/106#issuecomment-138863604
@Gillardo, could you please close this one manually.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: Focus control and nicer UI for...
Posted by muratsu <gi...@git.apache.org>.
Github user muratsu commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/106#discussion_r34288565
--- Diff: src/windows/CameraProxy.js ---
@@ -370,10 +395,11 @@ function takePictureFromCameraWP(successCallback, errorCallback, args) {
if (sensor !== null) {
sensor.addEventListener("orientationchanged", onOrientationChange);
}
- capturePreview.addEventListener('click', captureAction);
+ //capturePreview.addEventListener('click', captureAction);
--- End diff --
you can iterate with a new commit, I can merge them. Also before I can merge your changes, you need to sign Apache's Contributor License Agreement (can be done online): http://www.apache.org/licenses/#clas
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: Focus control and nicer UI for...
Posted by Gillardo <gi...@git.apache.org>.
Github user Gillardo closed the pull request at:
https://github.com/apache/cordova-plugin-camera/pull/106
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: Focus control and nicer UI for...
Posted by Gillardo <gi...@git.apache.org>.
Github user Gillardo commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/106#discussion_r34288013
--- Diff: src/windows/CameraProxy.js ---
@@ -370,10 +395,11 @@ function takePictureFromCameraWP(successCallback, errorCallback, args) {
if (sensor !== null) {
sensor.addEventListener("orientationchanged", onOrientationChange);
}
- capturePreview.addEventListener('click', captureAction);
+ //capturePreview.addEventListener('click', captureAction);
--- End diff --
Am I suppose to edit my file with these changes? Never had a "nit" before
On 9 Jul 2015 7:31 pm, "Murat Sutunc" <no...@github.com> wrote:
> In src/windows/CameraProxy.js
> <https://github.com/apache/cordova-plugin-camera/pull/106#discussion_r34287483>
> :
>
> > @@ -370,10 +395,11 @@ function takePictureFromCameraWP(successCallback, errorCallback, args) {
> > if (sensor !== null) {
> > sensor.addEventListener("orientationchanged", onOrientationChange);
> > }
> > - capturePreview.addEventListener('click', captureAction);
> > + //capturePreview.addEventListener('click', captureAction);
>
> nit: remove comment if not necessary
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/cordova-plugin-camera/pull/106/files#r34287483>
> .
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: Focus control and nicer UI for...
Posted by muratsu <gi...@git.apache.org>.
Github user muratsu commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/106#issuecomment-120461767
Thank you @Gillardo ! Merging your changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: Focus control and nicer UI for...
Posted by muratsu <gi...@git.apache.org>.
Github user muratsu commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/106#discussion_r34287483
--- Diff: src/windows/CameraProxy.js ---
@@ -370,10 +395,11 @@ function takePictureFromCameraWP(successCallback, errorCallback, args) {
if (sensor !== null) {
sensor.addEventListener("orientationchanged", onOrientationChange);
}
- capturePreview.addEventListener('click', captureAction);
+ //capturePreview.addEventListener('click', captureAction);
--- End diff --
nit: remove comment if not necessary
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: Focus control and nicer UI for...
Posted by vladimir-kotikov <gi...@git.apache.org>.
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/106#issuecomment-138875519
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: Focus control and nicer UI for...
Posted by Gillardo <gi...@git.apache.org>.
Github user Gillardo commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/106#issuecomment-138869845
done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: Focus control and nicer UI for...
Posted by muratsu <gi...@git.apache.org>.
Github user muratsu commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/106#discussion_r34287365
--- Diff: src/windows/CameraProxy.js ---
@@ -324,13 +325,20 @@ function takePictureFromCameraWP(successCallback, errorCallback, args) {
// z-order style element for capturePreview and captureCancelButton elts
// is necessary to avoid overriding by another page elements, -1 sometimes is not enough
- capturePreview.style.cssText = "position: fixed; left: 0; top: 0; width: 100%; height: 100%; z-index: 999";
+ capturePreview.style.cssText = "position: fixed; left: 0; top: 0; width: 100%; height: 100%; z-index: 999;";
+
+ var buttonStyle = "width:45%;padding: 10px 16px;font-size: 18px;line-height: 1.3333333;color: #333;background-color: #fff;border-color: #ccc; border: 1px solid transparent;border-radius: 6px; display: block; margin: 20px; z-index: 1000;border-color: #adadad;";
+
+ // Create capture button
+ captureTakePhotoButton = document.createElement("button");
+ captureTakePhotoButton.innerText = "Take";
+ captureTakePhotoButton.style.cssText = buttonStyle + "position: fixed; left: 0; bottom: 0; margin: 20px; z-index: 1000";
// Create cancel button
captureCancelButton = document.createElement("button");
captureCancelButton.innerText = "Cancel";
- captureCancelButton.style.cssText = "position: fixed; right: 0; bottom: 0; display: block; margin: 20px; z-index: 1000";
-
+ captureCancelButton.style.cssText = buttonStyle + "position: fixed; right: 0; bottom: 0; margin: 20px; z-index: 1000";
+
--- End diff --
nit: remove trailing whitespace
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org