[jira] [Commented] (NUTCH-2052) Enhance index-static to allow configurable delimiters

["Chris A. Mattmann (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NUTCH-2052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14609546#comment-14609546 ] 

Chris A. Mattmann commented on NUTCH-2052:
------------------------------------------

I see the following failures with this PR:

{noformat}
[mattmann-0420740:~/tmp/nutch-trunk] mattmann% more build/index-static/test/TEST-org.apache.nutch.indexer.staticfield.TestStaticFieldIndexerTest.txt 
Testsuite: org.apache.nutch.indexer.staticfield.TestStaticFieldIndexerTest
Tests run: 3, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 1.085 sec

Testcase: testNormalScenario took 0.444 sec
Testcase: testCustomDelimiters took 0.364 sec
        FAILED
test if doc has field1
junit.framework.AssertionFailedError: test if doc has field1
        at org.apache.nutch.indexer.staticfield.TestStaticFieldIndexerTest.testCustomDelimiters(TestStaticFieldIndexerTest.java:149)

Testcase: testEmptyIndexStatic took 0.126 sec
[mattmann-0420740:~/tmp/nutch-trunk] mattmann% 
{noformat}

Also to apply it I had to do the following (due to extraneous commits included from lewismc) - please git reset --hard HEAD before updating and pushing your PR.

{noformat}
git apply --exclude="*CHANGES.txt" --exclude="*NOTICE.txt" --exclude="*nutch-default.xml" --exclude="*default.properties" < 43.patch
{noformat}


> Enhance index-static to allow configurable delimiters
> -----------------------------------------------------
>
>                 Key: NUTCH-2052
>                 URL: https://issues.apache.org/jira/browse/NUTCH-2052
>             Project: Nutch
>          Issue Type: Improvement
>          Components: indexer
>    Affects Versions: 1.10
>            Reporter: Peter Ciuffetti
>            Assignee: Chris A. Mattmann
>             Fix For: 1.11
>
>
> The index-static plugin has a set of fixed-value delimiters that control the parsing of the property index.static.
> comma is used to separate fields
> colon is used to separate field name from field value
> space is used to separate multiple values in the field
> This set of choices makes it impossible to have a fixed field value containing a space, comma or colon.
> The proposed enhancement is to allow configuration properties to override any of these defaults.
> index.static.fieldsep (default comma)
> index.static.keysep (default colon)
> index.static.valuesep (default space)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)