[jira] [Commented] (PHOENIX-4569) Prepared Statement Performance Improvement

["Ben Gilbert (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PHOENIX-4569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16345388#comment-16345388 ] 

Ben Gilbert commented on PHOENIX-4569:
--------------------------------------

 [^PHOENIX-4569-QueryParserClass.patch] 
The attached patch is an example of the direction I would like to take on this, though it has turned into a bigger change than I thought it would be / would like. If this isn't a direction that the team feels is best I will create another small patch just adding a guava Cache into the org.apache.phoenix.jdbc.PhoenixPreparedStatement class itself.

As its a WIP showing direction I haven't fleshed out with JavaDoc or tests and will wait to hear thoughts.



> Prepared Statement Performance Improvement
> ------------------------------------------
>
>                 Key: PHOENIX-4569
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-4569
>             Project: Phoenix
>          Issue Type: Improvement
>    Affects Versions: 4.13.2
>            Reporter: Ben Gilbert
>            Priority: Minor
>         Attachments: PHOENIX-4569-QueryParserClass.patch, pasted_image_at_2018_01_17_01_27_pm.png
>
>
> From discussion at:
> {code}
> https://lists.apache.org/thread.html/b3530943fa6ba77188abb5f8e8ce8d2b7ab3150aea5aa60707878246@%3Cdev.phoenix.apache.org%3E
> {code}
> The PreparedStatement.parseStatement method accounts for 25% of the time in one of our methods and be good if we could cache that.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)