You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/10/08 14:44:44 UTC

[GitHub] [apisix-java-plugin-runner] soulbird commented on a diff in pull request #200: feat: support for getting upstream response body

soulbird commented on code in PR #200:
URL: https://github.com/apache/apisix-java-plugin-runner/pull/200#discussion_r990650161


##########
runner-core/src/main/java/org/apache/apisix/plugin/runner/handler/RpcCallHandler.java:
##########
@@ -106,6 +107,62 @@ protected void channelRead0(ChannelHandlerContext ctx, A6Request request) {
         }
     }
 
+    private Boolean[] fetchExtraInfo(ChannelHandlerContext ctx, PluginFilterChain chain) {
+        // fetch the nginx variables
+        Set<String> varKeys = new HashSet<>();
+        boolean requiredBody = false;

Review Comment:
   Better to use `requiredReqBody`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org