You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/02/26 17:27:47 UTC
[GitHub] [spark] MaxGekk opened a new pull request #27713:
[SPARK-30759][SQL][3.0] Fix cache initialization in StringRegexExpression
MaxGekk opened a new pull request #27713: [SPARK-30759][SQL][3.0] Fix cache initialization in StringRegexExpression
URL: https://github.com/apache/spark/pull/27713
### What changes were proposed in this pull request?
In the PR, I propose to fix `cache` initialization in `StringRegexExpression` by changing of expected value type in `case Literal(value: String, StringType)` from `String` to `UTF8String`.
This is a backport of #27502 and #27547
### Why are the changes needed?
Actually, the case doesn't work at all because `Literal`'s value has type `UTF8String`, see
<img width="649" alt="Screen Shot 2020-02-08 at 22 45 50" src="https://user-images.githubusercontent.com/1580697/74091681-0d4a2180-4acb-11ea-8a0d-7e8c65f4214e.png">
### Does this PR introduce any user-facing change?
No
### How was this patch tested?
Added new test by `RegexpExpressionsSuite`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27713:
[SPARK-30759][SQL][3.0] Fix cache initialization in StringRegexExpression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27713: [SPARK-30759][SQL][3.0] Fix cache initialization in StringRegexExpression
URL: https://github.com/apache/spark/pull/27713#issuecomment-591676435
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118985/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] rednaxelafx commented on issue #27713:
[SPARK-30759][SQL][3.0] Fix cache initialization in StringRegexExpression
Posted by GitBox <gi...@apache.org>.
rednaxelafx commented on issue #27713: [SPARK-30759][SQL][3.0] Fix cache initialization in StringRegexExpression
URL: https://github.com/apache/spark/pull/27713#issuecomment-591651181
LGTM +1 as well
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on issue #27713:
[SPARK-30759][SQL][3.0] Fix cache initialization in StringRegexExpression
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on issue #27713: [SPARK-30759][SQL][3.0] Fix cache initialization in StringRegexExpression
URL: https://github.com/apache/spark/pull/27713#issuecomment-591552347
I'm fine to have it in 3.0. It's definitely a bug.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27713:
[SPARK-30759][SQL][3.0] Fix cache initialization in StringRegexExpression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27713: [SPARK-30759][SQL][3.0] Fix cache initialization in StringRegexExpression
URL: https://github.com/apache/spark/pull/27713#issuecomment-591546370
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27713:
[SPARK-30759][SQL][3.0] Fix cache initialization in StringRegexExpression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27713: [SPARK-30759][SQL][3.0] Fix cache initialization in StringRegexExpression
URL: https://github.com/apache/spark/pull/27713#issuecomment-591676435
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118985/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27713:
[SPARK-30759][SQL][3.0] Fix cache initialization in StringRegexExpression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27713: [SPARK-30759][SQL][3.0] Fix cache initialization in StringRegexExpression
URL: https://github.com/apache/spark/pull/27713#issuecomment-591676427
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27713:
[SPARK-30759][SQL][3.0] Fix cache initialization in StringRegexExpression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27713: [SPARK-30759][SQL][3.0] Fix cache initialization in StringRegexExpression
URL: https://github.com/apache/spark/pull/27713#issuecomment-591676427
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on issue #27713: [SPARK-30759][SQL][3.0]
Fix cache initialization in StringRegexExpression
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on issue #27713: [SPARK-30759][SQL][3.0] Fix cache initialization in StringRegexExpression
URL: https://github.com/apache/spark/pull/27713#issuecomment-591546090
@cloud-fan @dongjoon-hyun Please, take a look at the PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27713:
[SPARK-30759][SQL][3.0] Fix cache initialization in StringRegexExpression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27713: [SPARK-30759][SQL][3.0] Fix cache initialization in StringRegexExpression
URL: https://github.com/apache/spark/pull/27713#issuecomment-591546383
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23733/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #27713:
[SPARK-30759][SQL][3.0] Fix cache initialization in StringRegexExpression
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #27713: [SPARK-30759][SQL][3.0] Fix cache initialization in StringRegexExpression
URL: https://github.com/apache/spark/pull/27713
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27713:
[SPARK-30759][SQL][3.0] Fix cache initialization in StringRegexExpression
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27713: [SPARK-30759][SQL][3.0] Fix cache initialization in StringRegexExpression
URL: https://github.com/apache/spark/pull/27713#issuecomment-591549275
**[Test build #118985 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118985/testReport)** for PR 27713 at commit [`72660cf`](https://github.com/apache/spark/commit/72660cf25dcc72310ae03fdda7ca084880f8a475).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27713: [SPARK-30759][SQL][3.0]
Fix cache initialization in StringRegexExpression
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27713: [SPARK-30759][SQL][3.0] Fix cache initialization in StringRegexExpression
URL: https://github.com/apache/spark/pull/27713#issuecomment-591549275
**[Test build #118985 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118985/testReport)** for PR 27713 at commit [`72660cf`](https://github.com/apache/spark/commit/72660cf25dcc72310ae03fdda7ca084880f8a475).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27713:
[SPARK-30759][SQL][3.0] Fix cache initialization in StringRegexExpression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27713: [SPARK-30759][SQL][3.0] Fix cache initialization in StringRegexExpression
URL: https://github.com/apache/spark/pull/27713#issuecomment-591546383
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23733/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27713:
[SPARK-30759][SQL][3.0] Fix cache initialization in StringRegexExpression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27713: [SPARK-30759][SQL][3.0] Fix cache initialization in StringRegexExpression
URL: https://github.com/apache/spark/pull/27713#issuecomment-591546370
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on issue #27713:
[SPARK-30759][SQL][3.0] Fix cache initialization in StringRegexExpression
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on issue #27713: [SPARK-30759][SQL][3.0] Fix cache initialization in StringRegexExpression
URL: https://github.com/apache/spark/pull/27713#issuecomment-591677565
Merged to `branch-3.0/branch-2.4` as a bug fix.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27713: [SPARK-30759][SQL][3.0]
Fix cache initialization in StringRegexExpression
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27713: [SPARK-30759][SQL][3.0] Fix cache initialization in StringRegexExpression
URL: https://github.com/apache/spark/pull/27713#issuecomment-591675603
**[Test build #118985 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118985/testReport)** for PR 27713 at commit [`72660cf`](https://github.com/apache/spark/commit/72660cf25dcc72310ae03fdda7ca084880f8a475).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org