You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2021/07/01 08:37:21 UTC
[GitHub] [rocketmq-client-go] fluyu opened a new pull request #693: [ISSUE #650] fix: correctly mark messages to be reconsumed
fluyu opened a new pull request #693:
URL: https://github.com/apache/rocketmq-client-go/pull/693
## What is the purpose of the change
Relates to PULL #619
fixes #650 #618
## Brief changelog
When `SuspendCurrentQueueAMoment` is returned for orderly consumption, `makeMessageToCosumeAgain` should be used instead of `putMessages`, just like the java counterpart.
## Verifying this change
None
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-go] maixiaohai commented on pull request #693: [ISSUE #650] fix: correctly mark messages to be reconsumed
Posted by GitBox <gi...@apache.org>.
maixiaohai commented on pull request #693:
URL: https://github.com/apache/rocketmq-client-go/pull/693#issuecomment-984288953
> @maixiaohai We should mark the milestone
copy~ Thanks for your reminder~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-go] maixiaohai merged pull request #693: [ISSUE #650] fix: correctly mark messages to be reconsumed
Posted by GitBox <gi...@apache.org>.
maixiaohai merged pull request #693:
URL: https://github.com/apache/rocketmq-client-go/pull/693
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-go] maixiaohai commented on pull request #693: [ISSUE #650] fix: correctly mark messages to be reconsumed
Posted by GitBox <gi...@apache.org>.
maixiaohai commented on pull request #693:
URL: https://github.com/apache/rocketmq-client-go/pull/693#issuecomment-980837749
> 这个修改怎么在master看不到
还没有merge
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-go] TankLai commented on pull request #693: [ISSUE #650] fix: correctly mark messages to be reconsumed
Posted by GitBox <gi...@apache.org>.
TankLai commented on pull request #693:
URL: https://github.com/apache/rocketmq-client-go/pull/693#issuecomment-980816455
这个修改怎么在master看不到
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-go] vongosling commented on pull request #693: [ISSUE #650] fix: correctly mark messages to be reconsumed
Posted by GitBox <gi...@apache.org>.
vongosling commented on pull request #693:
URL: https://github.com/apache/rocketmq-client-go/pull/693#issuecomment-981339982
@maixiaohai We should mark the milestone
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-go] codecov-commenter commented on pull request #693: [ISSUE #650] fix: correctly mark messages to be reconsumed
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #693:
URL: https://github.com/apache/rocketmq-client-go/pull/693#issuecomment-872048975
# [Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/693?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#693](https://codecov.io/gh/apache/rocketmq-client-go/pull/693?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f410c92) into [master](https://codecov.io/gh/apache/rocketmq-client-go/commit/c688c190734dcdb6e2fc9b2f6791544d648185a2?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c688c19) will **not change** coverage.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/rocketmq-client-go/pull/693?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #693 +/- ##
=======================================
Coverage 24.71% 24.71%
=======================================
Files 48 48
Lines 5223 5223
=======================================
Hits 1291 1291
Misses 3726 3726
Partials 206 206
```
| [Impacted Files](https://codecov.io/gh/apache/rocketmq-client-go/pull/693?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [consumer/push\_consumer.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/693/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uc3VtZXIvcHVzaF9jb25zdW1lci5nbw==) | `11.84% <0.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/693?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/693?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [c688c19...f410c92](https://codecov.io/gh/apache/rocketmq-client-go/pull/693?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org