You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/01/15 21:11:48 UTC
[GitHub] [pulsar] vzhikserg opened a new pull request #6063: Remove
duplicated lombok annotations in functions instance
vzhikserg opened a new pull request #6063: Remove duplicated lombok annotations in functions instance
URL: https://github.com/apache/pulsar/pull/6063
### Motivation
Some of the classes in the pulsar-functions module had a mixture of the following lombok annotations:
```
@Data
@Setter
@Getter
@EqualsAndHashCode
@ToString
```
The [@Data](https://projectlombok.org/features/Data) annotation includes all other annotations:
> All together now: A shortcut for @ToString, @EqualsAndHashCode, @Getter on all fields, @Setter on all non-final fields, and @RequiredArgsConstructor!
### Modifications
Removed `@Setter`, `@Getter`, `@EqualsAndHashCode`, and '@ToString' if the `@Data` annotation was also present
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] codelipenghui commented on issue #6063: Remove duplicated
lombok annotations in functions instance
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on issue #6063: Remove duplicated lombok annotations in functions instance
URL: https://github.com/apache/pulsar/pull/6063#issuecomment-574953594
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] sijie commented on issue #6063: Remove duplicated lombok
annotations in functions instance
Posted by GitBox <gi...@apache.org>.
sijie commented on issue #6063: Remove duplicated lombok annotations in functions instance
URL: https://github.com/apache/pulsar/pull/6063#issuecomment-575939539
run java8 tests
run integration tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] sijie merged pull request #6063: Remove duplicated lombok
annotations in functions instance
Posted by GitBox <gi...@apache.org>.
sijie merged pull request #6063: Remove duplicated lombok annotations in functions instance
URL: https://github.com/apache/pulsar/pull/6063
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services