You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2014/08/12 01:32:17 UTC
Review Request 24516: Expose pending tasks during reconciliation.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24516/
-----------------------------------------------------------
Review request for mesos, Niklas Nielsen and Vinod Kone.
Bugs: MESOS-1620
https://issues.apache.org/jira/browse/MESOS-1620
Repository: mesos-git
Description
-------
We were not surfacing tasks that are pending validation / authorization.
These are now surfaced as staging tasks
Diffs
-----
src/master/master.cpp e688b41b9f2e555acd8fe0da5d3eb4e8bce32211
src/tests/master_authorization_tests.cpp 5c3557752df86e798ba5d804de588db55ddcfbf6
src/tests/reconciliation_tests.cpp 952f29b97e7516a3aa69e599901bf49cd2b6d596
Diff: https://reviews.apache.org/r/24516/diff/
Testing
-------
Updated the existing test.
I also removed the MasterAuthorizationTest.ReconcileTask test because it was redundant with ReconciliationTest.PendingTask.
Thanks,
Ben Mahler
Re: Review Request 24516: Expose pending tasks during reconciliation.
Posted by Ben Mahler <be...@gmail.com>.
> On Aug. 12, 2014, 9:54 p.m., Vinod Kone wrote:
> > src/master/master.cpp, line 3343
> > <https://reviews.apache.org/r/24516/diff/1/?file=658120#file658120line3343>
> >
> > i don't think we should because that's a cache and people might un-necessarily depend on it.
Agreed, removed this TODO.
- Ben
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24516/#review50371
-----------------------------------------------------------
On Aug. 11, 2014, 11:32 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24516/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2014, 11:32 p.m.)
>
>
> Review request for mesos, Niklas Nielsen and Vinod Kone.
>
>
> Bugs: MESOS-1620
> https://issues.apache.org/jira/browse/MESOS-1620
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> We were not surfacing tasks that are pending validation / authorization.
>
> These are now surfaced as staging tasks
>
>
> Diffs
> -----
>
> src/master/master.cpp e688b41b9f2e555acd8fe0da5d3eb4e8bce32211
> src/tests/master_authorization_tests.cpp 5c3557752df86e798ba5d804de588db55ddcfbf6
> src/tests/reconciliation_tests.cpp 952f29b97e7516a3aa69e599901bf49cd2b6d596
>
> Diff: https://reviews.apache.org/r/24516/diff/
>
>
> Testing
> -------
>
> Updated the existing test.
>
> I also removed the MasterAuthorizationTest.ReconcileTask test because it was redundant with ReconciliationTest.PendingTask.
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request 24516: Expose pending tasks during reconciliation.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24516/#review50371
-----------------------------------------------------------
Ship it!
src/master/master.cpp
<https://reviews.apache.org/r/24516/#comment88135>
i don't think we should because that's a cache and people might un-necessarily depend on it.
src/tests/reconciliation_tests.cpp
<https://reviews.apache.org/r/24516/#comment88137>
update the comment.
src/tests/reconciliation_tests.cpp
<https://reviews.apache.org/r/24516/#comment88138>
update the comment.
src/tests/reconciliation_tests.cpp
<https://reviews.apache.org/r/24516/#comment88141>
update the comment.
- Vinod Kone
On Aug. 11, 2014, 11:32 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24516/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2014, 11:32 p.m.)
>
>
> Review request for mesos, Niklas Nielsen and Vinod Kone.
>
>
> Bugs: MESOS-1620
> https://issues.apache.org/jira/browse/MESOS-1620
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> We were not surfacing tasks that are pending validation / authorization.
>
> These are now surfaced as staging tasks
>
>
> Diffs
> -----
>
> src/master/master.cpp e688b41b9f2e555acd8fe0da5d3eb4e8bce32211
> src/tests/master_authorization_tests.cpp 5c3557752df86e798ba5d804de588db55ddcfbf6
> src/tests/reconciliation_tests.cpp 952f29b97e7516a3aa69e599901bf49cd2b6d596
>
> Diff: https://reviews.apache.org/r/24516/diff/
>
>
> Testing
> -------
>
> Updated the existing test.
>
> I also removed the MasterAuthorizationTest.ReconcileTask test because it was redundant with ReconciliationTest.PendingTask.
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request 24516: Expose pending tasks during reconciliation.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24516/#review50416
-----------------------------------------------------------
Bad patch!
Reviews applied: [24582, 24583, 24576, 24515, 24516]
Failed command: git apply --index 24516.patch
Error:
error: patch failed: src/tests/master_authorization_tests.cpp:523
error: src/tests/master_authorization_tests.cpp: patch does not apply
- Mesos ReviewBot
On Aug. 11, 2014, 11:32 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24516/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2014, 11:32 p.m.)
>
>
> Review request for mesos, Niklas Nielsen and Vinod Kone.
>
>
> Bugs: MESOS-1620
> https://issues.apache.org/jira/browse/MESOS-1620
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> We were not surfacing tasks that are pending validation / authorization.
>
> These are now surfaced as staging tasks
>
>
> Diffs
> -----
>
> src/master/master.cpp e688b41b9f2e555acd8fe0da5d3eb4e8bce32211
> src/tests/master_authorization_tests.cpp 5c3557752df86e798ba5d804de588db55ddcfbf6
> src/tests/reconciliation_tests.cpp 952f29b97e7516a3aa69e599901bf49cd2b6d596
>
> Diff: https://reviews.apache.org/r/24516/diff/
>
>
> Testing
> -------
>
> Updated the existing test.
>
> I also removed the MasterAuthorizationTest.ReconcileTask test because it was redundant with ReconciliationTest.PendingTask.
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request 24516: Expose pending tasks during reconciliation.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24516/
-----------------------------------------------------------
(Updated Aug. 13, 2014, 6:53 p.m.)
Review request for mesos, Niklas Nielsen and Vinod Kone.
Changes
-------
Updated per vinod's review.
Bugs: MESOS-1620
https://issues.apache.org/jira/browse/MESOS-1620
Repository: mesos-git
Description
-------
We were not surfacing tasks that are pending validation / authorization.
These are now surfaced as staging tasks
Diffs (updated)
-----
src/master/master.cpp a8cf9ba07b041a770416ee70a0cff9ef51e0a844
src/tests/master_authorization_tests.cpp f0f064808d8bf36a2a756bc907c477dd6440636c
src/tests/reconciliation_tests.cpp 3c4d7ed886333f0ccc1460178b9e06e7e38246c9
Diff: https://reviews.apache.org/r/24516/diff/
Testing
-------
Updated the existing test.
I also removed the MasterAuthorizationTest.ReconcileTask test because it was redundant with ReconciliationTest.PendingTask.
Thanks,
Ben Mahler