You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by debfx <gi...@git.apache.org> on 2015/03/04 15:38:04 UTC
[GitHub] cloudstack pull request: Debian package improvements
GitHub user debfx opened a pull request:
https://github.com/apache/cloudstack/pull/96
Debian package improvements
A series of commits to clean up the Debian packaging a bit and
work towards making it more Debian Policy compliant.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/debfx/cloudstack 4.5-package
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/96.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #96
----
commit 2acb9712e96195a0667e8410f89206ced993344e
Author: Felix Geyer <fe...@credativ.de>
Date: 2015-02-16T11:21:40Z
Swap maven3 | maven build-dependency.
maven3 is not a package in Debian and buildds look only at the
first alternative.
commit 7c66205b4d5e9279486880b1dc5a23afbbdef4e0
Author: Felix Geyer <fe...@credativ.de>
Date: 2015-02-16T11:41:47Z
Specify maven repo location.
By default it chooses a location based on $HOME which is not guranteed to
have a proper value on buildds.
We also need to take care of cleaning it up after the build.
commit ed7e1521e62be7d05f002c92a2efefb7d3e97e83
Author: Felix Geyer <fe...@credativ.de>
Date: 2015-02-16T12:18:22Z
Convert debian/rules to short dh-style.
commit 99f2e01fe0799817d5dfb4c48f0ae0c911185112
Author: Felix Geyer <fe...@credativ.de>
Date: 2015-02-16T13:04:13Z
Add DEBHELPER tokens to maintainer script.
dh_* tools insert their scripts there.
commit f56df9deeb4f36feafca85dee0f0f16dcaec6296
Author: Felix Geyer <fe...@credativ.de>
Date: 2015-02-16T13:05:15Z
Use /bin/sh and set -e uniformly in maintainer scripts.
commit 145bfa424bff602954582678d71fea66011d1cff
Author: Felix Geyer <fe...@credativ.de>
Date: 2015-02-16T13:20:20Z
Install python files into the correct path.
commit 27beead3bb1105b2ed705ce5ef6121f64a94003f
Author: Felix Geyer <fe...@credativ.de>
Date: 2015-02-16T13:33:11Z
Add proper python dependencies.
commit d161d2174fe8cb377f8251ece12ced61f9e857ae
Author: Felix Geyer <fe...@credativ.de>
Date: 2015-02-16T13:36:50Z
Add adduser dependency to cloudstack-management.
Used in the postinst script.
commit f5d3f10d31a62d7b4c88e59ce1b5a0bceb5e087d
Author: Felix Geyer <fe...@credativ.de>
Date: 2015-02-16T14:06:34Z
Add dependency on ${misc:Depends} to all packages.
commit 5ea8b2ddec6ff547c34bade8d2647b7f6db17153
Author: Felix Geyer <fe...@credativ.de>
Date: 2015-02-16T14:08:43Z
Remove dependencies on essential packages.
They are guaranteed to be present on Debian systems.
commit 2120d31d0849311bc92cc126cc3619c6830d375b
Author: Felix Geyer <fe...@credativ.de>
Date: 2015-02-16T15:19:06Z
Use invoke-rc.d instead of service to stop tomcat.
Debian policy requires that invoke-rc.d is used.
commit 4358b67fff16d4bcc59adea0378917dc226b5a48
Author: Felix Geyer <fe...@credativ.de>
Date: 2015-02-16T16:02:31Z
Register the init scripts.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Debian package improvements
Posted by resmo <gi...@git.apache.org>.
Github user resmo commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/96#discussion_r25807707
--- Diff: debian/control ---
@@ -3,26 +3,26 @@ Section: libs
Priority: extra
Maintainer: Wido den Hollander <wi...@widodh.nl>
Build-Depends: debhelper (>= 7), openjdk-7-jdk, genisoimage,
- python-mysqldb, maven3 | maven (>= 3), python (>= 2.6.6-3~)
+ python-mysqldb, maven (>= 3) | maven3, python-all (>= 2.6.6-3~)
Standards-Version: 3.8.1
Homepage: http://www.cloudstack.org/
Package: cloudstack-common
Architecture: all
-Depends: bash, genisoimage, nfs-common
+Depends: ${misc:Depends}, ${python:Depends}, genisoimage, nfs-common
Conflicts: cloud-scripts, cloud-utils, cloud-system-iso, cloud-console-proxy, cloud-daemonize, cloud-deps, cloud-python, cloud-setup
Description: A common package which contains files which are shared by several CloudStack packages
Package: cloudstack-management
Architecture: all
-Depends: cloudstack-common (= ${source:Version}), tomcat6, sysvinit-utils, sudo, jsvc, python-mysqldb, libmysql-java, python-paramiko, augeas-tools, mysql-client
+Depends: ${misc:Depends}, ${python:Depends}, cloudstack-common (= ${source:Version}), tomcat6, sudo, jsvc, python-mysqldb, libmysql-java, python-paramiko, augeas-tools, mysql-client, adduser
--- End diff --
It has been confirmed that tomcat7 is also working (RHEL7 in packaging). I suggest to change `tomcat6` to `tomcat6 | tomcat7`to support Debian Jessie. What do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Debian package improvements
Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/96#issuecomment-77359928
This looks good, I need to test it. Anyone tested it already?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Debian package improvements
Posted by resmo <gi...@git.apache.org>.
Github user resmo commented on the pull request:
https://github.com/apache/cloudstack/pull/96#issuecomment-77235301
+1 from me
@debfx I recently also saw there is quite a hack in the debian init script for setting `JAVA_HOME` (https://github.com/apache/cloudstack/blob/master/packaging/debian/init/cloud-management#L73). I suggest to replace it with:
~~~
JAVA_HOME=/usr/lib/jvm/default-java
~~~
Thoughts?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Debian package improvements
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/96
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---