[GitHub] [beam] lostluck commented on a change in pull request #11734: [BEAM-9679] Add Core Transforms section / GroupByKey lesson to the Go SDK katas

[GitBox <gi...@apache.org>]

lostluck commented on a change in pull request #11734:
URL: https://github.com/apache/beam/pull/11734#discussion_r427505056



##########
File path: learning/katas/go/Core Transforms/GroupByKey/GroupByKey/test/task_test.go
##########
@@ -0,0 +1,57 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements.  See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License.  You may obtain a copy of the License at
+//
+//    http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package test
+
+import (
+	"github.com/apache/beam/sdks/go/pkg/beam"
+	"github.com/apache/beam/sdks/go/pkg/beam/testing/ptest"
+	"groupbykey/pkg/task"
+	"reflect"
+	"testing"
+)
+
+func TestApplyTransform(t *testing.T) {
+	p, s := beam.NewPipelineWithRoot()
+	tests := []struct {
+		input beam.PCollection
+		want map[string][]string
+	}{
+		{
+			input: beam.Create(s, "apple", "ball", "car", "bear", "cheetah", "ant"),
+			want: map[string][]string{
+				"a": {"apple", "ant"},
+				"b": {"ball", "bear"},
+				"c": {"car", "cheetah"},
+			},
+		},
+	}
+	for _, tt := range tests {
+		got := task.ApplyTransform(s, tt.input)
+		beam.ParDo0(s, func(key string, values func(*string) bool) {
+			var got []string
+			var v string
+			for values(&v) {
+				got = append(got, v)
+			}
+			if !reflect.DeepEqual(got, tt.want[key]) {

Review comment:
       Consider using the cmp package instead of reflect.DeepEqual which doesn't allow handling ordering changes or similar.
   
   https://pkg.go.dev/github.com/google/go-cmp/cmp?tab=doc




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org