You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Chuck Deal (JIRA)" <ji...@apache.org> on 2007/11/01 13:02:02 UTC
[jira] Created: (WICKET-1121) Slight AbstractChoice refactoring
Slight AbstractChoice refactoring
---------------------------------
Key: WICKET-1121
URL: https://issues.apache.org/jira/browse/WICKET-1121
Project: Wicket
Issue Type: Improvement
Components: wicket
Affects Versions: 1.3.0-beta4
Reporter: Chuck Deal
Priority: Trivial
I have had the need to change the way that options were escaped. I found that in order to change the settings, I had to override (and cut-n-paste the entire method) the appendOptionHtml() method to make the small fix. The change I propose is to refactor the escaping code to another method for easier extension.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (WICKET-1121) Slight AbstractChoice refactoring
Posted by "Johan Compagner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Johan Compagner closed WICKET-1121.
-----------------------------------
Resolution: Fixed
Fix Version/s: 1.3.0-beta5
Assignee: Johan Compagner
> Slight AbstractChoice refactoring
> ---------------------------------
>
> Key: WICKET-1121
> URL: https://issues.apache.org/jira/browse/WICKET-1121
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.3.0-beta4
> Reporter: Chuck Deal
> Assignee: Johan Compagner
> Priority: Trivial
> Fix For: 1.3.0-beta5
>
> Attachments: AbstractChoice.java.patch
>
>
> I have had the need to change the way that options were escaped. I found that in order to change the settings, I had to override (and cut-n-paste the entire method) the appendOptionHtml() method to make the small fix. The change I propose is to refactor the escaping code to another method for easier extension.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1121) Slight AbstractChoice refactoring
Posted by "Johan Compagner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12539375 ]
Johan Compagner commented on WICKET-1121:
-----------------------------------------
what is so special about your escaping?
> Slight AbstractChoice refactoring
> ---------------------------------
>
> Key: WICKET-1121
> URL: https://issues.apache.org/jira/browse/WICKET-1121
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.3.0-beta4
> Reporter: Chuck Deal
> Priority: Trivial
> Attachments: AbstractChoice.java.patch
>
>
> I have had the need to change the way that options were escaped. I found that in order to change the settings, I had to override (and cut-n-paste the entire method) the appendOptionHtml() method to make the small fix. The change I propose is to refactor the escaping code to another method for easier extension.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1121) Slight AbstractChoice refactoring
Posted by "Chuck Deal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chuck Deal updated WICKET-1121:
-------------------------------
Attachment: AbstractChoice.java.patch
This is a simple patch that refactors the escaping code into another method for more modular extension.
> Slight AbstractChoice refactoring
> ---------------------------------
>
> Key: WICKET-1121
> URL: https://issues.apache.org/jira/browse/WICKET-1121
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.3.0-beta4
> Reporter: Chuck Deal
> Priority: Trivial
> Attachments: AbstractChoice.java.patch
>
>
> I have had the need to change the way that options were escaped. I found that in order to change the settings, I had to override (and cut-n-paste the entire method) the appendOptionHtml() method to make the small fix. The change I propose is to refactor the escaping code to another method for easier extension.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1121) Slight AbstractChoice refactoring
Posted by "Chuck Deal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12539377 ]
Chuck Deal commented on WICKET-1121:
------------------------------------
Sorry, I didn't mean to imply that I had some special escaping code. I simply needed to change the arguments to Strings.escapeMarkup() where I wanted to set escapeSpaces to true instead of the default false. Without the refactoring, I had to capture the whole method to make that small change. I chose to refactor that out instead of introduce another argument/parameter for greater long-term flexibility.
I've had this change in my codebase for a while, so I thought I'd see if it could make it onto the mainline.
> Slight AbstractChoice refactoring
> ---------------------------------
>
> Key: WICKET-1121
> URL: https://issues.apache.org/jira/browse/WICKET-1121
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.3.0-beta4
> Reporter: Chuck Deal
> Assignee: Johan Compagner
> Priority: Trivial
> Fix For: 1.3.0-beta5
>
> Attachments: AbstractChoice.java.patch
>
>
> I have had the need to change the way that options were escaped. I found that in order to change the settings, I had to override (and cut-n-paste the entire method) the appendOptionHtml() method to make the small fix. The change I propose is to refactor the escaping code to another method for easier extension.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.