You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@samza.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/05/01 00:16:00 UTC
[jira] [Commented] (SAMZA-1243) Flaky test: Multiple tests in
TestLocalStoreMonitor
[ https://issues.apache.org/jira/browse/SAMZA-1243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16459323#comment-16459323 ]
ASF GitHub Bot commented on SAMZA-1243:
---------------------------------------
GitHub user ahmedahamid opened a pull request:
https://github.com/apache/samza/pull/497
SAMZA-1243: Fix flaky tests in TestLocalStoreMonitor
Having attempted to reproduce this issue without success, careful analysis of the code indicates the underlying issue is most likely incomplete cleanup of file system directories after test execution possibly due to incomplete or manual test runs. To address this issue, this fix generates a different local store directory for every test to isolate file system side-effects across different tests and test runs.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ahmedahamid/samza dev/fix-1243
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/samza/pull/497.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #497
----
commit 5ad2f47545b6c33fb389ab0d3231ea041d1ca7f5
Author: Ahmed Abdul Hamid <ah...@...>
Date: 2018-04-30T22:15:18Z
SAMZA-1243: Fix flaky tests in TestLocalStoreMonitor
Having attempted to reproduce this issue without success, careful analysis of the code indicates the underlying issue is most likely incomplete cleanup of file system directories after test execution possibly due to incomplete manual test runs. To address this issue, this fix generates a different local store directory for every test to isolate file system side-effects across different tests and test runs.
----
> Flaky test: Multiple tests in TestLocalStoreMonitor
> ---------------------------------------------------
>
> Key: SAMZA-1243
> URL: https://issues.apache.org/jira/browse/SAMZA-1243
> Project: Samza
> Issue Type: Bug
> Reporter: Prateek Maheshwari
> Assignee: Shanthoosh Venkataraman
> Priority: Major
> Fix For: 0.15.0
>
>
> Failed locally on my laptop (OS X).
> At commit 35a5cd9ad210a3246eff530b5d74145225cbe5d2.
> {code}
> :samza-rest:test
> shouldDeleteTaskStoreWhenTaskPreferredStoreIsNotLocalHost FAILED
> junit.framework.AssertionFailedError: expected:<1> but was:<2>
> at junit.framework.Assert.fail(Assert.java:57)
> at junit.framework.Assert.failNotEquals(Assert.java:329)
> at junit.framework.Assert.assertEquals(Assert.java:78)
> at junit.framework.Assert.assertEquals(Assert.java:159)
> at junit.framework.Assert.assertEquals(Assert.java:166)
> at junit.framework.TestCase.assertEquals(TestCase.java:324)
> at org.apache.samza.monitor.TestLocalStoreMonitor.shouldDeleteTaskStoreWhenTaskPreferredStoreIsNotLocalHost(TestLocalStoreMonitor.java:159)
> shouldDeleteLocalTaskStoreWhenItHasNoOffsetFile FAILED
> junit.framework.AssertionFailedError: expected:<1> but was:<2>
> at junit.framework.Assert.fail(Assert.java:57)
> at junit.framework.Assert.failNotEquals(Assert.java:329)
> at junit.framework.Assert.assertEquals(Assert.java:78)
> at junit.framework.Assert.assertEquals(Assert.java:159)
> at junit.framework.Assert.assertEquals(Assert.java:166)
> at junit.framework.TestCase.assertEquals(TestCase.java:324)
> at org.apache.samza.monitor.TestLocalStoreMonitor.shouldDeleteLocalTaskStoreWhenItHasNoOffsetFile(TestLocalStoreMonitor.java:105)
> 30 tests completed, 2 failed, 2 skipped
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)