[GitHub] [superset] zephyring commented on a diff in pull request #23414: fix: prevent ForeignKeyViolation error on delete

["zephyring (via GitHub)" <gi...@apache.org>]

zephyring commented on code in PR #23414:
URL: https://github.com/apache/superset/pull/23414#discussion_r1144128212


##########
superset/charts/commands/delete.py:
##########
@@ -45,8 +45,13 @@ def __init__(self, model_id: int):
 
     def run(self) -> Model:
         self.validate()
+        self._model = cast(Slice, self._model)

Review Comment:
   is this necessary? The doc said `This returns the value unchanged.` but only good for type checker



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org