You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@iceberg.apache.org by GitBox <gi...@apache.org> on 2018/12/07 18:26:56 UTC

[GitHub] rdblue commented on issue #38: Add column comments to Iceberg schemas

rdblue commented on issue #38: Add column comments to Iceberg schemas
URL: https://github.com/apache/incubator-iceberg/issues/38#issuecomment-445321961
 
 
   @govi20, I just saw your comment on the old issue. If you're still interested in working on this, feel free to open a PR!
   
   You'll need to add a comment string to the field level in the type system. Basically, anything that gets an ID would be able to carry a comment. Next, you'd need to add those comments to the JSON parser for schemas to ensure they are persisted in table metadata. I think there should also be a flag that turns on comment serialization because we don't want them everywhere -- like when we send a schema to tasks -- we just want them in table metadata.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services