You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Arvind Prabhakar <ar...@cloudera.com> on 2010/07/08 00:33:04 UTC
Review Request: Fix for HIVE-1453
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/280/
-----------------------------------------------------------
Review request for Hive Developers.
Summary
-------
Modified launch configurations to use parameterized version from build configuration instead of hardcoding specific versions.
Diffs
-----
eclipse-templates/HiveCLI.launchtemplate 83b5195
eclipse-templates/TestCliDriver.launchtemplate 8833251
eclipse-templates/TestHive.launchtemplate 4d740ad
eclipse-templates/TestJdbc.launchtemplate 2f75b17
eclipse-templates/TestMTQueries.launchtemplate d21b579
eclipse-templates/TestTruncate.launchtemplate fcde6b8
Diff: http://review.hbase.org/r/280/diff
Testing
-------
Executed all launch configurations - they now seem to work as expected.
Thanks,
Arvind
Re: Review Request: Fix for HIVE-1453
Posted by Carl Steinbach <ca...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/280/#review321
-----------------------------------------------------------
Ship it!
+1 Looks good to me.
- Carl
On 2010-07-07 16:48:34, Arvind Prabhakar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://review.hbase.org/r/280/
> -----------------------------------------------------------
>
> (Updated 2010-07-07 16:48:34)
>
>
> Review request for Hive Developers.
>
>
> Summary
> -------
>
> Modified launch configurations to use parameterized version from build configuration instead of hardcoding specific versions.
>
>
> This addresses bug HIVE-1453.
> http://issues.apache.org/jira/browse/HIVE-1453
>
>
> Diffs
> -----
>
> eclipse-templates/HiveCLI.launchtemplate 83b5195
> eclipse-templates/TestCliDriver.launchtemplate 8833251
> eclipse-templates/TestHive.launchtemplate 4d740ad
> eclipse-templates/TestJdbc.launchtemplate 2f75b17
> eclipse-templates/TestMTQueries.launchtemplate d21b579
> eclipse-templates/TestTruncate.launchtemplate fcde6b8
>
> Diff: http://review.hbase.org/r/280/diff
>
>
> Testing
> -------
>
> Executed all launch configurations - they now seem to work as expected.
>
>
> Thanks,
>
> Arvind
>
>
Re: Review Request: Fix for HIVE-1453
Posted by Carl Steinbach <ca...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/280/
-----------------------------------------------------------
(Updated 2010-07-07 16:48:34.380890)
Review request for Hive Developers.
Summary
-------
Modified launch configurations to use parameterized version from build configuration instead of hardcoding specific versions.
This addresses bug HIVE-1453.
http://issues.apache.org/jira/browse/HIVE-1453
Diffs
-----
eclipse-templates/HiveCLI.launchtemplate 83b5195
eclipse-templates/TestCliDriver.launchtemplate 8833251
eclipse-templates/TestHive.launchtemplate 4d740ad
eclipse-templates/TestJdbc.launchtemplate 2f75b17
eclipse-templates/TestMTQueries.launchtemplate d21b579
eclipse-templates/TestTruncate.launchtemplate fcde6b8
Diff: http://review.hbase.org/r/280/diff
Testing
-------
Executed all launch configurations - they now seem to work as expected.
Thanks,
Arvind