[jira] [Commented] (AIRFLOW-3657) version 2.7.0 and above of zdesk breaks airflow - setup.py should specify zdesk pypy version

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-3657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16738092#comment-16738092 ] 

ASF GitHub Bot commented on AIRFLOW-3657:
-----------------------------------------

tkaymak commented on pull request #4466: [AIRFLOW-3657] Specify zdesk package version in setup.py
URL: https://github.com/apache/airflow/pull/4466
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [X] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW-3657)
     - https://issues.apache.org/jira/browse/AIRFLOW-3657
   
   ### Description
   
   - Specifying zdesk package version in setup.py is required, as zendesk_hook uses unnamed argument and the signature of the method changed in version 2.7.0 and above
   
   ### Tests
   
   - [X] My PR does not need testing for this extremely good reason: One line change in setup.py
   
   ### Commits
   
   - [X] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [X] In case of new functionality, my PR adds documentation that describes how to use it.
     - When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.
     - All the public functions and the classes in the PR contain docstrings that explain what it does
   
   ### Code Quality
   
   - [X] Passes `flake8`
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> version 2.7.0 and above of zdesk breaks airflow - setup.py should specify zdesk pypy version
> --------------------------------------------------------------------------------------------
>
>                 Key: AIRFLOW-3657
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-3657
>             Project: Apache Airflow
>          Issue Type: Bug
>    Affects Versions: 1.10.1
>            Reporter: Tobias Kaymak
>            Assignee: Tobias Kaymak
>            Priority: Major
>
> Currently, the zdesk package version is undefined, resulting in the newest available being installed when selecting zendesk during setup.
> The init method of the package has changed between version 2.6.0 and 2.7.0, therefore airflow will not work with the newer version, as it does use unnamed variable arguments.
> Quickfix is to bind the zdesk package version to 2.6.0 in setup.py - better is to use named arguments in the get_conn() method in the zendesk_hook.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)