You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Sailaja Polavarapu <sp...@hortonworks.com> on 2020/12/02 18:22:19 UTC
Review Request 73059: RANGER-3101: Added code to handle updating
users in
case of previous errors. Also added extra checks while computing roles for
users
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73059/
-----------------------------------------------------------
Review request for ranger.
Bugs: RANGER-3101
https://issues.apache.org/jira/browse/RANGER-3101
Repository: ranger
Description
-------
Getting the id of the user from DB before updating as the one from usersync cache might not be correct. Also added some error checks while computing roles for the users.
Diffs
-----
security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java 4a371f83b
ugsync/src/main/java/org/apache/ranger/unixusersync/process/PolicyMgrUserGroupBuilder.java f911f22d4
Diff: https://reviews.apache.org/r/73059/diff/1/
Testing
-------
1. Patched cluster and tested for functionality and regressions.
Thanks,
Sailaja Polavarapu
Re: Review Request 73059: RANGER-3101: Added code to handle updating
users
in case of previous errors. Also added extra checks while computing roles
for users
Posted by Velmurugan Periasamy <vp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73059/#review222355
-----------------------------------------------------------
Ship it!
Ship It!
- Velmurugan Periasamy
On Dec. 16, 2020, 1:02 a.m., Sailaja Polavarapu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73059/
> -----------------------------------------------------------
>
> (Updated Dec. 16, 2020, 1:02 a.m.)
>
>
> Review request for ranger.
>
>
> Bugs: RANGER-3101
> https://issues.apache.org/jira/browse/RANGER-3101
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Getting the id of the user from DB before updating as the one from usersync cache might not be correct. Also added some error checks while computing roles for the users.
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java 4a371f83b
> security-admin/src/main/java/org/apache/ranger/service/XGroupUserService.java 050999909
> ugsync/src/main/java/org/apache/ranger/unixusersync/process/PolicyMgrUserGroupBuilder.java ee9a2541b
>
>
> Diff: https://reviews.apache.org/r/73059/diff/2/
>
>
> Testing
> -------
>
> 1. Patched cluster and tested for functionality and regressions.
>
>
> Thanks,
>
> Sailaja Polavarapu
>
>
Re: Review Request 73059: RANGER-3101: Added code to handle updating
users
in case of previous errors. Also added extra checks while computing roles
for users
Posted by Sailaja Polavarapu <sp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73059/
-----------------------------------------------------------
(Updated Dec. 16, 2020, 1:02 a.m.)
Review request for ranger.
Changes
-------
Added some more error checks
Bugs: RANGER-3101
https://issues.apache.org/jira/browse/RANGER-3101
Repository: ranger
Description
-------
Getting the id of the user from DB before updating as the one from usersync cache might not be correct. Also added some error checks while computing roles for the users.
Diffs (updated)
-----
security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java 4a371f83b
security-admin/src/main/java/org/apache/ranger/service/XGroupUserService.java 050999909
ugsync/src/main/java/org/apache/ranger/unixusersync/process/PolicyMgrUserGroupBuilder.java ee9a2541b
Diff: https://reviews.apache.org/r/73059/diff/2/
Changes: https://reviews.apache.org/r/73059/diff/1-2/
Testing
-------
1. Patched cluster and tested for functionality and regressions.
Thanks,
Sailaja Polavarapu