You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by "Brett Porter (JIRA)" <ji...@codehaus.org> on 2005/08/08 01:31:57 UTC
[jira] Created: (MPXDOC-155) xdoc 1.9 not compatible with older customised site.jsl
xdoc 1.9 not compatible with older customised site.jsl
------------------------------------------------------
Key: MPXDOC-155
URL: http://jira.codehaus.org/browse/MPXDOC-155
Project: maven-xdoc-plugin
Type: Bug
Versions: 1.9, 1.9.1
Reporter: Brett Porter
Assigned to: Arnaud Heritier
Fix For: 1.9.2
jakarta commons have a customised site.jsl. This is the only way to customise the layout of the page, so the interface between that and plugin.jelly needs to remain consistent. However, it appears that this no longer works the ssame after upgrading to 1.9.
This may be a problem specific to commons (reports and pieces of the navigation are missing), and needs more investigation. Phil Steitz is looking at it and reported the problem.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MPXDOC-155) xdoc 1.9 not compatible with older customised site.jsl
Posted by "Lukas Theussl (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MPXDOC-155?page=comments#action_45379 ]
Lukas Theussl commented on MPXDOC-155:
--------------------------------------
Are there any news on this? Just wondering if we can still fix this for 1.9.2.
> xdoc 1.9 not compatible with older customised site.jsl
> ------------------------------------------------------
>
> Key: MPXDOC-155
> URL: http://jira.codehaus.org/browse/MPXDOC-155
> Project: maven-xdoc-plugin
> Type: Bug
> Versions: 1.9, 1.9.1
> Reporter: Brett Porter
> Fix For: 1.9.2
>
>
> jakarta commons have a customised site.jsl. This is the only way to customise the layout of the page, so the interface between that and plugin.jelly needs to remain consistent. However, it appears that this no longer works the ssame after upgrading to 1.9.
> This may be a problem specific to commons (reports and pieces of the navigation are missing), and needs more investigation. Phil Steitz is looking at it and reported the problem.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MPXDOC-155) xdoc 1.9 not compatible with older customised site.jsl
Posted by "Phil Steitz (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MPXDOC-155?page=comments#action_45514 ]
Phil Steitz commented on MPXDOC-155:
------------------------------------
Works 4 me. I checked a couple of commons sites and they all look fine, once I add the message template to commons-site.jsl. Thanks!
Note: when installing the plugin snapshot, I had to also download maven-model-3.0.1-SNAPSHOT.
> xdoc 1.9 not compatible with older customised site.jsl
> ------------------------------------------------------
>
> Key: MPXDOC-155
> URL: http://jira.codehaus.org/browse/MPXDOC-155
> Project: maven-xdoc-plugin
> Type: Bug
> Versions: 1.9, 1.9.1
> Reporter: Brett Porter
> Assignee: Lukas Theussl
> Fix For: 1.9.2
> Attachments: MPXDOC-155.patch
>
>
> jakarta commons have a customised site.jsl. This is the only way to customise the layout of the page, so the interface between that and plugin.jelly needs to remain consistent. However, it appears that this no longer works the ssame after upgrading to 1.9.
> This may be a problem specific to commons (reports and pieces of the navigation are missing), and needs more investigation. Phil Steitz is looking at it and reported the problem.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Closed: (MPXDOC-155) xdoc 1.9 not compatible with older customised site.jsl
Posted by "Arnaud Heritier (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MPXDOC-155?page=all ]
Arnaud Heritier closed MPXDOC-155:
----------------------------------
Resolution: Fixed
Patch applied. thanks.
> xdoc 1.9 not compatible with older customised site.jsl
> ------------------------------------------------------
>
> Key: MPXDOC-155
> URL: http://jira.codehaus.org/browse/MPXDOC-155
> Project: maven-xdoc-plugin
> Type: Bug
> Versions: 1.9, 1.9.1
> Reporter: Brett Porter
> Assignee: Arnaud Heritier
> Fix For: 1.9.2
> Attachments: MPXDOC-155.patch
>
>
> jakarta commons have a customised site.jsl. This is the only way to customise the layout of the page, so the interface between that and plugin.jelly needs to remain consistent. However, it appears that this no longer works the ssame after upgrading to 1.9.
> This may be a problem specific to commons (reports and pieces of the navigation are missing), and needs more investigation. Phil Steitz is looking at it and reported the problem.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MPXDOC-155) xdoc 1.9 not compatible with older customised site.jsl
Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MPXDOC-155?page=comments#action_45541 ]
Brett Porter commented on MPXDOC-155:
-------------------------------------
do you require 3.0.1? If not, I suggest 3.0.0...
> xdoc 1.9 not compatible with older customised site.jsl
> ------------------------------------------------------
>
> Key: MPXDOC-155
> URL: http://jira.codehaus.org/browse/MPXDOC-155
> Project: maven-xdoc-plugin
> Type: Bug
> Versions: 1.9, 1.9.1
> Reporter: Brett Porter
> Assignee: Lukas Theussl
> Fix For: 1.9.2
> Attachments: MPXDOC-155.patch
>
>
> jakarta commons have a customised site.jsl. This is the only way to customise the layout of the page, so the interface between that and plugin.jelly needs to remain consistent. However, it appears that this no longer works the ssame after upgrading to 1.9.
> This may be a problem specific to commons (reports and pieces of the navigation are missing), and needs more investigation. Phil Steitz is looking at it and reported the problem.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MPXDOC-155) xdoc 1.9 not compatible with older customised site.jsl
Posted by "Arnaud Heritier (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MPXDOC-155?page=comments#action_45511 ]
Arnaud Heritier commented on MPXDOC-155:
----------------------------------------
I published a new snapshot for this plugin.
You can download it with :
maven plugin:download -DgroupId=maven -DartifactId=maven-xdoc-plugin -Dversion=1.9.2-SNAPSHOT -Dmaven.repo.remote=http://cvs.apache.org/repository/
> xdoc 1.9 not compatible with older customised site.jsl
> ------------------------------------------------------
>
> Key: MPXDOC-155
> URL: http://jira.codehaus.org/browse/MPXDOC-155
> Project: maven-xdoc-plugin
> Type: Bug
> Versions: 1.9, 1.9.1
> Reporter: Brett Porter
> Assignee: Lukas Theussl
> Fix For: 1.9.2
> Attachments: MPXDOC-155.patch
>
>
> jakarta commons have a customised site.jsl. This is the only way to customise the layout of the page, so the interface between that and plugin.jelly needs to remain consistent. However, it appears that this no longer works the ssame after upgrading to 1.9.
> This may be a problem specific to commons (reports and pieces of the navigation are missing), and needs more investigation. Phil Steitz is looking at it and reported the problem.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MPXDOC-155) xdoc 1.9 not compatible with older customised site.jsl
Posted by "Phil Steitz (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MPXDOC-155?page=comments#action_45383 ]
Phil Steitz commented on MPXDOC-155:
------------------------------------
The navigation problem is due to the fact that the project-nav.xml generated by the 1.9+ version omits the name attribute from items. The "old" project menu items looked like this:
<item href="/mail-lists.html" name="Mailing Lists">
but the "new" items look like this
<item bundle="plugin-resources/templates/templates" href="/mail-lists.html" key="navigation.menu.item.mailing_lists">
The commons-site.jsl needs the name to be present.
The problems with generated reports appear to be similar. The generated xdocs for the team list, for example, omit names from section headings, e.g.,
<section key="template.team_list.section.title"
bundle="plugin-resources\templates\templates">
The old version had
<section name="The Team">
Here again, our jsl looks for the name attribute.
I started making changes to the commons-site.jsl to get this to work with both versions, but this got complicated. It would be great if the plugin could be patched to include the dropped attributes with default locale values.
To see all of the issues, just check out any Jakarta commons project (I have been testing with math and betwixt) along with commons-build as a peer and execute the xdoc goal. The style sheet is commons-build/commons-site.jsl.
> xdoc 1.9 not compatible with older customised site.jsl
> ------------------------------------------------------
>
> Key: MPXDOC-155
> URL: http://jira.codehaus.org/browse/MPXDOC-155
> Project: maven-xdoc-plugin
> Type: Bug
> Versions: 1.9, 1.9.1
> Reporter: Brett Porter
> Fix For: 1.9.2
>
>
> jakarta commons have a customised site.jsl. This is the only way to customise the layout of the page, so the interface between that and plugin.jelly needs to remain consistent. However, it appears that this no longer works the ssame after upgrading to 1.9.
> This may be a problem specific to commons (reports and pieces of the navigation are missing), and needs more investigation. Phil Steitz is looking at it and reported the problem.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MPXDOC-155) xdoc 1.9 not compatible with older customised site.jsl
Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MPXDOC-155?page=comments#action_45381 ]
Brett Porter commented on MPXDOC-155:
-------------------------------------
it would be nice, but I wouldn't hold off the release for it.
> xdoc 1.9 not compatible with older customised site.jsl
> ------------------------------------------------------
>
> Key: MPXDOC-155
> URL: http://jira.codehaus.org/browse/MPXDOC-155
> Project: maven-xdoc-plugin
> Type: Bug
> Versions: 1.9, 1.9.1
> Reporter: Brett Porter
> Fix For: 1.9.2
>
>
> jakarta commons have a customised site.jsl. This is the only way to customise the layout of the page, so the interface between that and plugin.jelly needs to remain consistent. However, it appears that this no longer works the ssame after upgrading to 1.9.
> This may be a problem specific to commons (reports and pieces of the navigation are missing), and needs more investigation. Phil Steitz is looking at it and reported the problem.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: [jira] Updated: (MPXDOC-155) xdoc 1.9 not compatible with older
customised site.jsl
Posted by Brett Porter <br...@apache.org>.
Phil Steitz wrote:
>
> I just realized that this creates an incompatibility with earlier
> versions of the plugin (<= 1.8), since it references the fmt library,
> which does not seem to be available to the 1.8 plugin. Somehow I
> missed this in my testing. Is there a workaround that will allow <=
> 1.8 versions of the plugin to work with this?
>
I think you have a few alternatives:
- remove the i18n ability and references to fmt tag library (I think
this will work off the top of my head)
- add a dependency on the 1.9.2 plugin in commons-build
- add a dependency on the format tag library in commons-build (not sure
this will work).
Cheers,
Brett
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: [jira] Updated: (MPXDOC-155) xdoc 1.9 not compatible with older
customised site.jsl
Posted by Phil Steitz <ph...@steitz.com>.
Lukas Theussl (JIRA) wrote:
> [ http://jira.codehaus.org/browse/MPXDOC-155?page=all ]
>
> Lukas Theussl updated MPXDOC-155: ---------------------------------
>
> Attachment: MPXDOC-155.patch
>
> Hi Phil, Can you test the attached patch please? I have successfully
> generated the site for jakarta math with it. There are a few layout
> differences to the published web site, so I'd like to make sure I
> haven't overlooked anything.
>
> The only thing you have to do is copy the <jsl:template
> match="message"> template from xdoc's site.jsl into
> commons-site.jsl. You might want to adjust it later but it works as
> it is.
I just realized that this creates an incompatibility with earlier
versions of the plugin (<= 1.8), since it references the fmt library,
which does not seem to be available to the 1.8 plugin. Somehow I missed
this in my testing. Is there a workaround that will allow <= 1.8
versions of the plugin to work with this?
Phil
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Updated: (MPXDOC-155) xdoc 1.9 not compatible with older customised site.jsl
Posted by "Lukas Theussl (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MPXDOC-155?page=all ]
Lukas Theussl updated MPXDOC-155:
---------------------------------
Attachment: MPXDOC-155.patch
Hi Phil,
Can you test the attached patch please? I have successfully generated the site for jakarta math with it. There are a few layout differences to the published web site, so I'd like to make sure I haven't overlooked anything.
The only thing you have to do is copy the <jsl:template match="message"> template from xdoc's site.jsl into commons-site.jsl. You might want to adjust it later but it works as it is.
Side note: I have hard-coded the old (english) expressions for the name attributes into the xml templates. I think that should be ok here since it is only a backwards-compatibility fix. People writing new customized jsl's will have to do it according to the new xdoc conventions anyway (ie use 'key' instead of 'name').
> xdoc 1.9 not compatible with older customised site.jsl
> ------------------------------------------------------
>
> Key: MPXDOC-155
> URL: http://jira.codehaus.org/browse/MPXDOC-155
> Project: maven-xdoc-plugin
> Type: Bug
> Versions: 1.9, 1.9.1
> Reporter: Brett Porter
> Fix For: 1.9.2
> Attachments: MPXDOC-155.patch
>
>
> jakarta commons have a customised site.jsl. This is the only way to customise the layout of the page, so the interface between that and plugin.jelly needs to remain consistent. However, it appears that this no longer works the ssame after upgrading to 1.9.
> This may be a problem specific to commons (reports and pieces of the navigation are missing), and needs more investigation. Phil Steitz is looking at it and reported the problem.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MPXDOC-155) xdoc 1.9 not compatible with older customised site.jsl
Posted by "Arnaud Heritier (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MPXDOC-155?page=comments#action_45539 ]
Arnaud Heritier commented on MPXDOC-155:
----------------------------------------
Yes, I upgraded the maven-model on my machine (I'm trying to unify dependencies in all plugins) but I'm not sure we'll use it for the xdoc release or if we'll release maven-model 3.0.1 before.
> xdoc 1.9 not compatible with older customised site.jsl
> ------------------------------------------------------
>
> Key: MPXDOC-155
> URL: http://jira.codehaus.org/browse/MPXDOC-155
> Project: maven-xdoc-plugin
> Type: Bug
> Versions: 1.9, 1.9.1
> Reporter: Brett Porter
> Assignee: Lukas Theussl
> Fix For: 1.9.2
> Attachments: MPXDOC-155.patch
>
>
> jakarta commons have a customised site.jsl. This is the only way to customise the layout of the page, so the interface between that and plugin.jelly needs to remain consistent. However, it appears that this no longer works the ssame after upgrading to 1.9.
> This may be a problem specific to commons (reports and pieces of the navigation are missing), and needs more investigation. Phil Steitz is looking at it and reported the problem.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Updated: (MPXDOC-155) xdoc 1.9 not compatible with older customised site.jsl
Posted by "Arnaud Heritier (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MPXDOC-155?page=all ]
Arnaud Heritier updated MPXDOC-155:
-----------------------------------
Assign To: (was: Arnaud Heritier)
> xdoc 1.9 not compatible with older customised site.jsl
> ------------------------------------------------------
>
> Key: MPXDOC-155
> URL: http://jira.codehaus.org/browse/MPXDOC-155
> Project: maven-xdoc-plugin
> Type: Bug
> Versions: 1.9, 1.9.1
> Reporter: Brett Porter
> Fix For: 1.9.2
>
>
> jakarta commons have a customised site.jsl. This is the only way to customise the layout of the page, so the interface between that and plugin.jelly needs to remain consistent. However, it appears that this no longer works the ssame after upgrading to 1.9.
> This may be a problem specific to commons (reports and pieces of the navigation are missing), and needs more investigation. Phil Steitz is looking at it and reported the problem.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MPXDOC-155) xdoc 1.9 not compatible with older customised site.jsl
Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MPXDOC-155?page=comments#action_45384 ]
Brett Porter commented on MPXDOC-155:
-------------------------------------
thanks Phil. That should be reasonably easy to resolve (I think include the name and the key, and just use the key from xdoc and the name in the old jsl). Let's leave it scheduled for 1.9.2 and get that out as soon as it is rectified.
> xdoc 1.9 not compatible with older customised site.jsl
> ------------------------------------------------------
>
> Key: MPXDOC-155
> URL: http://jira.codehaus.org/browse/MPXDOC-155
> Project: maven-xdoc-plugin
> Type: Bug
> Versions: 1.9, 1.9.1
> Reporter: Brett Porter
> Fix For: 1.9.2
>
>
> jakarta commons have a customised site.jsl. This is the only way to customise the layout of the page, so the interface between that and plugin.jelly needs to remain consistent. However, it appears that this no longer works the ssame after upgrading to 1.9.
> This may be a problem specific to commons (reports and pieces of the navigation are missing), and needs more investigation. Phil Steitz is looking at it and reported the problem.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MPXDOC-155) xdoc 1.9 not compatible with older customised site.jsl
Posted by "Arnaud Heritier (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MPXDOC-155?page=comments#action_45557 ]
Arnaud Heritier commented on MPXDOC-155:
----------------------------------------
No I don't need it. I was trying to unify dependencies between plugins and between plugins and core to identify some errors due to some releases of external libs ( not simple when we use several releases of the same lib in different plugins). I'll not commit these changes now. It was just to publish the snapshot, i didn't take the time to remove my change.
> xdoc 1.9 not compatible with older customised site.jsl
> ------------------------------------------------------
>
> Key: MPXDOC-155
> URL: http://jira.codehaus.org/browse/MPXDOC-155
> Project: maven-xdoc-plugin
> Type: Bug
> Versions: 1.9, 1.9.1
> Reporter: Brett Porter
> Assignee: Lukas Theussl
> Fix For: 1.9.2
> Attachments: MPXDOC-155.patch
>
>
> jakarta commons have a customised site.jsl. This is the only way to customise the layout of the page, so the interface between that and plugin.jelly needs to remain consistent. However, it appears that this no longer works the ssame after upgrading to 1.9.
> This may be a problem specific to commons (reports and pieces of the navigation are missing), and needs more investigation. Phil Steitz is looking at it and reported the problem.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org