You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by Barryrowe <gi...@git.apache.org> on 2014/08/07 18:18:34 UTC
[GitHub] cordova-plugin-inappbrowser pull request: Hide status bar in iOS 7...
GitHub user Barryrowe opened a pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/59
Hide status bar in iOS 7 with option
This minor change allows you to use an option "hidestatusbar=yes" to hide the status bar in IOS 7. It implements the perferStatusBarHidden method. It defaults to NO, so that functionality does not change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Barryrowe/cordova-plugin-inappbrowser hide-status-bar
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-inappbrowser/pull/59.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #59
----
commit bd925e0366b70970c02b00fbfe13574448180329
Author: Barryrowe <ba...@gmail.com>
Date: 2014-08-07T14:40:42Z
Adding prefersStatusBarHidden method to view
Adding this method to see if it will work for our purposes.
commit 4715f28390cde890d137a91feb3f22020b12178b
Author: Barryrowe <ba...@gmail.com>
Date: 2014-08-07T16:10:55Z
Support property hidestatusbar to hide status bar
This adds support for hiding the status bar as an option passed to
the view. This is the iOS 7 way of hiding the status bar.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugin-inappbrowser pull request: Hide status bar in iOS 7...
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/59#issuecomment-55670809
Filed: https://issues.apache.org/jira/browse/CB-7559
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugin-inappbrowser pull request: Hide status bar in iOS 7...
Posted by Barryrowe <gi...@git.apache.org>.
Github user Barryrowe commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/59#issuecomment-55667678
Commit bd925e0 originally set to YES, but with commit 4715f28 this is switched to pull the value of the passed in property, which should default to NO.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugin-inappbrowser pull request: Hide status bar in iOS 7...
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/59#issuecomment-55670707
Thanks for the contrib. Some administration needed before this can be pulled in:
1. You will need to sign an Apache iCLA (I didn't see your name in the list of people that have signed it). See: CONTRIBUTING.md in this repo
2. Please contrib docs for this new feature as well: https://github.com/apache/cordova-plugin-inappbrowser/blob/master/doc/index.md
I will add the JIRA issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugin-inappbrowser pull request: Hide status bar in iOS 7...
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/59#issuecomment-55658241
Actually your code sets the default to YES?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---