You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@sis.apache.org by de...@apache.org on 2022/03/24 21:38:31 UTC

[sis] 01/04: Rename a method for consistency with other `delete` methods. Add a comment about why we do not define a `getTileSize()` method.

This is an automated email from the ASF dual-hosted git repository.

desruisseaux pushed a commit to branch geoapi-4.0
in repository https://gitbox.apache.org/repos/asf/sis.git

commit fdbec98a15fa6677afe673f84c1c189e9f748ea2
Author: Martin Desruisseaux <ma...@geomatys.com>
AuthorDate: Thu Mar 24 20:24:25 2022 +0100

    Rename a method for consistency with other `delete` methods.
    Add a comment about why we do not define a `getTileSize()` method.
---
 .../src/main/java/org/apache/sis/storage/tiling/TileMatrix.java      | 5 +++++
 .../java/org/apache/sis/storage/tiling/WritableTiledResource.java    | 2 +-
 2 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/storage/sis-storage/src/main/java/org/apache/sis/storage/tiling/TileMatrix.java b/storage/sis-storage/src/main/java/org/apache/sis/storage/tiling/TileMatrix.java
index 6598b5f..91cfadd 100644
--- a/storage/sis-storage/src/main/java/org/apache/sis/storage/tiling/TileMatrix.java
+++ b/storage/sis-storage/src/main/java/org/apache/sis/storage/tiling/TileMatrix.java
@@ -50,6 +50,11 @@ public interface TileMatrix {
      */
     GenericName getIdentifier();
 
+    /*
+     * There is no `getTileSize()` method because tiles are not necessarily for grid coverages.
+     * Tile size do not apply to vector tiles, quantized mesh or 3D tiles.
+     */
+
     /**
      * Returns a description about how space is partitioned into individual tiled units.
      * The description contains the extent of valid tile indices, the spatial reference system,
diff --git a/storage/sis-storage/src/main/java/org/apache/sis/storage/tiling/WritableTiledResource.java b/storage/sis-storage/src/main/java/org/apache/sis/storage/tiling/WritableTiledResource.java
index b4d95ab..c9e8027 100644
--- a/storage/sis-storage/src/main/java/org/apache/sis/storage/tiling/WritableTiledResource.java
+++ b/storage/sis-storage/src/main/java/org/apache/sis/storage/tiling/WritableTiledResource.java
@@ -72,5 +72,5 @@ public interface WritableTiledResource extends TiledResource {
      * @throws ReadOnlyStorageException if this resource is not writable. It may be caused by insufficient credentials.
      * @throws DataStoreException if deleting the tile matrix set failed for another reason.
      */
-    void removeTileMatrixSet(String identifier) throws DataStoreException;
+    void deleteTileMatrixSet(String identifier) throws DataStoreException;
 }