You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "davsclaus (via GitHub)" <gi...@apache.org> on 2026/06/23 07:16:03 UTC

[PR] camel-kafka: Add topicHeaderName option to TimestampRouter [camel]

davsclaus opened a new pull request, #24191:
URL: https://github.com/apache/camel/pull/24191

   ## Summary
   
   - Add optional `topicHeaderName` parameter to `TimestampRouter` bean, allowing callers to specify which header contains the topic name instead of always using `KafkaConstants.TOPIC` (`CamelKafkaTopic`)
   - Add `TimestampRouterTest` with 6 unit tests covering default, custom, empty, null, missing topic, and missing timestamp scenarios
   
   ## Context
   
   CAMEL-23584 renamed Kafka header constants from `kafka.*` to `CamelKafka*` (e.g. `kafka.TOPIC` → `CamelKafkaTopic`). This broke the `timestamp-router-action` kamelet when used behind a webhook source, because Camel's HTTP components filter `Camel*`-prefixed headers from incoming requests. The `topicHeaderName` option lets the kamelet specify `kafka.TOPIC` as the header to read from, working around the filter.
   
   ## Test plan
   
   - [x] `TimestampRouterTest` — 6 unit tests all passing
   - [x] `KafkaIT.kafka()[3]` integration test in `camel-kamelets` passes with the corresponding kamelet change
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] camel-kafka: Add topicHeaderName option to TimestampRouter [camel]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #24191:
URL: https://github.com/apache/camel/pull/24191#issuecomment-4777018257

   <!-- ci-tested-modules -->
   :test_tube: **CI tested the following changed modules:**
   
   - `components/camel-kafka`
   
   :warning: **Some tests are disabled on GitHub Actions** (`@DisabledIfSystemProperty(named = "ci.env.name")`) and require manual verification:
   
   - `components/camel-kafka`: 2 test(s) disabled on GitHub Actions
   
   <details><summary>All tested modules (8 modules)</summary>
   
   - Camel :: JBang :: MCP
   - Camel :: JBang :: Plugin :: Route Parser
   - Camel :: JBang :: Plugin :: TUI
   - Camel :: JBang :: Plugin :: Validate
   - Camel :: Kafka
   - Camel :: Launcher :: Container
   - Camel :: YAML DSL :: Validator
   - Camel :: YAML DSL :: Validator Maven Plugin
   
   </details>
   
   ---
   :gear: [View full build and test results](https://github.com/apache/camel/actions/runs/28009133462)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] camel-kafka: Add topicHeaderName option to TimestampRouter [camel]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #24191:
URL: https://github.com/apache/camel/pull/24191#issuecomment-4776820442

   :star2: Thank you for your contribution to the Apache Camel project! :star2:
     :robot: CI automation will test this PR automatically.
   
     :camel: Apache Camel Committers, please review the following items:
   
     * First-time contributors **require MANUAL approval** for the GitHub Actions to run
     * You can use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot although they are normally detected and executed by CI.
     * You can label PRs using `skip-tests` and `test-dependents` to fine-tune the checks executed by this PR.
     * Build and test logs are available in the summary page. **Only** [Apache Camel committers](https://camel.apache.org/community/team/#committers) have access to the summary.
     
     :warning: Be careful when sharing logs. Review their contents before sharing them publicly.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] camel-kafka: Add topicHeaderName option to TimestampRouter [camel]

Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus merged PR #24191:
URL: https://github.com/apache/camel/pull/24191


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org