You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by shardul-cr7 <gi...@git.apache.org> on 2019/01/11 10:52:37 UTC
[GitHub] carbondata pull request #3070: [CARBONDATA-3246]Fix sdk reader issue if batc...
GitHub user shardul-cr7 opened a pull request:
https://github.com/apache/carbondata/pull/3070
[CARBONDATA-3246]Fix sdk reader issue if batch size is given as zero and vectorRead False.
This PR is to fix sdk reader issue when batch size is given as zero and vectorRead False.
**Problem** SDK reader is failing if vectorRead is false and detail query batch size is given as 0.Compiler is giving stack overflow error after getting stuck in ChunkRowIterator.hasnext recurssion.
**Solution** Since 0 is wrong batch size, we should take DETAIL_QUERY_BATCH_SIZE_DEFAULT as the batch size.
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [x] Any interfaces changed?- No
- [x] Any backward compatibility impacted? - No
- [x] Document update required? - No
- [x] Testing done
added test case
- [x] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shardul-cr7/carbondata batchSize_fix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/3070.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3070
----
commit 4c002f80903076ebd7707fe7cf1384e45f823bbd
Author: shardul-cr7 <sh...@...>
Date: 2019-01-11T10:40:27Z
[CARBONDATA-3246]Fix sdk reader issue if batch size is given as zero
----
---
[GitHub] carbondata issue #3070: [CARBONDATA-3246]Fix sdk reader issue if batch size ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/3070
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2271/
---
[GitHub] carbondata pull request #3070: [CARBONDATA-3246]Fix sdk reader issue if batc...
Posted by qiuchenjian <gi...@git.apache.org>.
Github user qiuchenjian commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3070#discussion_r247292846
--- Diff: core/src/main/java/org/apache/carbondata/core/scan/result/iterator/AbstractDetailQueryResultIterator.java ---
@@ -94,6 +94,9 @@
if (null != batchSizeString) {
try {
batchSize = Integer.parseInt(batchSizeString);
+ if (0 == batchSize) {
--- End diff --
```suggestion
if (0 >= batchSize) {
```
---
[GitHub] carbondata issue #3070: [CARBONDATA-3246]Fix sdk reader issue if batch size ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/3070
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2272/
---
[GitHub] carbondata issue #3070: [CARBONDATA-3246]Fix sdk reader issue if batch size ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/3070
Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10530/
---
[GitHub] carbondata issue #3070: [CARBONDATA-3246]Fix sdk reader issue if batch size ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/3070
Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2491/
---