You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by andytaylor <gi...@git.apache.org> on 2015/03/23 10:14:02 UTC
[GitHub] activemq-6 pull request: added some exclusions to the RAT plugin
GitHub user andytaylor opened a pull request:
https://github.com/apache/activemq-6/pull/193
added some exclusions to the RAT plugin
added some exclusions to the RAT plugin for when users build and redirect the output to log files
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/andytaylor/activemq-6 master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-6/pull/193.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #193
----
commit cd78ce15a904bbea66d063ca30347a7c4b7d8c84
Author: Andy Taylor <an...@apache.org>
Date: 2015-03-23T09:12:55Z
added some exclusions to the RAT plugin for when users build and redirect the output to log files
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-6 pull request: added some exclusions to the RAT plugin
Posted by artnaseef <gi...@git.apache.org>.
Github user artnaseef commented on the pull request:
https://github.com/apache/activemq-6/pull/193#issuecomment-85137830
Thanks Andy.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-6 pull request: added some exclusions to the RAT plugin
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-6/pull/193
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-6 pull request: added some exclusions to the RAT plugin
Posted by andytaylor <gi...@git.apache.org>.
Github user andytaylor commented on the pull request:
https://github.com/apache/activemq-6/pull/193#issuecomment-85427585
improved via https://github.com/apache/activemq-6/pull/194
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-6 pull request: added some exclusions to the RAT plugin
Posted by andytaylor <gi...@git.apache.org>.
Github user andytaylor commented on the pull request:
https://github.com/apache/activemq-6/pull/193#issuecomment-85136802
I actually took tose excludes from the ActiveMQ pom however i thought (wrongly) that it was always run. I will update this pr and add a new profile have a manual step during the release process and ci builds the same as ActiveMQ. please no one merge this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-6 pull request: added some exclusions to the RAT plugin
Posted by artnaseef <gi...@git.apache.org>.
Github user artnaseef commented on the pull request:
https://github.com/apache/activemq-6/pull/193#issuecomment-85133033
I think this helps, but want to see more. The copyright check here is very aggressive and assumes that anyone working with the sources will only ever be working with files that contain a matching license.
We can do better here, I'm sure of it. Here are some ideas:
a. Only run the copyright check on release build, or
b. Only run the copyright check when the build user specifies a maven profile specific to that check, or
c. Limit the copyright check to files that are distributed with the original sources (i.e. only files from git)
It is important to make development for all users easy. Apache projects release source code, not binaries (although binaries are allowed as a convenience). This means we anticipate many users working with the source code. This even raises the question of whether it's valid in the Apache ecosystem to restrict files in the development tree to those with the Apache license; the license itself states "You may add Your own copyright statement to Your modifications". This check appears to conflict with that statement.
Let's find an approach that makes Apache releases meet the required licensing without passing that restriction outside of Apache. For comparison, the existing ActiveMQ release process uses a manual step to execute the copyright check.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---