[patch 06/17] Win32 unicode filesystem

[John Mark Vandenberg <ja...@gmail.com>]

file_io/win32/dir.c: In function `apr_dir_read':
file_io/win32/dir.c:212: structure has no member named `w'

APR_HAS_UNICODE_FS appears to only be used for Windows/Netware
differentiation, and is only used in */win32/* files.

HFS Plus or HFS+ are also unicode filsystems.

Is this the right name for the variable?

Index: configure.in
===================================================================
--- configure.in.orig
+++ configure.in
@@ -1359,6 +1359,15 @@ else
 fi
 AC_MSG_RESULT($off_t_value)
 
+have_unicode_fs="0"
+case "$host" in
+    *mingw* )
+        have_unicode_fs="1"
+        ;;
+esac
+
+AC_SUBST(have_unicode_fs)
+
 APR_CHECK_SIZEOF_EXTENDED([#include <sys/types.h>], pid_t, 8)
 
 if test "$ac_cv_sizeof_pid_t" = "$ac_cv_sizeof_short"; then
Index: include/apr.h.in
===================================================================
--- include/apr.h.in.orig
+++ include/apr.h.in
@@ -231,7 +231,7 @@ extern "C" {
 #define APR_HAS_OTHER_CHILD       @oc@
 #define APR_HAS_DSO               @aprdso@
 #define APR_HAS_SO_ACCEPTFILTER   @acceptfilter@
-#define APR_HAS_UNICODE_FS        0
+#define APR_HAS_UNICODE_FS        @have_unicode_fs@
 #define APR_HAS_PROC_INVOKED      0
 #define APR_HAS_USER              1
 #define APR_HAS_LARGE_FILES       @aprlfs@

--

Re: [patch 06/17] Win32 unicode filesystem

[Justin Erenkrantz <ju...@erenkrantz.com>]

On 4/14/06, John Mark Vandenberg <ja...@gmail.com> wrote:
> file_io/win32/dir.c: In function `apr_dir_read':
> file_io/win32/dir.c:212: structure has no member named `w'
>
> APR_HAS_UNICODE_FS appears to only be used for Windows/Netware
> differentiation, and is only used in */win32/* files.

Committed in r421094.

> HFS Plus or HFS+ are also unicode filsystems.

Indeed.

> Is this the right name for the variable?

No, but it's not going to change now.  =)

Thanks!  -- justin