You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/03/23 21:32:22 UTC
[GitHub] [incubator-superset] rusackas opened a new pull request #9352:
Treemap controls migration
rusackas opened a new pull request #9352: Treemap controls migration
URL: https://github.com/apache/incubator-superset/pull/9352
### CATEGORY
Choose one
- [ ] Bug Fix
- [ ] Enhancement (new features, refinement)
- [x] Refactor
- [ ] Add tests
- [ ] Build / Development Environment
- [ ] Documentation
### SUMMARY
Moving unique control(s) from `controls.jsx` to `/explore/controlPanels/Treemap.js`
<!--- Describe the change below, including rationale and design decisions -->
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [x] Has associated issue: https://github.com/apache/incubator-superset/issues/9187
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
### REVIEWERS
@kristw This is a teeny one... lots more of these coming. I'm assuming these will be easier to review if they come in one at a time, but let me know if you'd prefer I batch them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas commented on a change in pull request
#9352: Treemap controls migration
Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #9352: Treemap controls migration
URL: https://github.com/apache/incubator-superset/pull/9352#discussion_r396794538
##########
File path: CONTRIBUTING.md
##########
@@ -1237,7 +1237,6 @@ Note the `y_axis_format` is defined under various section for some charts.
| `timed_refresh_immune_slices` | _N/A_ | |
| `toggle_polygons` | _N/A_ | |
| `transpose_pivot` | _N/A_ | |
-| `treemap_ratio` | _N/A_ | |
Review comment:
@kristw I'm assuming these should get yanked when things are moved, but correct me if I'm wrong.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on issue #9352: Treemap
controls migration
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #9352: Treemap controls migration
URL: https://github.com/apache/incubator-superset/pull/9352#issuecomment-603025451
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9352?src=pr&el=h1) Report
> Merging [#9352](https://codecov.io/gh/apache/incubator-superset/pull/9352?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/20dd4182cb3ba521b686db98995de37398e2dae8&el=desc) will **not change** coverage by `%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9352?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9352 +/- ##
=======================================
Coverage 59.00% 59.00%
=======================================
Files 374 374
Lines 12133 12133
Branches 2987 2987
=======================================
Hits 7159 7159
Misses 4795 4795
Partials 179 179
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9352?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/explore/controls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9352/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbHMuanN4) | `40.14% <ø> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9352?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9352?src=pr&el=footer). Last update [20dd418...d45b3ff](https://codecov.io/gh/apache/incubator-superset/pull/9352?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas merged pull request #9352: Treemap
controls migration
Posted by GitBox <gi...@apache.org>.
rusackas merged pull request #9352: Treemap controls migration
URL: https://github.com/apache/incubator-superset/pull/9352
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org