[jira] [Commented] (CB-7606) handleOpenURL handler firing more than necessary

["Eddy Verbruggen (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CB-7606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14234770#comment-14234770 ] 

Eddy Verbruggen commented on CB-7606:
-------------------------------------

Hi [~shazron],

Thanks for picking this up, but I'm afraid it breaks a feature upon coldstart on iOS 8: my handleOpenURL function is no longer called. It was first reported here (tl;dr): https://github.com/EddyVerbruggen/Custom-URL-scheme/issues/2

So I was wondering how you tested case nr 2. Did iOS actually invoke your handelOpenURL javascript function? Because on my iPhone 6 it did on 3.6.3, but no longer on 3.7.0.

I've altered the code in CDVViewController.m#processOpenUrl a bit to repair it on 3.7.0, but before submitting a PR I'd like to know if I'm testing this correctly.

Thanks,
Eddy

> handleOpenURL handler firing more than necessary
> ------------------------------------------------
>
>                 Key: CB-7606
>                 URL: https://issues.apache.org/jira/browse/CB-7606
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: iOS
>    Affects Versions: 3.5.0
>            Reporter: Paul Kane
>            Assignee: Shazron Abdullah
>             Fix For: 3.7.0
>
>
> I'm not an Obj-C or Cordova programmer so bear with me.
> Let's say my app is running. Then I hop over to my mail app and click on a link (myapp://blahBlahBlah) that should open up my app. This works fine, the app opens, my own URL handler (in javascript) takes over, etc.
> However in Obj-C the view controller is -- incorrectly, I believe -- storing that scheme data (blahBlahBlah) in self.openURL (so that it can be picked up later in processOpenURL function, called during webView initialization).
> This isn't normally a problem, except when you move to a new page (window.href = "/new_page"), the webView initialization runs again and picks up the old (already-acted-upon) openURL variable. (it's then set to nil, so that it doesn't get acted upon a third time, fourth time, etc...).
> I might have some details wrong, but it should be fairly easy to walk through with a project-wide search for "openurl". Just seems like a slightly wrong logic-flow, which unfortunately is interfering with my app.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org