[GitHub] [calcite] zabetak commented on a change in pull request #2653: [CALCITE-4952] (Re)introduce a simplistic RelMetadataQuery option

[GitBox <gi...@apache.org>]

zabetak commented on a change in pull request #2653:
URL: https://github.com/apache/calcite/pull/2653#discussion_r772263213



##########
File path: core/src/test/java/org/apache/calcite/test/RelMetadataTest.java
##########
@@ -3686,4 +3742,43 @@ Sql assertRowsUnique(boolean[] ignoreNulls, Matcher<Boolean> matcher,
     }
 
   }
+
+  /**
+   * Test class for janino metadata path.
+   */
+  @Nested

Review comment:
       I am not sure if this is an appropriate use of the `@Nested` annotation. Citing the [JUnit5 user guide](https://junit.org/junit5/docs/current/user-guide/#writing-tests-nested):
   `Only non-static nested classes (i.e. inner classes) can serve as @Nested test classes`.
   
   I think the test run in this case cause you are using also inheritance but again I am not sure if those were meant to be combined. Instead of relying on test inheritance or `@Nested`, [parameterized tests](https://junit.org/junit5/docs/current/user-guide/#writing-tests-parameterized-tests) would better fit here I think.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org