[jira] Updated: (HTTPCLIENT-740) AbstractConnPool constructor calls thread.Start()

["Roland Weber (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HTTPCLIENT-740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Roland Weber updated HTTPCLIENT-740:
------------------------------------

      Priority: Trivial  (was: Major)
    Issue Type: Improvement  (was: Bug)

In this case, it is not a bug. The background thread being started does not depend on the completed initialization of the pool instance. That part of the code needs to be changed anyway, so I'll move it to an extra method when the time comes. I hope that will be enough to silence findbugs.

cheers,
  Roland


> AbstractConnPool constructor calls thread.Start()
> -------------------------------------------------
>
>                 Key: HTTPCLIENT-740
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-740
>             Project: HttpComponents HttpClient
>          Issue Type: Improvement
>          Components: HttpClient
>            Reporter: Sebb
>            Priority: Trivial
>
> AbstractConnPool constructor calls thread.Start()
> Findbugs says:
> Constructor invokes Thread.start()
> The constructor starts a thread. This is likely to be wrong if the class is ever extended/subclassed, since the thread will be started before the subclass constructor is started.
> The class is not final (and the constructor is protected) which suggests that the class is intended to be extended...

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org