You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by ahgittin <gi...@git.apache.org> on 2014/09/17 15:25:57 UTC
[GitHub] incubator-brooklyn pull request: accept a broader definition for l...
GitHub user ahgittin opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/174
accept a broader definition for localhost when determining whether a password is needed (e.g. using the public ip is now accepted)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ahgittin/incubator-brooklyn networking-localhost-broader
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/174.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #174
----
commit e213cba80e649d7d1a949d8fd9d6e0ca05bc06c7
Author: Alex Heneveld <al...@cloudsoftcorp.com>
Date: 2014-09-17T13:24:55Z
accept a broader definition for localhost when determining whether a password is needed (e.g. using the public ip is now accepted)
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: accept a broader definition for l...
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/174#discussion_r17779817
--- Diff: docs/_config_local.yml ---
@@ -0,0 +1 @@
+url:
--- End diff --
oops that should not be here! thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: accept a broader definition for l...
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/174#discussion_r17779838
--- Diff: utils/common/src/main/java/brooklyn/util/net/Networking.java ---
@@ -369,21 +370,36 @@ public static boolean isPublicIp(String ipAddress) {
return true;
}
- public static boolean isLocalhost(String remoteIp) {
- if ("127.0.0.1".equals(remoteIp)) return true;
+ /** returns true if the supplied string matches any known IP (v4 or v6) for this machine,
+ * or if it can be resolved to any such address */
+ public static boolean isLocalhost(String remoteAddress) {
--- End diff --
agree ... but the only meaningful tests would be runs on lots of different machines
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: accept a broader definition for l...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/174
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: accept a broader definition for l...
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/174#discussion_r17779573
--- Diff: utils/common/src/main/java/brooklyn/util/net/Networking.java ---
@@ -369,21 +370,36 @@ public static boolean isPublicIp(String ipAddress) {
return true;
}
- public static boolean isLocalhost(String remoteIp) {
- if ("127.0.0.1".equals(remoteIp)) return true;
+ /** returns true if the supplied string matches any known IP (v4 or v6) for this machine,
+ * or if it can be resolved to any such address */
+ public static boolean isLocalhost(String remoteAddress) {
--- End diff --
Would be good to have tests for this. There are no unit tests for `Networking.isLocalhost` currently.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: accept a broader definition for l...
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/174#issuecomment-56165444
Finished reviewing; just a couple of minor comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: accept a broader definition for l...
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/174#discussion_r17779614
--- Diff: docs/_config_local.yml ---
@@ -0,0 +1 @@
+url:
--- End diff --
What is this for? Is `docs/_config_local.yml` used anywhere?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---