You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by haosdent huang <ha...@gmail.com> on 2015/10/04 15:07:20 UTC
Re: Review Request 37024: Exposes mesos version information in
components.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37024/
-----------------------------------------------------------
(Updated Oct. 4, 2015, 1:07 p.m.)
Review request for mesos and Ben Mahler.
Bugs: MESOS-1842
https://issues.apache.org/jira/browse/MESOS-1842
Repository: mesos
Description
-------
Add an endpoint that exposes component version.
Diffs
-----
include/mesos/executor.hpp 72eca97dd84fb1300b37764a3ef3a57fb5e676c2
include/mesos/scheduler.hpp ee198b6955882f4f31466ca05429ca16fbf2f5cd
src/Makefile.am 457ad26ee55bd7a2aedf27f45db58a9a4a6a5dc5
src/exec/exec.cpp 31e0c2f17a9092d18285828111d27628fb07bc02
src/local/local.cpp 4d98bf23705027f3ba0cbb571289f21b288fe7db
src/master/main.cpp bafc605d6c20bd264b932e44ee80373a3f692734
src/sched/sched.cpp 012af0508eeceeccd168b29f36fa258d20b28c21
src/slave/main.cpp 364dc7fc7ab2e3cef01aea7267dafa014b60e2b9
src/version/version_info.hpp PRE-CREATION
src/version/version_info.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/37024/diff/
Testing
-------
Manual test result:
```
$ curl http://localhost:5050/version 2>/dev/null|jq .
{
"version": "0.24.0",
"build_user": "haosdent",
"build_time": 1439702338,
"build_date": "2015-08-16 13:18:58"
}
```
Thanks,
haosdent huang
Re: Review Request 37024: Exposes mesos version information in
components.
Posted by Marco Massenzio <ma...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37024/#review101506
-----------------------------------------------------------
Ship it!
Ship It!
- Marco Massenzio
On Oct. 5, 2015, 8 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37024/
> -----------------------------------------------------------
>
> (Updated Oct. 5, 2015, 8 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-1841
> https://issues.apache.org/jira/browse/MESOS-1841
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add an endpoint that exposes component version.
>
>
> Diffs
> -----
>
> src/Makefile.am e69892736b0edc8c264eaccd52a04d44d01f53ba
> src/exec/exec.cpp 7b51baaa8c08d248918974a3a22b6217e388bcb1
> src/local/main.cpp 18b2f0187637cd425d55c220f73faac5a1218f0f
> src/master/main.cpp bafc605d6c20bd264b932e44ee80373a3f692734
> src/sched/sched.cpp 571e00d303009a940f17c8ed4582749a718e846d
> src/slave/main.cpp 364dc7fc7ab2e3cef01aea7267dafa014b60e2b9
> src/version/version.hpp PRE-CREATION
> src/version/version.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/37024/diff/
>
>
> Testing
> -------
>
> Manual test result:
>
> ```
> $ curl http://localhost:5050/version 2>/dev/null|jq .
>
> {
> "version": "0.24.0",
> "build_user": "haosdent",
> "build_time": 1439702338,
> "build_date": "2015-08-16 13:18:58"
> }
> ```
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 37024: Exposes mesos version information in
components.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37024/#review101617
-----------------------------------------------------------
Patch looks great!
Reviews applied: [37024]
All tests passed.
- Mesos ReviewBot
On Oct. 6, 2015, 2:02 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37024/
> -----------------------------------------------------------
>
> (Updated Oct. 6, 2015, 2:02 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-1841
> https://issues.apache.org/jira/browse/MESOS-1841
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add an endpoint exposes Apache Mesos build informations and version information.
>
>
> Diffs
> -----
>
> src/Makefile.am e69892736b0edc8c264eaccd52a04d44d01f53ba
> src/exec/exec.cpp 7b51baaa8c08d248918974a3a22b6217e388bcb1
> src/local/main.cpp 18b2f0187637cd425d55c220f73faac5a1218f0f
> src/master/main.cpp bafc605d6c20bd264b932e44ee80373a3f692734
> src/sched/sched.cpp 571e00d303009a940f17c8ed4582749a718e846d
> src/slave/main.cpp 364dc7fc7ab2e3cef01aea7267dafa014b60e2b9
> src/version/version.hpp PRE-CREATION
> src/version/version.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/37024/diff/
>
>
> Testing
> -------
>
> Manual test result:
>
> ```
> $ curl http://localhost:5050/version 2>/dev/null|jq .
>
> {
> "version": "0.24.0",
> "build_user": "haosdent",
> "build_time": 1439702338,
> "build_date": "2015-08-16 13:18:58"
> }
> ```
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 37024: Exposes mesos version information in
components.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37024/#review101841
-----------------------------------------------------------
Ship it!
Thanks for your patience! Committing this shortly.
src/version/version.cpp (line 61)
<https://reviews.apache.org/r/37024/#comment159361>
Let's do a s/add_version/branch/ here just to be a bit simpler
- Ben Mahler
On Oct. 8, 2015, 7:01 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37024/
> -----------------------------------------------------------
>
> (Updated Oct. 8, 2015, 7:01 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-1841
> https://issues.apache.org/jira/browse/MESOS-1841
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add an endpoint exposes Apache Mesos build informations and version information.
>
>
> Diffs
> -----
>
> src/Makefile.am e69892736b0edc8c264eaccd52a04d44d01f53ba
> src/exec/exec.cpp 7b51baaa8c08d248918974a3a22b6217e388bcb1
> src/local/main.cpp 18b2f0187637cd425d55c220f73faac5a1218f0f
> src/master/main.cpp bafc605d6c20bd264b932e44ee80373a3f692734
> src/sched/sched.cpp 571e00d303009a940f17c8ed4582749a718e846d
> src/slave/main.cpp 854ade491c2bad0bb041cd94968215f9fd8fa4ae
> src/version/version.hpp PRE-CREATION
> src/version/version.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/37024/diff/
>
>
> Testing
> -------
>
> Manual test result:
>
> ```
> $ curl http://localhost:5050/version 2>/dev/null|jq .
> {
> "version": "0.26.0",
> "git_sha": "4566f05e1c4c82d4d5e1c6ac563ea0fb362324e3",
> "git_branch": "refs/heads/MESOS-1841",
> "build_user": "haosdent",
> "build_time": 1444185166,
> "build_date": "2015-10-07 10:32:46"
> }
> ```
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 37024: Exposes mesos version information in
components.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37024/#review101881
-----------------------------------------------------------
Patch looks great!
Reviews applied: [37024]
All tests passed.
- Mesos ReviewBot
On Oct. 8, 2015, 7:01 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37024/
> -----------------------------------------------------------
>
> (Updated Oct. 8, 2015, 7:01 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-1841
> https://issues.apache.org/jira/browse/MESOS-1841
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add an endpoint exposes Apache Mesos build informations and version information.
>
>
> Diffs
> -----
>
> src/Makefile.am e69892736b0edc8c264eaccd52a04d44d01f53ba
> src/exec/exec.cpp 7b51baaa8c08d248918974a3a22b6217e388bcb1
> src/local/main.cpp 18b2f0187637cd425d55c220f73faac5a1218f0f
> src/master/main.cpp bafc605d6c20bd264b932e44ee80373a3f692734
> src/sched/sched.cpp 571e00d303009a940f17c8ed4582749a718e846d
> src/slave/main.cpp 854ade491c2bad0bb041cd94968215f9fd8fa4ae
> src/version/version.hpp PRE-CREATION
> src/version/version.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/37024/diff/
>
>
> Testing
> -------
>
> Manual test result:
>
> ```
> $ curl http://localhost:5050/version 2>/dev/null|jq .
> {
> "version": "0.26.0",
> "git_sha": "4566f05e1c4c82d4d5e1c6ac563ea0fb362324e3",
> "git_branch": "refs/heads/MESOS-1841",
> "build_user": "haosdent",
> "build_time": 1444185166,
> "build_date": "2015-10-07 10:32:46"
> }
> ```
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 37024: Exposes mesos version information in components.
Posted by Alex Clemmer <cl...@gmail.com>.
Oh man, me too. :)
On Mon, Oct 12, 2015 at 11:50 AM, Benjamin Mahler <benjamin.mahler@gmail.com
> wrote:
> Apologies, I've committed the fix for cmake. Looking forward to getting it
> set up in jenkins to catch these!
>
> On Sun, Oct 11, 2015 at 9:53 AM, haosdent huang <ha...@gmail.com>
> wrote:
>
>> This is an automatically generated e-mail. To reply, visit:
>> https://reviews.apache.org/r/37024/
>>
>> On October 10th, 2015, 10:17 a.m. UTC, *Alex Clemmer* wrote:
>>
>> src/Makefile.am
>> <https://reviews.apache.org/r/37024/diff/11/?file=1092775#file1092775line554> (Diff
>> revision 11)
>>
>> 554
>>
>> version/version.cpp \
>>
>> Hmm, I know this is submitted, but can we go back and add this also to the CMakeLists.txt in src/?
>>
>> Sorry, my fault to forgot update CMake. I open https://reviews.apache.org/r/39212/, could you help review it?
>>
>>
>> - haosdent
>>
>> On October 8th, 2015, 7:01 a.m. UTC, haosdent huang wrote:
>> Review request for mesos and Ben Mahler.
>> By haosdent huang.
>>
>> *Updated Oct. 8, 2015, 7:01 a.m.*
>> *Bugs: * MESOS-1841 <https://issues.apache.org/jira/browse/MESOS-1841>
>> *Repository: * mesos
>> Description
>>
>> Add an endpoint exposes Apache Mesos build informations and version information.
>>
>> Testing
>>
>> Manual test result:
>>
>> $ curl http://localhost:5050/version 2>/dev/null|jq .
>> {
>> "version": "0.26.0",
>> "git_sha": "4566f05e1c4c82d4d5e1c6ac563ea0fb362324e3",
>> "git_branch": "refs/heads/MESOS-1841",
>> "build_user": "haosdent",
>> "build_time": 1444185166,
>> "build_date": "2015-10-07 10:32:46"
>> }
>>
>> Diffs
>>
>> - src/Makefile.am (e69892736b0edc8c264eaccd52a04d44d01f53ba)
>> - src/exec/exec.cpp (7b51baaa8c08d248918974a3a22b6217e388bcb1)
>> - src/local/main.cpp (18b2f0187637cd425d55c220f73faac5a1218f0f)
>> - src/master/main.cpp (bafc605d6c20bd264b932e44ee80373a3f692734)
>> - src/sched/sched.cpp (571e00d303009a940f17c8ed4582749a718e846d)
>> - src/slave/main.cpp (854ade491c2bad0bb041cd94968215f9fd8fa4ae)
>> - src/version/version.hpp (PRE-CREATION)
>> - src/version/version.cpp (PRE-CREATION)
>>
>> View Diff <https://reviews.apache.org/r/37024/diff/>
>>
>
>
--
Alex
Theory is the first term in the Taylor series of practice. -- Thomas M
Cover (1992)
Re: Review Request 37024: Exposes mesos version information in components.
Posted by Benjamin Mahler <be...@gmail.com>.
Apologies, I've committed the fix for cmake. Looking forward to getting it
set up in jenkins to catch these!
On Sun, Oct 11, 2015 at 9:53 AM, haosdent huang <ha...@gmail.com> wrote:
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37024/
>
> On October 10th, 2015, 10:17 a.m. UTC, *Alex Clemmer* wrote:
>
> src/Makefile.am
> <https://reviews.apache.org/r/37024/diff/11/?file=1092775#file1092775line554> (Diff
> revision 11)
>
> 554
>
> version/version.cpp \
>
> Hmm, I know this is submitted, but can we go back and add this also to the CMakeLists.txt in src/?
>
> Sorry, my fault to forgot update CMake. I open https://reviews.apache.org/r/39212/, could you help review it?
>
>
> - haosdent
>
> On October 8th, 2015, 7:01 a.m. UTC, haosdent huang wrote:
> Review request for mesos and Ben Mahler.
> By haosdent huang.
>
> *Updated Oct. 8, 2015, 7:01 a.m.*
> *Bugs: * MESOS-1841 <https://issues.apache.org/jira/browse/MESOS-1841>
> *Repository: * mesos
> Description
>
> Add an endpoint exposes Apache Mesos build informations and version information.
>
> Testing
>
> Manual test result:
>
> $ curl http://localhost:5050/version 2>/dev/null|jq .
> {
> "version": "0.26.0",
> "git_sha": "4566f05e1c4c82d4d5e1c6ac563ea0fb362324e3",
> "git_branch": "refs/heads/MESOS-1841",
> "build_user": "haosdent",
> "build_time": 1444185166,
> "build_date": "2015-10-07 10:32:46"
> }
>
> Diffs
>
> - src/Makefile.am (e69892736b0edc8c264eaccd52a04d44d01f53ba)
> - src/exec/exec.cpp (7b51baaa8c08d248918974a3a22b6217e388bcb1)
> - src/local/main.cpp (18b2f0187637cd425d55c220f73faac5a1218f0f)
> - src/master/main.cpp (bafc605d6c20bd264b932e44ee80373a3f692734)
> - src/sched/sched.cpp (571e00d303009a940f17c8ed4582749a718e846d)
> - src/slave/main.cpp (854ade491c2bad0bb041cd94968215f9fd8fa4ae)
> - src/version/version.hpp (PRE-CREATION)
> - src/version/version.cpp (PRE-CREATION)
>
> View Diff <https://reviews.apache.org/r/37024/diff/>
>
Re: Review Request 37024: Exposes mesos version information in
components.
Posted by haosdent huang <ha...@gmail.com>.
> On Oct. 10, 2015, 10:17 a.m., Alex Clemmer wrote:
> > src/Makefile.am, line 554
> > <https://reviews.apache.org/r/37024/diff/11/?file=1092775#file1092775line554>
> >
> > Hmm, I know this is submitted, but can we go back and add this also to the CMakeLists.txt in src/?
Sorry, my fault to forgot update CMake. I open https://reviews.apache.org/r/39212/, could you help review it?
- haosdent
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37024/#review102162
-----------------------------------------------------------
On Oct. 8, 2015, 7:01 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37024/
> -----------------------------------------------------------
>
> (Updated Oct. 8, 2015, 7:01 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-1841
> https://issues.apache.org/jira/browse/MESOS-1841
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add an endpoint exposes Apache Mesos build informations and version information.
>
>
> Diffs
> -----
>
> src/Makefile.am e69892736b0edc8c264eaccd52a04d44d01f53ba
> src/exec/exec.cpp 7b51baaa8c08d248918974a3a22b6217e388bcb1
> src/local/main.cpp 18b2f0187637cd425d55c220f73faac5a1218f0f
> src/master/main.cpp bafc605d6c20bd264b932e44ee80373a3f692734
> src/sched/sched.cpp 571e00d303009a940f17c8ed4582749a718e846d
> src/slave/main.cpp 854ade491c2bad0bb041cd94968215f9fd8fa4ae
> src/version/version.hpp PRE-CREATION
> src/version/version.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/37024/diff/
>
>
> Testing
> -------
>
> Manual test result:
>
> ```
> $ curl http://localhost:5050/version 2>/dev/null|jq .
> {
> "version": "0.26.0",
> "git_sha": "4566f05e1c4c82d4d5e1c6ac563ea0fb362324e3",
> "git_branch": "refs/heads/MESOS-1841",
> "build_user": "haosdent",
> "build_time": 1444185166,
> "build_date": "2015-10-07 10:32:46"
> }
> ```
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 37024: Exposes mesos version information in
components.
Posted by Alex Clemmer <cl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37024/#review102162
-----------------------------------------------------------
src/Makefile.am (line 554)
<https://reviews.apache.org/r/37024/#comment159722>
Hmm, I know this is submitted, but can we go back and add this also to the CMakeLists.txt in src/?
- Alex Clemmer
On Oct. 8, 2015, 7:01 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37024/
> -----------------------------------------------------------
>
> (Updated Oct. 8, 2015, 7:01 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-1841
> https://issues.apache.org/jira/browse/MESOS-1841
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add an endpoint exposes Apache Mesos build informations and version information.
>
>
> Diffs
> -----
>
> src/Makefile.am e69892736b0edc8c264eaccd52a04d44d01f53ba
> src/exec/exec.cpp 7b51baaa8c08d248918974a3a22b6217e388bcb1
> src/local/main.cpp 18b2f0187637cd425d55c220f73faac5a1218f0f
> src/master/main.cpp bafc605d6c20bd264b932e44ee80373a3f692734
> src/sched/sched.cpp 571e00d303009a940f17c8ed4582749a718e846d
> src/slave/main.cpp 854ade491c2bad0bb041cd94968215f9fd8fa4ae
> src/version/version.hpp PRE-CREATION
> src/version/version.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/37024/diff/
>
>
> Testing
> -------
>
> Manual test result:
>
> ```
> $ curl http://localhost:5050/version 2>/dev/null|jq .
> {
> "version": "0.26.0",
> "git_sha": "4566f05e1c4c82d4d5e1c6ac563ea0fb362324e3",
> "git_branch": "refs/heads/MESOS-1841",
> "build_user": "haosdent",
> "build_time": 1444185166,
> "build_date": "2015-10-07 10:32:46"
> }
> ```
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 37024: Exposes mesos version information in
components.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37024/
-----------------------------------------------------------
(Updated Oct. 8, 2015, 7:01 a.m.)
Review request for mesos and Ben Mahler.
Changes
-------
rebase
Bugs: MESOS-1841
https://issues.apache.org/jira/browse/MESOS-1841
Repository: mesos
Description
-------
Add an endpoint exposes Apache Mesos build informations and version information.
Diffs (updated)
-----
src/Makefile.am e69892736b0edc8c264eaccd52a04d44d01f53ba
src/exec/exec.cpp 7b51baaa8c08d248918974a3a22b6217e388bcb1
src/local/main.cpp 18b2f0187637cd425d55c220f73faac5a1218f0f
src/master/main.cpp bafc605d6c20bd264b932e44ee80373a3f692734
src/sched/sched.cpp 571e00d303009a940f17c8ed4582749a718e846d
src/slave/main.cpp 854ade491c2bad0bb041cd94968215f9fd8fa4ae
src/version/version.hpp PRE-CREATION
src/version/version.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/37024/diff/
Testing
-------
Manual test result:
```
$ curl http://localhost:5050/version 2>/dev/null|jq .
{
"version": "0.26.0",
"git_sha": "4566f05e1c4c82d4d5e1c6ac563ea0fb362324e3",
"git_branch": "refs/heads/MESOS-1841",
"build_user": "haosdent",
"build_time": 1444185166,
"build_date": "2015-10-07 10:32:46"
}
```
Thanks,
haosdent huang
Re: Review Request 37024: Exposes mesos version information in
components.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37024/
-----------------------------------------------------------
(Updated Oct. 7, 2015, 2:56 a.m.)
Review request for mesos and Ben Mahler.
Changes
-------
Update test description
Bugs: MESOS-1841
https://issues.apache.org/jira/browse/MESOS-1841
Repository: mesos
Description
-------
Add an endpoint exposes Apache Mesos build informations and version information.
Diffs
-----
src/Makefile.am e69892736b0edc8c264eaccd52a04d44d01f53ba
src/exec/exec.cpp 7b51baaa8c08d248918974a3a22b6217e388bcb1
src/local/main.cpp 18b2f0187637cd425d55c220f73faac5a1218f0f
src/master/main.cpp bafc605d6c20bd264b932e44ee80373a3f692734
src/sched/sched.cpp 571e00d303009a940f17c8ed4582749a718e846d
src/slave/main.cpp 854ade491c2bad0bb041cd94968215f9fd8fa4ae
src/version/version.hpp PRE-CREATION
src/version/version.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/37024/diff/
Testing (updated)
-------
Manual test result:
```
$ curl http://localhost:5050/version 2>/dev/null|jq .
{
"version": "0.26.0",
"git_sha": "4566f05e1c4c82d4d5e1c6ac563ea0fb362324e3",
"git_branch": "refs/heads/MESOS-1841",
"build_user": "haosdent",
"build_time": 1444185166,
"build_date": "2015-10-07 10:32:46"
}
```
Thanks,
haosdent huang
Re: Review Request 37024: Exposes mesos version information in
components.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37024/
-----------------------------------------------------------
(Updated Oct. 7, 2015, 2:47 a.m.)
Review request for mesos and Ben Mahler.
Changes
-------
rebase
Bugs: MESOS-1841
https://issues.apache.org/jira/browse/MESOS-1841
Repository: mesos
Description
-------
Add an endpoint exposes Apache Mesos build informations and version information.
Diffs (updated)
-----
src/Makefile.am e69892736b0edc8c264eaccd52a04d44d01f53ba
src/exec/exec.cpp 7b51baaa8c08d248918974a3a22b6217e388bcb1
src/local/main.cpp 18b2f0187637cd425d55c220f73faac5a1218f0f
src/master/main.cpp bafc605d6c20bd264b932e44ee80373a3f692734
src/sched/sched.cpp 571e00d303009a940f17c8ed4582749a718e846d
src/slave/main.cpp 854ade491c2bad0bb041cd94968215f9fd8fa4ae
src/version/version.hpp PRE-CREATION
src/version/version.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/37024/diff/
Testing
-------
Manual test result:
```
$ curl http://localhost:5050/version 2>/dev/null|jq .
{
"version": "0.24.0",
"build_user": "haosdent",
"build_time": 1439702338,
"build_date": "2015-08-16 13:18:58"
}
```
Thanks,
haosdent huang
Re: Review Request 37024: Exposes mesos version information in
components.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37024/
-----------------------------------------------------------
(Updated Oct. 7, 2015, 2:30 a.m.)
Review request for mesos and Ben Mahler.
Changes
-------
Update according @bmahler's review
Bugs: MESOS-1841
https://issues.apache.org/jira/browse/MESOS-1841
Repository: mesos
Description
-------
Add an endpoint exposes Apache Mesos build informations and version information.
Diffs (updated)
-----
src/Makefile.am e69892736b0edc8c264eaccd52a04d44d01f53ba
src/exec/exec.cpp 7b51baaa8c08d248918974a3a22b6217e388bcb1
src/local/main.cpp 18b2f0187637cd425d55c220f73faac5a1218f0f
src/master/main.cpp bafc605d6c20bd264b932e44ee80373a3f692734
src/sched/sched.cpp 571e00d303009a940f17c8ed4582749a718e846d
src/slave/main.cpp 854ade491c2bad0bb041cd94968215f9fd8fa4ae
src/version/version.hpp PRE-CREATION
src/version/version.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/37024/diff/
Testing
-------
Manual test result:
```
$ curl http://localhost:5050/version 2>/dev/null|jq .
{
"version": "0.24.0",
"build_user": "haosdent",
"build_time": 1439702338,
"build_date": "2015-08-16 13:18:58"
}
```
Thanks,
haosdent huang
Re: Review Request 37024: Exposes mesos version information in
components.
Posted by haosdent huang <ha...@gmail.com>.
> On Oct. 6, 2015, 7:23 p.m., Ben Mahler wrote:
> > Would be great to add a unit test for VersionProcess as a follow up, not in this patch.
Thank you very much, let me add it later.
- haosdent
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37024/#review101679
-----------------------------------------------------------
On Oct. 7, 2015, 2:30 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37024/
> -----------------------------------------------------------
>
> (Updated Oct. 7, 2015, 2:30 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-1841
> https://issues.apache.org/jira/browse/MESOS-1841
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add an endpoint exposes Apache Mesos build informations and version information.
>
>
> Diffs
> -----
>
> src/Makefile.am e69892736b0edc8c264eaccd52a04d44d01f53ba
> src/exec/exec.cpp 7b51baaa8c08d248918974a3a22b6217e388bcb1
> src/local/main.cpp 18b2f0187637cd425d55c220f73faac5a1218f0f
> src/master/main.cpp bafc605d6c20bd264b932e44ee80373a3f692734
> src/sched/sched.cpp 571e00d303009a940f17c8ed4582749a718e846d
> src/slave/main.cpp 854ade491c2bad0bb041cd94968215f9fd8fa4ae
> src/version/version.hpp PRE-CREATION
> src/version/version.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/37024/diff/
>
>
> Testing
> -------
>
> Manual test result:
>
> ```
> $ curl http://localhost:5050/version 2>/dev/null|jq .
>
> {
> "version": "0.24.0",
> "build_user": "haosdent",
> "build_time": 1439702338,
> "build_date": "2015-08-16 13:18:58"
> }
> ```
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 37024: Exposes mesos version information in
components.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37024/#review101679
-----------------------------------------------------------
Would be great to add a unit test for VersionProcess as a follow up, not in this patch.
src/version/version.hpp (lines 40 - 41)
<https://reviews.apache.org/r/37024/#comment159135>
Looks like this should be static?
src/version/version.cpp (lines 56 - 58)
<https://reviews.apache.org/r/37024/#comment159134>
Couple of things:
(1) Can you use a 2 space indent instead of 4?
(2) Can you add the git fields here as well?
```
"{",
" \"build_user\":\"username\",",
" \"build_time\":1443894750,",
" \"build_date\":\"2015-10-04 01:52:30\",",
" \"git_branch\":\"branch\", // Optional",
" \"git_sha\":\"2199a599d4e57cce0c9209660e488f530156e07b\", // Optional",
" \"git_tag\":\"0.26.0-rc1\", // Optional",
" \"version\":\"0.26.0\"",
"}",
```
(3) Ideally we could just make VersionProcess::version static and then just pretty print the json object directly here instead of hard coding an example. However, we don't currently have pretty printing, so feel free to just leave this example here and have a TODO for generating the example automatically.
- Ben Mahler
On Oct. 6, 2015, 2:02 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37024/
> -----------------------------------------------------------
>
> (Updated Oct. 6, 2015, 2:02 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-1841
> https://issues.apache.org/jira/browse/MESOS-1841
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add an endpoint exposes Apache Mesos build informations and version information.
>
>
> Diffs
> -----
>
> src/Makefile.am e69892736b0edc8c264eaccd52a04d44d01f53ba
> src/exec/exec.cpp 7b51baaa8c08d248918974a3a22b6217e388bcb1
> src/local/main.cpp 18b2f0187637cd425d55c220f73faac5a1218f0f
> src/master/main.cpp bafc605d6c20bd264b932e44ee80373a3f692734
> src/sched/sched.cpp 571e00d303009a940f17c8ed4582749a718e846d
> src/slave/main.cpp 364dc7fc7ab2e3cef01aea7267dafa014b60e2b9
> src/version/version.hpp PRE-CREATION
> src/version/version.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/37024/diff/
>
>
> Testing
> -------
>
> Manual test result:
>
> ```
> $ curl http://localhost:5050/version 2>/dev/null|jq .
>
> {
> "version": "0.24.0",
> "build_user": "haosdent",
> "build_time": 1439702338,
> "build_date": "2015-08-16 13:18:58"
> }
> ```
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 37024: Exposes mesos version information in
components.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37024/
-----------------------------------------------------------
(Updated Oct. 6, 2015, 2:02 a.m.)
Review request for mesos and Ben Mahler.
Changes
-------
Update according @bmahler's review
Bugs: MESOS-1841
https://issues.apache.org/jira/browse/MESOS-1841
Repository: mesos
Description
-------
Add an endpoint exposes Apache Mesos build informations and version information.
Diffs (updated)
-----
src/Makefile.am e69892736b0edc8c264eaccd52a04d44d01f53ba
src/exec/exec.cpp 7b51baaa8c08d248918974a3a22b6217e388bcb1
src/local/main.cpp 18b2f0187637cd425d55c220f73faac5a1218f0f
src/master/main.cpp bafc605d6c20bd264b932e44ee80373a3f692734
src/sched/sched.cpp 571e00d303009a940f17c8ed4582749a718e846d
src/slave/main.cpp 364dc7fc7ab2e3cef01aea7267dafa014b60e2b9
src/version/version.hpp PRE-CREATION
src/version/version.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/37024/diff/
Testing
-------
Manual test result:
```
$ curl http://localhost:5050/version 2>/dev/null|jq .
{
"version": "0.24.0",
"build_user": "haosdent",
"build_time": 1439702338,
"build_date": "2015-08-16 13:18:58"
}
```
Thanks,
haosdent huang
Re: Review Request 37024: Exposes mesos version information in
components.
Posted by Ben Mahler <be...@gmail.com>.
> On Oct. 6, 2015, 1:16 a.m., Ben Mahler wrote:
> > src/version/version.hpp, line 43
> > <https://reviews.apache.org/r/37024/diff/7/?file=1091482#file1091482line43>
> >
> > Hm.. I'm confused as to how you can initialize this non-static member in the .cpp file as you're doing now. Can you please follow the approach in metrics.cpp?
> >
> > https://github.com/apache/mesos/blob/master/3rdparty/libprocess/src/metrics/metrics.cpp#L67
Alternatively, feel free to follow the approach from monitor.cpp:
https://github.com/apache/mesos/blob/master/src/slave/monitor.cpp#L45
- Ben
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37024/#review101571
-----------------------------------------------------------
On Oct. 6, 2015, 1:14 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37024/
> -----------------------------------------------------------
>
> (Updated Oct. 6, 2015, 1:14 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-1841
> https://issues.apache.org/jira/browse/MESOS-1841
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add an endpoint exposes Apache Mesos build informations and version information.
>
>
> Diffs
> -----
>
> src/Makefile.am e69892736b0edc8c264eaccd52a04d44d01f53ba
> src/exec/exec.cpp 7b51baaa8c08d248918974a3a22b6217e388bcb1
> src/local/main.cpp 18b2f0187637cd425d55c220f73faac5a1218f0f
> src/master/main.cpp bafc605d6c20bd264b932e44ee80373a3f692734
> src/sched/sched.cpp 571e00d303009a940f17c8ed4582749a718e846d
> src/slave/main.cpp 364dc7fc7ab2e3cef01aea7267dafa014b60e2b9
> src/version/version.hpp PRE-CREATION
> src/version/version.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/37024/diff/
>
>
> Testing
> -------
>
> Manual test result:
>
> ```
> $ curl http://localhost:5050/version 2>/dev/null|jq .
>
> {
> "version": "0.24.0",
> "build_user": "haosdent",
> "build_time": 1439702338,
> "build_date": "2015-08-16 13:18:58"
> }
> ```
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 37024: Exposes mesos version information in
components.
Posted by haosdent huang <ha...@gmail.com>.
> On Oct. 6, 2015, 1:16 a.m., Ben Mahler wrote:
> > Sorry, this should be the last iteration. :)
Never mind, it is my fault not to recompile it again before update. Thank you very much.
- haosdent
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37024/#review101571
-----------------------------------------------------------
On Oct. 6, 2015, 1:14 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37024/
> -----------------------------------------------------------
>
> (Updated Oct. 6, 2015, 1:14 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-1841
> https://issues.apache.org/jira/browse/MESOS-1841
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add an endpoint exposes Apache Mesos build informations and version information.
>
>
> Diffs
> -----
>
> src/Makefile.am e69892736b0edc8c264eaccd52a04d44d01f53ba
> src/exec/exec.cpp 7b51baaa8c08d248918974a3a22b6217e388bcb1
> src/local/main.cpp 18b2f0187637cd425d55c220f73faac5a1218f0f
> src/master/main.cpp bafc605d6c20bd264b932e44ee80373a3f692734
> src/sched/sched.cpp 571e00d303009a940f17c8ed4582749a718e846d
> src/slave/main.cpp 364dc7fc7ab2e3cef01aea7267dafa014b60e2b9
> src/version/version.hpp PRE-CREATION
> src/version/version.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/37024/diff/
>
>
> Testing
> -------
>
> Manual test result:
>
> ```
> $ curl http://localhost:5050/version 2>/dev/null|jq .
>
> {
> "version": "0.24.0",
> "build_user": "haosdent",
> "build_time": 1439702338,
> "build_date": "2015-08-16 13:18:58"
> }
> ```
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 37024: Exposes mesos version information in
components.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37024/#review101571
-----------------------------------------------------------
Ship it!
Sorry, this should be the last iteration. :)
src/version/version.hpp (line 43)
<https://reviews.apache.org/r/37024/#comment159008>
Hm.. I'm confused as to how you can initialize this non-static member in the .cpp file as you're doing now. Can you please follow the approach in metrics.cpp?
https://github.com/apache/mesos/blob/master/3rdparty/libprocess/src/metrics/metrics.cpp#L67
src/version/version.cpp (lines 78 - 82)
<https://reviews.apache.org/r/37024/#comment159006>
How about just a TLDR since the DESCRIPTION here seems redundant?
```
TLDR("Provides version information.")
```
- Ben Mahler
On Oct. 6, 2015, 1:14 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37024/
> -----------------------------------------------------------
>
> (Updated Oct. 6, 2015, 1:14 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-1841
> https://issues.apache.org/jira/browse/MESOS-1841
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add an endpoint exposes Apache Mesos build informations and version information.
>
>
> Diffs
> -----
>
> src/Makefile.am e69892736b0edc8c264eaccd52a04d44d01f53ba
> src/exec/exec.cpp 7b51baaa8c08d248918974a3a22b6217e388bcb1
> src/local/main.cpp 18b2f0187637cd425d55c220f73faac5a1218f0f
> src/master/main.cpp bafc605d6c20bd264b932e44ee80373a3f692734
> src/sched/sched.cpp 571e00d303009a940f17c8ed4582749a718e846d
> src/slave/main.cpp 364dc7fc7ab2e3cef01aea7267dafa014b60e2b9
> src/version/version.hpp PRE-CREATION
> src/version/version.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/37024/diff/
>
>
> Testing
> -------
>
> Manual test result:
>
> ```
> $ curl http://localhost:5050/version 2>/dev/null|jq .
>
> {
> "version": "0.24.0",
> "build_user": "haosdent",
> "build_time": 1439702338,
> "build_date": "2015-08-16 13:18:58"
> }
> ```
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 37024: Exposes mesos version information in
components.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37024/
-----------------------------------------------------------
(Updated Oct. 6, 2015, 1:14 a.m.)
Review request for mesos and Ben Mahler.
Changes
-------
Update description
Bugs: MESOS-1841
https://issues.apache.org/jira/browse/MESOS-1841
Repository: mesos
Description (updated)
-------
Add an endpoint exposes Apache Mesos build informations and version information.
Diffs
-----
src/Makefile.am e69892736b0edc8c264eaccd52a04d44d01f53ba
src/exec/exec.cpp 7b51baaa8c08d248918974a3a22b6217e388bcb1
src/local/main.cpp 18b2f0187637cd425d55c220f73faac5a1218f0f
src/master/main.cpp bafc605d6c20bd264b932e44ee80373a3f692734
src/sched/sched.cpp 571e00d303009a940f17c8ed4582749a718e846d
src/slave/main.cpp 364dc7fc7ab2e3cef01aea7267dafa014b60e2b9
src/version/version.hpp PRE-CREATION
src/version/version.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/37024/diff/
Testing
-------
Manual test result:
```
$ curl http://localhost:5050/version 2>/dev/null|jq .
{
"version": "0.24.0",
"build_user": "haosdent",
"build_time": 1439702338,
"build_date": "2015-08-16 13:18:58"
}
```
Thanks,
haosdent huang
Re: Review Request 37024: Exposes mesos version information in
components.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37024/
-----------------------------------------------------------
(Updated Oct. 6, 2015, 1:11 a.m.)
Review request for mesos and Ben Mahler.
Changes
-------
Update according to @marco and @bmahler reviews
Bugs: MESOS-1841
https://issues.apache.org/jira/browse/MESOS-1841
Repository: mesos
Description
-------
Add an endpoint that exposes component version.
Diffs (updated)
-----
src/Makefile.am e69892736b0edc8c264eaccd52a04d44d01f53ba
src/exec/exec.cpp 7b51baaa8c08d248918974a3a22b6217e388bcb1
src/local/main.cpp 18b2f0187637cd425d55c220f73faac5a1218f0f
src/master/main.cpp bafc605d6c20bd264b932e44ee80373a3f692734
src/sched/sched.cpp 571e00d303009a940f17c8ed4582749a718e846d
src/slave/main.cpp 364dc7fc7ab2e3cef01aea7267dafa014b60e2b9
src/version/version.hpp PRE-CREATION
src/version/version.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/37024/diff/
Testing
-------
Manual test result:
```
$ curl http://localhost:5050/version 2>/dev/null|jq .
{
"version": "0.24.0",
"build_user": "haosdent",
"build_time": 1439702338,
"build_date": "2015-08-16 13:18:58"
}
```
Thanks,
haosdent huang
Re: Review Request 37024: Exposes mesos version information in
components.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37024/#review101534
-----------------------------------------------------------
Ship it!
Looks great hsaodent! Thanks for your patience, just a couple of minor things and we can land this :)
src/master/main.cpp (line 325)
<https://reviews.apache.org/r/37024/#comment158951>
Could you do this after logging initialization to keep it consistent with the other mains?
src/slave/main.cpp (line 255)
<https://reviews.apache.org/r/37024/#comment158950>
Could you do this after logging initialization to keep it consistent with the other mains?
src/version/version.hpp (line 43)
<https://reviews.apache.org/r/37024/#comment158952>
Can you avoid the static non-POD here?
src/version/version.cpp (line 58)
<https://reviews.apache.org/r/37024/#comment158953>
newline here? :)
- Ben Mahler
On Oct. 5, 2015, 8 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37024/
> -----------------------------------------------------------
>
> (Updated Oct. 5, 2015, 8 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-1841
> https://issues.apache.org/jira/browse/MESOS-1841
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add an endpoint that exposes component version.
>
>
> Diffs
> -----
>
> src/Makefile.am e69892736b0edc8c264eaccd52a04d44d01f53ba
> src/exec/exec.cpp 7b51baaa8c08d248918974a3a22b6217e388bcb1
> src/local/main.cpp 18b2f0187637cd425d55c220f73faac5a1218f0f
> src/master/main.cpp bafc605d6c20bd264b932e44ee80373a3f692734
> src/sched/sched.cpp 571e00d303009a940f17c8ed4582749a718e846d
> src/slave/main.cpp 364dc7fc7ab2e3cef01aea7267dafa014b60e2b9
> src/version/version.hpp PRE-CREATION
> src/version/version.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/37024/diff/
>
>
> Testing
> -------
>
> Manual test result:
>
> ```
> $ curl http://localhost:5050/version 2>/dev/null|jq .
>
> {
> "version": "0.24.0",
> "build_user": "haosdent",
> "build_time": 1439702338,
> "build_date": "2015-08-16 13:18:58"
> }
> ```
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 37024: Exposes mesos version information in
components.
Posted by Marco Massenzio <ma...@mesosphere.io>.
> On Oct. 5, 2015, 6:48 p.m., Marco Massenzio wrote:
> > src/version/version.cpp, lines 81-82
> > <https://reviews.apache.org/r/37024/diff/6/?file=1090173#file1090173line81>
> >
> > Minor nit: s/mesos/Apache Mesos and I think you can drop the "This endpoint" - "Shows the current version and build information for Apache Mesos"
> >
> > or something like that...
Also, can you please make sure that in the commit comment we have a full description of the endpoint's returned result (I also think that the description above is no longer current?).
- Marco
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37024/#review101508
-----------------------------------------------------------
On Oct. 5, 2015, 8 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37024/
> -----------------------------------------------------------
>
> (Updated Oct. 5, 2015, 8 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-1841
> https://issues.apache.org/jira/browse/MESOS-1841
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add an endpoint that exposes component version.
>
>
> Diffs
> -----
>
> src/Makefile.am e69892736b0edc8c264eaccd52a04d44d01f53ba
> src/exec/exec.cpp 7b51baaa8c08d248918974a3a22b6217e388bcb1
> src/local/main.cpp 18b2f0187637cd425d55c220f73faac5a1218f0f
> src/master/main.cpp bafc605d6c20bd264b932e44ee80373a3f692734
> src/sched/sched.cpp 571e00d303009a940f17c8ed4582749a718e846d
> src/slave/main.cpp 364dc7fc7ab2e3cef01aea7267dafa014b60e2b9
> src/version/version.hpp PRE-CREATION
> src/version/version.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/37024/diff/
>
>
> Testing
> -------
>
> Manual test result:
>
> ```
> $ curl http://localhost:5050/version 2>/dev/null|jq .
>
> {
> "version": "0.24.0",
> "build_user": "haosdent",
> "build_time": 1439702338,
> "build_date": "2015-08-16 13:18:58"
> }
> ```
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 37024: Exposes mesos version information in
components.
Posted by Marco Massenzio <ma...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37024/#review101508
-----------------------------------------------------------
src/version/version.cpp (lines 81 - 82)
<https://reviews.apache.org/r/37024/#comment158928>
Minor nit: s/mesos/Apache Mesos and I think you can drop the "This endpoint" - "Shows the current version and build information for Apache Mesos"
or something like that...
- Marco Massenzio
On Oct. 5, 2015, 8 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37024/
> -----------------------------------------------------------
>
> (Updated Oct. 5, 2015, 8 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-1841
> https://issues.apache.org/jira/browse/MESOS-1841
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add an endpoint that exposes component version.
>
>
> Diffs
> -----
>
> src/Makefile.am e69892736b0edc8c264eaccd52a04d44d01f53ba
> src/exec/exec.cpp 7b51baaa8c08d248918974a3a22b6217e388bcb1
> src/local/main.cpp 18b2f0187637cd425d55c220f73faac5a1218f0f
> src/master/main.cpp bafc605d6c20bd264b932e44ee80373a3f692734
> src/sched/sched.cpp 571e00d303009a940f17c8ed4582749a718e846d
> src/slave/main.cpp 364dc7fc7ab2e3cef01aea7267dafa014b60e2b9
> src/version/version.hpp PRE-CREATION
> src/version/version.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/37024/diff/
>
>
> Testing
> -------
>
> Manual test result:
>
> ```
> $ curl http://localhost:5050/version 2>/dev/null|jq .
>
> {
> "version": "0.24.0",
> "build_user": "haosdent",
> "build_time": 1439702338,
> "build_date": "2015-08-16 13:18:58"
> }
> ```
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 37024: Exposes mesos version information in
components.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37024/
-----------------------------------------------------------
(Updated Oct. 5, 2015, 8 a.m.)
Review request for mesos and Ben Mahler.
Changes
-------
Add src/Makefile.am back because review board recover
Bugs: MESOS-1841
https://issues.apache.org/jira/browse/MESOS-1841
Repository: mesos
Description
-------
Add an endpoint that exposes component version.
Diffs (updated)
-----
src/Makefile.am e69892736b0edc8c264eaccd52a04d44d01f53ba
src/exec/exec.cpp 7b51baaa8c08d248918974a3a22b6217e388bcb1
src/local/main.cpp 18b2f0187637cd425d55c220f73faac5a1218f0f
src/master/main.cpp bafc605d6c20bd264b932e44ee80373a3f692734
src/sched/sched.cpp 571e00d303009a940f17c8ed4582749a718e846d
src/slave/main.cpp 364dc7fc7ab2e3cef01aea7267dafa014b60e2b9
src/version/version.hpp PRE-CREATION
src/version/version.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/37024/diff/
Testing
-------
Manual test result:
```
$ curl http://localhost:5050/version 2>/dev/null|jq .
{
"version": "0.24.0",
"build_user": "haosdent",
"build_time": 1439702338,
"build_date": "2015-08-16 13:18:58"
}
```
Thanks,
haosdent huang
Re: Review Request 37024: Exposes mesos version information in
components.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37024/
-----------------------------------------------------------
(Updated Oct. 4, 2015, 3:12 p.m.)
Review request for mesos and Ben Mahler.
Changes
-------
Because the object of src/Makefile.am in apache repo seems not correct, I remove it temporary
Bugs: MESOS-1841
https://issues.apache.org/jira/browse/MESOS-1841
Repository: mesos
Description
-------
Add an endpoint that exposes component version.
Diffs (updated)
-----
src/exec/exec.cpp 7b51baaa8c08d248918974a3a22b6217e388bcb1
src/local/main.cpp 18b2f0187637cd425d55c220f73faac5a1218f0f
src/master/main.cpp bafc605d6c20bd264b932e44ee80373a3f692734
src/sched/sched.cpp 571e00d303009a940f17c8ed4582749a718e846d
src/slave/main.cpp 364dc7fc7ab2e3cef01aea7267dafa014b60e2b9
src/version/version.hpp PRE-CREATION
src/version/version.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/37024/diff/
Testing
-------
Manual test result:
```
$ curl http://localhost:5050/version 2>/dev/null|jq .
{
"version": "0.24.0",
"build_user": "haosdent",
"build_time": 1439702338,
"build_date": "2015-08-16 13:18:58"
}
```
Thanks,
haosdent huang
Re: Review Request 37024: Exposes mesos version information in
components.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37024/
-----------------------------------------------------------
(Updated Oct. 4, 2015, 2:39 p.m.)
Review request for mesos and Ben Mahler.
Bugs: MESOS-1841
https://issues.apache.org/jira/browse/MESOS-1841
Repository: mesos
Description
-------
Add an endpoint that exposes component version.
Diffs (updated)
-----
src/Makefile.am e69892736b0edc8c264eaccd52a04d44d01f53ba
src/exec/exec.cpp 7b51baaa8c08d248918974a3a22b6217e388bcb1
src/local/main.cpp 18b2f0187637cd425d55c220f73faac5a1218f0f
src/master/main.cpp bafc605d6c20bd264b932e44ee80373a3f692734
src/sched/sched.cpp 571e00d303009a940f17c8ed4582749a718e846d
src/slave/main.cpp 364dc7fc7ab2e3cef01aea7267dafa014b60e2b9
Diff: https://reviews.apache.org/r/37024/diff/
Testing
-------
Manual test result:
```
$ curl http://localhost:5050/version 2>/dev/null|jq .
{
"version": "0.24.0",
"build_user": "haosdent",
"build_time": 1439702338,
"build_date": "2015-08-16 13:18:58"
}
```
Thanks,
haosdent huang
Re: Review Request 37024: Exposes mesos version information in
components.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37024/
-----------------------------------------------------------
(Updated Oct. 4, 2015, 2:25 p.m.)
Review request for mesos and Ben Mahler.
Bugs: MESOS-1841
https://issues.apache.org/jira/browse/MESOS-1841
Repository: mesos
Description
-------
Add an endpoint that exposes component version.
Diffs (updated)
-----
src/version/version.hpp PRE-CREATION
src/version/version.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/37024/diff/
Testing
-------
Manual test result:
```
$ curl http://localhost:5050/version 2>/dev/null|jq .
{
"version": "0.24.0",
"build_user": "haosdent",
"build_time": 1439702338,
"build_date": "2015-08-16 13:18:58"
}
```
Thanks,
haosdent huang
Re: Review Request 37024: Exposes mesos version information in
components.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37024/
-----------------------------------------------------------
(Updated Oct. 4, 2015, 1:07 p.m.)
Review request for mesos and Ben Mahler.
Bugs: MESOS-1841
https://issues.apache.org/jira/browse/MESOS-1841
Repository: mesos
Description
-------
Add an endpoint that exposes component version.
Diffs
-----
include/mesos/executor.hpp 72eca97dd84fb1300b37764a3ef3a57fb5e676c2
include/mesos/scheduler.hpp ee198b6955882f4f31466ca05429ca16fbf2f5cd
src/Makefile.am 457ad26ee55bd7a2aedf27f45db58a9a4a6a5dc5
src/exec/exec.cpp 31e0c2f17a9092d18285828111d27628fb07bc02
src/local/local.cpp 4d98bf23705027f3ba0cbb571289f21b288fe7db
src/master/main.cpp bafc605d6c20bd264b932e44ee80373a3f692734
src/sched/sched.cpp 012af0508eeceeccd168b29f36fa258d20b28c21
src/slave/main.cpp 364dc7fc7ab2e3cef01aea7267dafa014b60e2b9
src/version/version_info.hpp PRE-CREATION
src/version/version_info.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/37024/diff/
Testing
-------
Manual test result:
```
$ curl http://localhost:5050/version 2>/dev/null|jq .
{
"version": "0.24.0",
"build_user": "haosdent",
"build_time": 1439702338,
"build_date": "2015-08-16 13:18:58"
}
```
Thanks,
haosdent huang