You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2019/10/15 07:54:55 UTC
[kudu-CR](branch-1.11.x) [test] deflake memory gc-itest
Hello Kudu Jenkins, Adar Dembo,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/14442
to review the following change.
Change subject: [test] deflake memory_gc-itest
......................................................................
[test] deflake memory_gc-itest
Produce more rows for test table, and disable periodical tcmalloc
memory GC before main memory consuming for mini-tservers, to avoid
memory GC before we check it.
Change-Id: Ied3c38a0e40f0586e929f5102b99c1bf3a6a91c5
Reviewed-on: http://gerrit.cloudera.org:8080/14437
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
(cherry picked from commit 8d3d3784ff26292f4aedb4c3a7fc2303bc9958b0)
---
M src/kudu/integration-tests/memory_gc-itest.cc
1 file changed, 13 insertions(+), 13 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/42/14442/1
--
To view, visit http://gerrit.cloudera.org:8080/14442
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.11.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ied3c38a0e40f0586e929f5102b99c1bf3a6a91c5
Gerrit-Change-Number: 14442
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <40...@qq.com>
[kudu-CR](branch-1.11.x) [test] deflake memory gc-itest
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14442 )
Change subject: [test] deflake memory_gc-itest
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14442
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.11.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ied3c38a0e40f0586e929f5102b99c1bf3a6a91c5
Gerrit-Change-Number: 14442
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <40...@qq.com>
Gerrit-Comment-Date: Tue, 15 Oct 2019 16:45:52 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.11.x) [test] deflake memory gc-itest
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/14442 )
Change subject: [test] deflake memory_gc-itest
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/14442
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.11.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ied3c38a0e40f0586e929f5102b99c1bf3a6a91c5
Gerrit-Change-Number: 14442
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <40...@qq.com>
Gerrit-Comment-Date: Tue, 15 Oct 2019 16:01:54 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.11.x) [test] deflake memory gc-itest
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14442 )
Change subject: [test] deflake memory_gc-itest
......................................................................
[test] deflake memory_gc-itest
Produce more rows for test table, and disable periodical tcmalloc
memory GC before main memory consuming for mini-tservers, to avoid
memory GC before we check it.
Change-Id: Ied3c38a0e40f0586e929f5102b99c1bf3a6a91c5
Reviewed-on: http://gerrit.cloudera.org:8080/14437
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
(cherry picked from commit 8d3d3784ff26292f4aedb4c3a7fc2303bc9958b0)
Reviewed-on: http://gerrit.cloudera.org:8080/14442
Reviewed-by: Yingchun Lai <40...@qq.com>
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M src/kudu/integration-tests/memory_gc-itest.cc
1 file changed, 13 insertions(+), 13 deletions(-)
Approvals:
Kudu Jenkins: Verified
Yingchun Lai: Looks good to me, but someone else must approve
Alexey Serbin: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/14442
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.11.x
Gerrit-MessageType: merged
Gerrit-Change-Id: Ied3c38a0e40f0586e929f5102b99c1bf3a6a91c5
Gerrit-Change-Number: 14442
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <40...@qq.com>