You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "rishabhdaim (via GitHub)" <gi...@apache.org> on 2023/03/02 12:33:47 UTC

[GitHub] [sling-org-apache-sling-event] rishabhdaim commented on a diff in pull request #24: SLING-11793 : limit log messages count for JobExecutionContext

rishabhdaim commented on code in PR #24:
URL: https://github.com/apache/sling-org-apache-sling-event/pull/24#discussion_r1123027969


##########
src/main/java/org/apache/sling/event/impl/jobs/JobImpl.java:
##########
@@ -312,14 +318,18 @@ public String update(final long eta) {
 
     public String log(final String message, final Object... args) {
         final String logEntry = MessageFormat.format(message, args);
-        final String[] entries = this.getProperty(Job.PROPERTY_JOB_PROGRESS_LOG, String[].class);
+        final ArrayDeque<String> entries = this.getProperty(Job.PROPERTY_JOB_PROGRESS_LOG, ArrayDeque.class);

Review Comment:
   Thanks, @joerghoh for pointing this out. I would make the necessary changes to fix this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org