You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucenenet.apache.org by ni...@apache.org on 2019/08/08 11:57:26 UTC

[lucenenet] branch master updated (9185145 -> 885d5b9)

This is an automated email from the ASF dual-hosted git repository.

nightowl888 pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/lucenenet.git.


    from 9185145  Upgraded Spatial4n to 0.4.1
     new 6b02ec4  Lucene.Net.Benchmark: Disabled non strong named warning for SharpZipLib.NETStandard (unsupported 3rd party clone) for .NET Standard 1.6. Chances are slim anyone will want to use this library on that platform - even slimmer that they will be using strong naming.
     new 885d5b9  Lucene.Net.Analysis.Common.Analysis.Synonym.FSTSynonymFilterFactory: Commented unused exception variable declaration to suppress the warning.

The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 .../Analysis/Synonym/FSTSynonymFilterFactory.cs                     | 2 +-
 src/Lucene.Net.Benchmark/Lucene.Net.Benchmark.csproj                | 6 ++++++
 2 files changed, 7 insertions(+), 1 deletion(-)


[lucenenet] 02/02: Lucene.Net.Analysis.Common.Analysis.Synonym.FSTSynonymFilterFactory: Commented unused exception variable declaration to suppress the warning.

Posted by ni...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

nightowl888 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/lucenenet.git

commit 885d5b91eb209cc7c954679c5483e01ce9813fa9
Author: Shad Storhaug <sh...@shadstorhaug.com>
AuthorDate: Thu Aug 8 18:56:38 2019 +0700

    Lucene.Net.Analysis.Common.Analysis.Synonym.FSTSynonymFilterFactory: Commented unused exception variable declaration to suppress the warning.
---
 .../Analysis/Synonym/FSTSynonymFilterFactory.cs                         | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/Lucene.Net.Analysis.Common/Analysis/Synonym/FSTSynonymFilterFactory.cs b/src/Lucene.Net.Analysis.Common/Analysis/Synonym/FSTSynonymFilterFactory.cs
index 20ca003..027627a 100644
--- a/src/Lucene.Net.Analysis.Common/Analysis/Synonym/FSTSynonymFilterFactory.cs
+++ b/src/Lucene.Net.Analysis.Common/Analysis/Synonym/FSTSynonymFilterFactory.cs
@@ -132,7 +132,7 @@ namespace Lucene.Net.Analysis.Synonym
             {
                 parser = (SynonymMap.Parser)Activator.CreateInstance(clazz, new object[] { dedup, expand, analyzer });
             }
-            catch (Exception e)
+            catch (Exception /*e*/)
             {
                 throw; // LUCENENET: CA2200: Rethrow to preserve stack details (https://docs.microsoft.com/en-us/visualstudio/code-quality/ca2200-rethrow-to-preserve-stack-details)
             }


[lucenenet] 01/02: Lucene.Net.Benchmark: Disabled non strong named warning for SharpZipLib.NETStandard (unsupported 3rd party clone) for .NET Standard 1.6. Chances are slim anyone will want to use this library on that platform - even slimmer that they will be using strong naming.

Posted by ni...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

nightowl888 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/lucenenet.git

commit 6b02ec4198912f6b34f92bd3230280870e404a78
Author: Shad Storhaug <sh...@shadstorhaug.com>
AuthorDate: Thu Aug 8 18:52:16 2019 +0700

    Lucene.Net.Benchmark: Disabled non strong named warning for SharpZipLib.NETStandard (unsupported 3rd party clone) for .NET Standard 1.6. Chances are slim anyone will want to use this library on that platform - even slimmer that they will be using strong naming.
---
 src/Lucene.Net.Benchmark/Lucene.Net.Benchmark.csproj | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/src/Lucene.Net.Benchmark/Lucene.Net.Benchmark.csproj b/src/Lucene.Net.Benchmark/Lucene.Net.Benchmark.csproj
index f1d5b73..7b19cfd 100644
--- a/src/Lucene.Net.Benchmark/Lucene.Net.Benchmark.csproj
+++ b/src/Lucene.Net.Benchmark/Lucene.Net.Benchmark.csproj
@@ -71,6 +71,12 @@
   </ItemGroup>
 
   <PropertyGroup Condition=" '$(TargetFramework)' == 'netstandard1.6' ">
+    <!-- SharpZipLib.NETStandard is not strong named - we don't really care.
+        Odds are very slim we will have any downloaders of the benchmark library on this
+        platform and even slimmer that they will require strong naming. 
+        We would just drop support for .NET Standard 1.6 for this library if
+        it didn't mean adding a special case to the build/tests. -->
+    <NoWarn>$(NoWarn);8002</NoWarn>
     <DebugType>portable</DebugType>
   </PropertyGroup>