You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Arnab Karmakar (Code Review)" <ge...@cloudera.org> on 2025/12/02 19:40:28 UTC
[Impala-ASF-CR] IMPALA-13299: Allow CREATE TABLE LIKE to create Iceberg tables
Arnab Karmakar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/23733
Change subject: IMPALA-13299: Allow CREATE TABLE LIKE to create Iceberg tables
......................................................................
IMPALA-13299: Allow CREATE TABLE LIKE to create Iceberg tables
Add support for cloning non-Iceberg tables into Iceberg tables.
Enable CREATE TABLE LIKE <src> STORED BY ICEBERG for all schemas.
Preserve column types, nullability, comments, and table properties.
Support both partitioned and external source tables in LIKE flows.
Preserve partition specs and identity transforms when present.
This improves Hive 3.1 test migration and cross-engine workflows.
Testing:
Add tests for schema cloning and Iceberg table creation.
Add checks for schema match and formatted metadata output.
Add tests for inserts into the new Iceberg table.
Add tests for partition specs and identity transforms.
Add tests for external table creation and validation.
Change-Id: Id162f217e49e9f396419b09815b92eb7f351881e
---
M docs/topics/impala_iceberg.xml
M fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java
A testdata/workloads/functional-query/queries/QueryTest/iceberg-create-table-like-non-iceberg.test
M tests/query_test/test_iceberg.py
6 files changed, 338 insertions(+), 12 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/33/23733/1
--
To view, visit http://gerrit.cloudera.org:8080/23733
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id162f217e49e9f396419b09815b92eb7f351881e
Gerrit-Change-Number: 23733
Gerrit-PatchSet: 1
Gerrit-Owner: Arnab Karmakar <ar...@gmail.com>
[Impala-ASF-CR] IMPALA-13299: Allow CREATE TABLE LIKE to create Iceberg tables
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23733 )
Change subject: IMPALA-13299: Allow CREATE TABLE LIKE to create Iceberg tables
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/23733
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id162f217e49e9f396419b09815b92eb7f351881e
Gerrit-Change-Number: 23733
Gerrit-PatchSet: 2
Gerrit-Owner: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 03 Dec 2025 22:15:24 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13299: Support CREATE TABLE LIKE for Iceberg from HDFS sources
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23733 )
Change subject: IMPALA-13299: Support CREATE TABLE LIKE for Iceberg from HDFS sources
......................................................................
Patch Set 4:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/13013/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/23733
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id162f217e49e9f396419b09815b92eb7f351881e
Gerrit-Change-Number: 23733
Gerrit-PatchSet: 4
Gerrit-Owner: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Vanko <dv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Mihaly Szjatinya <ms...@pm.me>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 28 Jan 2026 19:45:18 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13299: Allow CREATE TABLE LIKE to create Iceberg tables
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23733 )
Change subject: IMPALA-13299: Allow CREATE TABLE LIKE to create Iceberg tables
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/12737/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/23733
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id162f217e49e9f396419b09815b92eb7f351881e
Gerrit-Change-Number: 23733
Gerrit-PatchSet: 2
Gerrit-Owner: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 03 Dec 2025 04:50:48 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13299: Support CREATE TABLE LIKE for Iceberg from non-Iceberg sources
Posted by "Arnab Karmakar (Code Review)" <ge...@cloudera.org>.
Arnab Karmakar has posted comments on this change. ( http://gerrit.cloudera.org:8080/23733 )
Change subject: IMPALA-13299: Support CREATE TABLE LIKE for Iceberg from non-Iceberg sources
......................................................................
Patch Set 3:
(7 comments)
http://gerrit.cloudera.org:8080/#/c/23733/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/23733/2//COMMIT_MSG@9
PS2, Line 9: This patch enables creating Iceberg tables from non-Iceberg source tables
: using the CREATE TABLE LIKE syntax with STORED BY ICEBERG. Previously,
: Impala only allowed cloning between Iceberg tables due to concerns about
: type conversion. This limitation prevented users from easily migrating
: existing tables to Iceberg format, which is particularly important for
: Apache Hive 3.1 compatibility where CTAS with STORED BY ICEBERG is not
:
> nit: IMO it's weird that all sentences are one-liners, some feels incomplet
Done
http://gerrit.cloudera.org:8080/#/c/23733/2/docs/topics/impala_iceberg.xml
File docs/topics/impala_iceberg.xml:
http://gerrit.cloudera.org:8080/#/c/23733/2/docs/topics/impala_iceberg.xml@972
PS2, Line 972: </p>
> What happens if STORED BY ICEBERG is missing?
Done
http://gerrit.cloudera.org:8080/#/c/23733/2/docs/topics/impala_iceberg.xml@978
PS2, Line 978: , e.g. Trino, also write the NDV as a p
> I don't think it makes sense to mention an Impala Java class in the documen
Done
http://gerrit.cloudera.org:8080/#/c/23733/2/fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java
File fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java:
http://gerrit.cloudera.org:8080/#/c/23733/2/fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java@a178
PS2, Line 178:
> Side note: did this already work for creating a non-Iceberg table from an I
Creating non-Iceberg tables from Iceberg sources already works
http://gerrit.cloudera.org:8080/#/c/23733/2/fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java@178
PS2, Line 178: non-Iceber
> and Paimon
Done
http://gerrit.cloudera.org:8080/#/c/23733/2/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java:
http://gerrit.cloudera.org:8080/#/c/23733/2/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@4705
PS2, Line 4705: // Use empty table properties since we're creating from a non-Iceberg source
> What if the source is a Kudu table?
Nice catch, CreateTableLikeStmt.validateCreateKuduTableParams() should reject Kudu -> Iceberg during analysis phase.
Added defensive Preconditions.checkState() to fail if we somehow reach the code
http://gerrit.cloudera.org:8080/#/c/23733/2/testdata/workloads/functional-query/queries/QueryTest/iceberg-create-table-like-non-iceberg.test
File testdata/workloads/functional-query/queries/QueryTest/iceberg-create-table-like-non-iceberg.test:
http://gerrit.cloudera.org:8080/#/c/23733/2/testdata/workloads/functional-query/queries/QueryTest/iceberg-create-table-like-non-iceberg.test@169
PS2, Line 169: CREATE TABLE complex_ice LIKE functional_parquet.complextypestbl STORED BY ICEBERG;
> We can use HIVE_QUERY sections to run tests in beeline, however we then hav
Done
--
To view, visit http://gerrit.cloudera.org:8080/23733
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id162f217e49e9f396419b09815b92eb7f351881e
Gerrit-Change-Number: 23733
Gerrit-PatchSet: 3
Gerrit-Owner: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Vanko <dv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 12 Dec 2025 05:39:48 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13299: Support CREATE TABLE LIKE for Iceberg from non-Iceberg sources
Posted by "Arnab Karmakar (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Riza Suminto, Zoltan Borok-Nagy, Daniel Vanko, Michael Smith, Csaba Ringhofer, Noemi Pap-Takacs, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/23733
to look at the new patch set (#3).
Change subject: IMPALA-13299: Support CREATE TABLE LIKE for Iceberg from non-Iceberg sources
......................................................................
IMPALA-13299: Support CREATE TABLE LIKE for Iceberg from non-Iceberg sources
This patch enables creating Iceberg tables from non-Iceberg source tables
using the CREATE TABLE LIKE syntax with STORED BY ICEBERG. Previously,
Impala only allowed cloning between Iceberg tables due to concerns about
type conversion. This limitation prevented users from easily migrating
existing tables to Iceberg format, which is particularly important for
Apache Hive 3.1 compatibility where CTAS with STORED BY ICEBERG is not
supported.
Key implementation details:
- Removed the restriction in CreateTableLikeStmt that blocked creating
Iceberg tables from non-Iceberg sources.
- Added conversion logic in CatalogOpExecutor to handle non-Iceberg to
Iceberg table cloning. This includes proper column ordering (data
columns first, then partition columns).
- Created helper method createIdentityPartitionSpec() to convert HMS
partition keys to Iceberg identity partition transforms.
Testing:
- Created comprehensive end-to-end tests in iceberg-create-table-like-
non-iceberg.test covering schema conversion with various data types,
partition transform verification, complex types (STRUCT, ARRAY, MAP),
and data insertion validation.
Change-Id: Id162f217e49e9f396419b09815b92eb7f351881e
---
M docs/topics/impala_iceberg.xml
M fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java
A testdata/workloads/functional-query/queries/QueryTest/iceberg-create-table-like-non-iceberg.test
M testdata/workloads/functional-query/queries/QueryTest/iceberg-negative.test
M tests/query_test/test_iceberg.py
7 files changed, 383 insertions(+), 13 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/33/23733/3
--
To view, visit http://gerrit.cloudera.org:8080/23733
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id162f217e49e9f396419b09815b92eb7f351881e
Gerrit-Change-Number: 23733
Gerrit-PatchSet: 3
Gerrit-Owner: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Vanko <dv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-13299: Allow CREATE TABLE LIKE to create Iceberg tables
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/23733 )
Change subject: IMPALA-13299: Allow CREATE TABLE LIKE to create Iceberg tables
......................................................................
Patch Set 2:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/23733/2/fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java
File fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java:
http://gerrit.cloudera.org:8080/#/c/23733/2/fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java@a178
PS2, Line 178:
Side note: did this already work for creating a non-Iceberg table from an Iceberg table? Do we have test coverage for that? This guard didn't prevent it.
http://gerrit.cloudera.org:8080/#/c/23733/2/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java:
http://gerrit.cloudera.org:8080/#/c/23733/2/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@4705
PS2, Line 4705: new ArrayList<>(), // No primary keys for non-Iceberg source
What if the source is a Kudu table?
http://gerrit.cloudera.org:8080/#/c/23733/2/testdata/workloads/functional-query/queries/QueryTest/iceberg-create-table-like-non-iceberg.test
File testdata/workloads/functional-query/queries/QueryTest/iceberg-create-table-like-non-iceberg.test:
http://gerrit.cloudera.org:8080/#/c/23733/2/testdata/workloads/functional-query/queries/QueryTest/iceberg-create-table-like-non-iceberg.test@169
PS2, Line 169: # Note: Impala doesn't support INSERT into tables with complex types,
We can use HIVE_QUERY sections to run tests in beeline, however we then have to restrict the test with @SkipIfFS.hive.
--
To view, visit http://gerrit.cloudera.org:8080/23733
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id162f217e49e9f396419b09815b92eb7f351881e
Gerrit-Change-Number: 23733
Gerrit-PatchSet: 2
Gerrit-Owner: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 09 Dec 2025 23:19:58 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13299: Support CREATE TABLE LIKE for Iceberg from non-Iceberg sources
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23733 )
Change subject: IMPALA-13299: Support CREATE TABLE LIKE for Iceberg from non-Iceberg sources
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/12794/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/23733
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id162f217e49e9f396419b09815b92eb7f351881e
Gerrit-Change-Number: 23733
Gerrit-PatchSet: 3
Gerrit-Owner: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Vanko <dv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Sun, 14 Dec 2025 04:25:24 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13299: Allow CREATE TABLE LIKE to create Iceberg tables
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23733 )
Change subject: IMPALA-13299: Allow CREATE TABLE LIKE to create Iceberg tables
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/12741/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/23733
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id162f217e49e9f396419b09815b92eb7f351881e
Gerrit-Change-Number: 23733
Gerrit-PatchSet: 2
Gerrit-Owner: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 03 Dec 2025 17:19:29 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13299: Allow CREATE TABLE LIKE to create Iceberg tables
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23733 )
Change subject: IMPALA-13299: Allow CREATE TABLE LIKE to create Iceberg tables
......................................................................
Patch Set 2: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/12737/
--
To view, visit http://gerrit.cloudera.org:8080/23733
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id162f217e49e9f396419b09815b92eb7f351881e
Gerrit-Change-Number: 23733
Gerrit-PatchSet: 2
Gerrit-Owner: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 03 Dec 2025 09:43:35 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13299: Support CREATE TABLE LIKE for Iceberg from non-Iceberg sources
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23733 )
Change subject: IMPALA-13299: Support CREATE TABLE LIKE for Iceberg from non-Iceberg sources
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/23733
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id162f217e49e9f396419b09815b92eb7f351881e
Gerrit-Change-Number: 23733
Gerrit-PatchSet: 3
Gerrit-Owner: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Vanko <dv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Sun, 14 Dec 2025 09:18:53 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13299: Allow CREATE TABLE LIKE to create Iceberg tables
Posted by "Daniel Vanko (Code Review)" <ge...@cloudera.org>.
Daniel Vanko has posted comments on this change. ( http://gerrit.cloudera.org:8080/23733 )
Change subject: IMPALA-13299: Allow CREATE TABLE LIKE to create Iceberg tables
......................................................................
Patch Set 2:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/23733/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/23733/2//COMMIT_MSG@9
PS2, Line 9: Add support for cloning non-Iceberg tables into Iceberg tables.
: Enable CREATE TABLE LIKE <src> STORED BY ICEBERG for all schemas.
: Preserve column types, nullability, comments, and table properties.
: Support both partitioned and external source tables in LIKE flows.
: Preserve partition specs and identity transforms when present.
: This improves Hive 3.1 test migration and cross-engine workflows.
:
nit: IMO it's weird that all sentences are one-liners, some feels incomplete to me.
http://gerrit.cloudera.org:8080/#/c/23733/2/docs/topics/impala_iceberg.xml
File docs/topics/impala_iceberg.xml:
http://gerrit.cloudera.org:8080/#/c/23733/2/docs/topics/impala_iceberg.xml@972
PS2, Line 972: CREATE TABLE new_ice_tbl LIKE orig_ice_tbl STORED BY ICEBERG;
What happens if STORED BY ICEBERG is missing?
http://gerrit.cloudera.org:8080/#/c/23733/2/docs/topics/impala_iceberg.xml@978
PS2, Line 978: <codeph>IcebergSchemaConverter</codeph>
I don't think it makes sense to mention an Impala Java class in the documentation.
http://gerrit.cloudera.org:8080/#/c/23733/2/fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java
File fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java:
http://gerrit.cloudera.org:8080/#/c/23733/2/fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java@178
PS2, Line 178: JDBC tables
and Paimon
--
To view, visit http://gerrit.cloudera.org:8080/23733
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id162f217e49e9f396419b09815b92eb7f351881e
Gerrit-Change-Number: 23733
Gerrit-PatchSet: 2
Gerrit-Owner: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Vanko <dv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 10 Dec 2025 13:54:15 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13299: Support CREATE TABLE LIKE for Iceberg from HDFS sources
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23733 )
Change subject: IMPALA-13299: Support CREATE TABLE LIKE for Iceberg from HDFS sources
......................................................................
Patch Set 4: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/23733
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id162f217e49e9f396419b09815b92eb7f351881e
Gerrit-Change-Number: 23733
Gerrit-PatchSet: 4
Gerrit-Owner: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Vanko <dv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Mihaly Szjatinya <ms...@pm.me>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 29 Jan 2026 01:32:10 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13299: Support CREATE TABLE LIKE for Iceberg from HDFS sources
Posted by "Arnab Karmakar (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Riza Suminto, Zoltan Borok-Nagy, Daniel Vanko, Mihaly Szjatinya, Michael Smith, Csaba Ringhofer, Noemi Pap-Takacs, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/23733
to look at the new patch set (#4).
Change subject: IMPALA-13299: Support CREATE TABLE LIKE for Iceberg from HDFS sources
......................................................................
IMPALA-13299: Support CREATE TABLE LIKE for Iceberg from HDFS sources
This patch enables creating Iceberg tables from non-Iceberg HDFS source
tables (Parquet, ORC, etc.) using CREATE TABLE LIKE with STORED BY ICEBERG.
This provides a metadata-only operation to convert table schemas to Iceberg
format without copying data.
Supported source types: Parquet, ORC, Avro, Text, and other HDFS-based formats
Not supported: Kudu tables, JDBC tables, Paimon tables
Use case: This is particularly useful for Apache Hive 3.1 environments where
CTAS (CREATE TABLE AS SELECT) with STORED BY ICEBERG is not supported - that
feature requires Hive 4.0+. Users can use CREATE TABLE LIKE to create the
Iceberg schema, then use INSERT INTO to migrate data.
Testing:
- Comprehensive tests covering schema conversion with various data types,
partitioned and external tables, complex types (STRUCT, ARRAY, MAP)
- Bidirectional conversion tests (non-Iceberg → Iceberg and reverse)
- Hive interoperability tests verifying data round-trips correctly
Change-Id: Id162f217e49e9f396419b09815b92eb7f351881e
---
M docs/topics/impala_iceberg.xml
M fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java
A testdata/workloads/functional-query/queries/QueryTest/iceberg-create-table-like-non-iceberg.test
M testdata/workloads/functional-query/queries/QueryTest/iceberg-negative.test
M tests/query_test/test_iceberg.py
7 files changed, 502 insertions(+), 13 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/33/23733/4
--
To view, visit http://gerrit.cloudera.org:8080/23733
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id162f217e49e9f396419b09815b92eb7f351881e
Gerrit-Change-Number: 23733
Gerrit-PatchSet: 4
Gerrit-Owner: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Vanko <dv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Mihaly Szjatinya <ms...@pm.me>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-13299: Support CREATE TABLE LIKE for Iceberg from HDFS sources
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/23733 )
Change subject: IMPALA-13299: Support CREATE TABLE LIKE for Iceberg from HDFS sources
......................................................................
Patch Set 3:
(2 comments)
Thanks for applying the changes!
One note about the new patch set: if you rebase your code to master, it's better practice to push the rebase and fixes in separate patch sets, so it is easier to see what changes are relevant to your CR. E.g. now if you compare PS 3 and 4, you can see a lot of noise were added from the rebase
http://gerrit.cloudera.org:8080/#/c/23733/4/docs/topics/impala_iceberg.xml
File docs/topics/impala_iceberg.xml:
http://gerrit.cloudera.org:8080/#/c/23733/4/docs/topics/impala_iceberg.xml@1103
PS4, Line 1103: <li>
: <codeph>iceberg.io-impl</codeph>: custom FileIO implementation to use in a
: catalog. Must be set to enable manifest caching. Impala def
Having Complex types here might suggest that CREATE TABLE LIKE statements don't work with complex types. So I think this part can be removed, as it is a limitation of write operations, not a limitation of CREATE TABLE LIKE.
http://gerrit.cloudera.org:8080/#/c/23733/3/fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java
File fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java:
http://gerrit.cloudera.org:8080/#/c/23733/3/fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java@178
PS3, Line 178: // Note: Creating non-Iceberg tables from Iceberg sources works
: // Validate that JDBC and Paimon tables cannot be used as source
> Yes, we do have a bug, creating non-Iceberg from Iceberg does incorrectly c
Thanks for fixing the bug! Can we move the check to this file, so we can catch the non-supported case during analysis?
--
To view, visit http://gerrit.cloudera.org:8080/23733
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id162f217e49e9f396419b09815b92eb7f351881e
Gerrit-Change-Number: 23733
Gerrit-PatchSet: 3
Gerrit-Owner: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Vanko <dv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Mihaly Szjatinya <ms...@pm.me>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 29 Jan 2026 13:01:23 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13299: Support CREATE TABLE LIKE for Iceberg from HDFS sources
Posted by "Arnab Karmakar (Code Review)" <ge...@cloudera.org>.
Arnab Karmakar has posted comments on this change. ( http://gerrit.cloudera.org:8080/23733 )
Change subject: IMPALA-13299: Support CREATE TABLE LIKE for Iceberg from HDFS sources
......................................................................
Patch Set 5:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/23733/4/docs/topics/impala_iceberg.xml
File docs/topics/impala_iceberg.xml:
http://gerrit.cloudera.org:8080/#/c/23733/4/docs/topics/impala_iceberg.xml@1103
PS4, Line 1103: </ul>
: </p>
: </conbody>
> Having Complex types here might suggest that CREATE TABLE LIKE statements d
Done
http://gerrit.cloudera.org:8080/#/c/23733/3/fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java
File fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java:
http://gerrit.cloudera.org:8080/#/c/23733/3/fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java@178
PS3, Line 178: // Validate table format restrictions:
: // - JDBC tables cannot be created with CREATE TABLE LIKE (targe
> Thanks for fixing the bug! Can we move the check to this file, so we can ca
Done
--
To view, visit http://gerrit.cloudera.org:8080/23733
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id162f217e49e9f396419b09815b92eb7f351881e
Gerrit-Change-Number: 23733
Gerrit-PatchSet: 5
Gerrit-Owner: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Vanko <dv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Mihaly Szjatinya <ms...@pm.me>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 29 Jan 2026 16:04:37 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13299: Support CREATE TABLE LIKE for Iceberg from HDFS sources
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23733 )
Change subject: IMPALA-13299: Support CREATE TABLE LIKE for Iceberg from HDFS sources
......................................................................
Patch Set 6:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/13027/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/23733
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id162f217e49e9f396419b09815b92eb7f351881e
Gerrit-Change-Number: 23733
Gerrit-PatchSet: 6
Gerrit-Owner: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Vanko <dv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Mihaly Szjatinya <ms...@pm.me>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 02 Feb 2026 10:52:42 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13299: Support CREATE TABLE LIKE for Iceberg from HDFS sources
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/23733 )
Change subject: IMPALA-13299: Support CREATE TABLE LIKE for Iceberg from HDFS sources
......................................................................
IMPALA-13299: Support CREATE TABLE LIKE for Iceberg from HDFS sources
This patch enables creating Iceberg tables from non-Iceberg HDFS source
tables (Parquet, ORC, etc.) using CREATE TABLE LIKE with STORED BY ICEBERG.
This provides a metadata-only operation to convert table schemas to Iceberg
format without copying data.
Supported source types: Parquet, ORC, Avro, Text, and other HDFS-based formats
Not supported: Kudu tables, JDBC tables, Paimon tables
Use case: This is particularly useful for Apache Hive 3.1 environments where
CTAS (CREATE TABLE AS SELECT) with STORED BY ICEBERG is not supported - that
feature requires Hive 4.0+. Users can use CREATE TABLE LIKE to create the
Iceberg schema, then use INSERT INTO to migrate data.
Testing:
- Comprehensive tests covering schema conversion with various data types,
partitioned and external tables, complex types (STRUCT, ARRAY, MAP)
- Bidirectional conversion tests (non-Iceberg → Iceberg and reverse)
- Hive interoperability tests verifying data round-trips correctly
Change-Id: Id162f217e49e9f396419b09815b92eb7f351881e
Reviewed-on: http://gerrit.cloudera.org:8080/23733
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M docs/topics/impala_iceberg.xml
M fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java
A testdata/workloads/functional-query/queries/QueryTest/iceberg-create-table-like-non-iceberg.test
M testdata/workloads/functional-query/queries/QueryTest/iceberg-negative.test
M tests/query_test/test_iceberg.py
7 files changed, 497 insertions(+), 13 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/23733
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Id162f217e49e9f396419b09815b92eb7f351881e
Gerrit-Change-Number: 23733
Gerrit-PatchSet: 7
Gerrit-Owner: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Vanko <dv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Mihaly Szjatinya <ms...@pm.me>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-13299: Allow CREATE TABLE LIKE to create Iceberg tables
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23733 )
Change subject: IMPALA-13299: Allow CREATE TABLE LIKE to create Iceberg tables
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/12735/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/23733
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id162f217e49e9f396419b09815b92eb7f351881e
Gerrit-Change-Number: 23733
Gerrit-PatchSet: 1
Gerrit-Owner: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 02 Dec 2025 19:42:36 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13299: Allow CREATE TABLE LIKE to create Iceberg tables
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23733 )
Change subject: IMPALA-13299: Allow CREATE TABLE LIKE to create Iceberg tables
......................................................................
Patch Set 1: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/12735/
--
To view, visit http://gerrit.cloudera.org:8080/23733
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id162f217e49e9f396419b09815b92eb7f351881e
Gerrit-Change-Number: 23733
Gerrit-PatchSet: 1
Gerrit-Owner: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 03 Dec 2025 00:41:01 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13299: Allow CREATE TABLE LIKE to create Iceberg tables
Posted by "Arnab Karmakar (Code Review)" <ge...@cloudera.org>.
Arnab Karmakar has posted comments on this change. ( http://gerrit.cloudera.org:8080/23733 )
Change subject: IMPALA-13299: Allow CREATE TABLE LIKE to create Iceberg tables
......................................................................
Patch Set 2:
There was one test failure in the first build, which I fixed in the next patch. The second build has also failed with no logs. Not able to figure out the reason for breaking. Is it a problem from jenkins side?
--
To view, visit http://gerrit.cloudera.org:8080/23733
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id162f217e49e9f396419b09815b92eb7f351881e
Gerrit-Change-Number: 23733
Gerrit-PatchSet: 2
Gerrit-Owner: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 03 Dec 2025 09:56:28 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13299: Support CREATE TABLE LIKE for Iceberg from non-Iceberg sources
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/23733 )
Change subject: IMPALA-13299: Support CREATE TABLE LIKE for Iceberg from non-Iceberg sources
......................................................................
Patch Set 3:
(5 comments)
Thanks for working on this!
http://gerrit.cloudera.org:8080/#/c/23733/3//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/23733/3//COMMIT_MSG@7
PS3, Line 7: non-Iceberg sources
Title could be more precise, as e.g. Kudu tables are not supported as sources.
And in all the tests I only see plain Parquet tables as sources.
http://gerrit.cloudera.org:8080/#/c/23733/3//COMMIT_MSG@13
PS3, Line 13: which is particularly important for
: Apache Hive 3.1 compatibility where CTAS with STORED BY ICEBERG is not
: supported.
What do you mean by this sentence?
CTAS with STORED BY ICEBERG should work, no matter what is the source table type. As long as the data types are supported by Iceberg.
http://gerrit.cloudera.org:8080/#/c/23733/3/docs/topics/impala_iceberg.xml
File docs/topics/impala_iceberg.xml:
http://gerrit.cloudera.org:8080/#/c/23733/3/docs/topics/impala_iceberg.xml@1030
PS3, Line 1030: </p>
You could add a section about limitations:
* unsupported source table types
* unsupported data types
http://gerrit.cloudera.org:8080/#/c/23733/3/fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java
File fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java:
http://gerrit.cloudera.org:8080/#/c/23733/3/fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java@178
PS3, Line 178: // Note: Creating non-Iceberg tables from Iceberg sources works
: // Validate that JDBC and Paimon tables cannot be used as source
Not sure about the first sentence: "Creating non-Iceberg tables from Iceberg sources works". Do you test this? I think we have a bug here as the following created an Iceberg table for me despite the 'stored as parquet' clause:
create table like_t like ice_source stored as parquet;
Second sentence is not valid about JDBC tables, as we raise an exception if the target table is a JDBC table, not when the source.
Paimon tables cannot be used as source or target.
http://gerrit.cloudera.org:8080/#/c/23733/3/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java:
http://gerrit.cloudera.org:8080/#/c/23733/3/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@4673
PS3, Line 4673: // Add non-partitioning columns first
: for (Column col: srcTable.getNonClusteringColumns()) {
: TColumn tcol = col.toThrift();
: // Default to nullable for Iceberg (optional fields) if not explicitly set
: if (!tcol.isSetIs_nullable()) {
: tcol.setIs_nullable(true);
: }
: columns.add(tcol);
: }
:
: // Then add partitioning columns
: for (Column col: srcTable.getClusteringColumns()) {
: TColumn tcol = col.toThrift();
: // Default to nullable for Iceberg (optional fields) if not explicitly set
: if (!tcol.isSetIs_nullable()) {
: tcol.setIs_nullable(true);
: }
: columns.add(tcol);
: }
Can you use a single for-loop with getColumnsInHiveOrder()?
for (Column col: srcTable.getColumnsInHiveOrder()) {
TColumn tcol = col.toThrift();
// Default to nullable for Iceberg (optional fields) if not explicitly set
if (!tcol.isSetIs_nullable()) {
tcol.setIs_nullable(true);
}
columns.add(tcol);
}
--
To view, visit http://gerrit.cloudera.org:8080/23733
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id162f217e49e9f396419b09815b92eb7f351881e
Gerrit-Change-Number: 23733
Gerrit-PatchSet: 3
Gerrit-Owner: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Vanko <dv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Mihaly Szjatinya <ms...@pm.me>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 28 Jan 2026 13:48:22 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13299: Support CREATE TABLE LIKE for Iceberg from HDFS sources
Posted by "Arnab Karmakar (Code Review)" <ge...@cloudera.org>.
Arnab Karmakar has posted comments on this change. ( http://gerrit.cloudera.org:8080/23733 )
Change subject: IMPALA-13299: Support CREATE TABLE LIKE for Iceberg from HDFS sources
......................................................................
Patch Set 4:
(5 comments)
Thanks for the review Zoltan!
http://gerrit.cloudera.org:8080/#/c/23733/3//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/23733/3//COMMIT_MSG@7
PS3, Line 7: HDFS sources
> Title could be more precise, as e.g. Kudu tables are not supported as sourc
Modified commit message.
I've added more test cases covering different table sources.
http://gerrit.cloudera.org:8080/#/c/23733/3//COMMIT_MSG@13
PS3, Line 13:
: Supported source types: Parquet, ORC, Avro, Text, and other HDFS-based formats
: Not suppor
> What do you mean by this sentence?
Sorry, it was a little misleading but its meant for Apache Hive 3.1 environments where CTAS (CREATE TABLE AS SELECT) with STORED BY ICEBERG is not supported. Ive modified the commit message now.
http://gerrit.cloudera.org:8080/#/c/23733/3/docs/topics/impala_iceberg.xml
File docs/topics/impala_iceberg.xml:
http://gerrit.cloudera.org:8080/#/c/23733/3/docs/topics/impala_iceberg.xml@1030
PS3, Line 1030: "sta
> You could add a section about limitations:
Done
http://gerrit.cloudera.org:8080/#/c/23733/3/fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java
File fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java:
http://gerrit.cloudera.org:8080/#/c/23733/3/fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java@178
PS3, Line 178: // Validate table format restrictions:
: // - JDBC tables cannot be created with CREATE TABLE LIKE (targe
> Not sure about the first sentence: "Creating non-Iceberg tables from Iceber
Yes, we do have a bug, creating non-Iceberg from Iceberg does incorrectly copy Iceberg properties. Ive added a new condition in CatalogOpExecutor#createTableLike that throws an exception and doesnt let create non-iceberg table from iceberg source. Ive also added few negative test cases for this.
Fixed the comments.
http://gerrit.cloudera.org:8080/#/c/23733/3/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java:
http://gerrit.cloudera.org:8080/#/c/23733/3/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@4673
PS3, Line 4673: params.if_not_exists, columns, partitionSpec,
: Lists.newArrayList(srcIceTable.getIcebergSchema().identifierFieldNames()),
: tableProperties, params.getComment(), debugAction);
: } else if (!IcebergTable.isIcebergTable(srcTable.getMetaStoreTable())
: && IcebergTable.isIcebergTable(tbl)) {
: // Creating an Iceberg table from a non-Iceberg source table
: // Kudu tables should have been rejected during analysis
: // in validateCreateKuduTableParams()
: Preconditions.checkState(!(srcTable instanceof KuduTable),
: "Kudu tables should be rejected in analysis phase");
:
: // For Iceberg, all columns (including partition columns) must be in the schema
: // Column order matters: non-partitioning columns first, then partitioning columns
: // This matches Hive's convention for INSERT and Iceberg's flat schema model
: List<TColumn> columns = new ArrayList<>();
: for (Column col: srcTable.getColumnsInHiveOrder()) {
: TColumn tcol = col.toThrift();
: // Default to nullable for Iceberg (optional fields) if not explicitly set
:
> Can you use a single for-loop with getColumnsInHiveOrder()?
Done
--
To view, visit http://gerrit.cloudera.org:8080/23733
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id162f217e49e9f396419b09815b92eb7f351881e
Gerrit-Change-Number: 23733
Gerrit-PatchSet: 4
Gerrit-Owner: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Vanko <dv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Mihaly Szjatinya <ms...@pm.me>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 28 Jan 2026 19:21:15 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13299: Support CREATE TABLE LIKE for Iceberg from HDFS sources
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23733 )
Change subject: IMPALA-13299: Support CREATE TABLE LIKE for Iceberg from HDFS sources
......................................................................
Patch Set 6: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/23733
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id162f217e49e9f396419b09815b92eb7f351881e
Gerrit-Change-Number: 23733
Gerrit-PatchSet: 6
Gerrit-Owner: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Vanko <dv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Mihaly Szjatinya <ms...@pm.me>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 02 Feb 2026 16:29:42 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13299: Allow CREATE TABLE LIKE to create Iceberg tables
Posted by "Arnab Karmakar (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Riza Suminto, Zoltan Borok-Nagy, Michael Smith, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/23733
to look at the new patch set (#2).
Change subject: IMPALA-13299: Allow CREATE TABLE LIKE to create Iceberg tables
......................................................................
IMPALA-13299: Allow CREATE TABLE LIKE to create Iceberg tables
Add support for cloning non-Iceberg tables into Iceberg tables.
Enable CREATE TABLE LIKE <src> STORED BY ICEBERG for all schemas.
Preserve column types, nullability, comments, and table properties.
Support both partitioned and external source tables in LIKE flows.
Preserve partition specs and identity transforms when present.
This improves Hive 3.1 test migration and cross-engine workflows.
Testing:
Add tests for schema cloning and Iceberg table creation.
Add checks for schema match and formatted metadata output.
Add tests for inserts into the new Iceberg table.
Add tests for partition specs and identity transforms.
Add tests for external table creation and validation.
Change-Id: Id162f217e49e9f396419b09815b92eb7f351881e
---
M docs/topics/impala_iceberg.xml
M fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java
A testdata/workloads/functional-query/queries/QueryTest/iceberg-create-table-like-non-iceberg.test
M testdata/workloads/functional-query/queries/QueryTest/iceberg-negative.test
M tests/query_test/test_iceberg.py
7 files changed, 340 insertions(+), 13 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/33/23733/2
--
To view, visit http://gerrit.cloudera.org:8080/23733
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id162f217e49e9f396419b09815b92eb7f351881e
Gerrit-Change-Number: 23733
Gerrit-PatchSet: 2
Gerrit-Owner: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-13299: Allow CREATE TABLE LIKE to create Iceberg tables
Posted by "Arnab Karmakar (Code Review)" <ge...@cloudera.org>.
Arnab Karmakar has posted comments on this change. ( http://gerrit.cloudera.org:8080/23733 )
Change subject: IMPALA-13299: Allow CREATE TABLE LIKE to create Iceberg tables
......................................................................
Patch Set 2:
Only this much was there in the logs:
New run name is '#4301 refs/changes/33/23733/2'
Archiving artifacts
Recording test results
No test report files were found. Configuration error?
[Checks API] No suitable checks publisher found.
Finished: FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/23733
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id162f217e49e9f396419b09815b92eb7f351881e
Gerrit-Change-Number: 23733
Gerrit-PatchSet: 2
Gerrit-Owner: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 03 Dec 2025 09:57:31 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13299: Support CREATE TABLE LIKE for Iceberg from HDFS sources
Posted by "Arnab Karmakar (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Riza Suminto, Zoltan Borok-Nagy, Daniel Vanko, Mihaly Szjatinya, Michael Smith, Csaba Ringhofer, Noemi Pap-Takacs, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/23733
to look at the new patch set (#5).
Change subject: IMPALA-13299: Support CREATE TABLE LIKE for Iceberg from HDFS sources
......................................................................
IMPALA-13299: Support CREATE TABLE LIKE for Iceberg from HDFS sources
This patch enables creating Iceberg tables from non-Iceberg HDFS source
tables (Parquet, ORC, etc.) using CREATE TABLE LIKE with STORED BY ICEBERG.
This provides a metadata-only operation to convert table schemas to Iceberg
format without copying data.
Supported source types: Parquet, ORC, Avro, Text, and other HDFS-based formats
Not supported: Kudu tables, JDBC tables, Paimon tables
Use case: This is particularly useful for Apache Hive 3.1 environments where
CTAS (CREATE TABLE AS SELECT) with STORED BY ICEBERG is not supported - that
feature requires Hive 4.0+. Users can use CREATE TABLE LIKE to create the
Iceberg schema, then use INSERT INTO to migrate data.
Testing:
- Comprehensive tests covering schema conversion with various data types,
partitioned and external tables, complex types (STRUCT, ARRAY, MAP)
- Bidirectional conversion tests (non-Iceberg → Iceberg and reverse)
- Hive interoperability tests verifying data round-trips correctly
Change-Id: Id162f217e49e9f396419b09815b92eb7f351881e
---
M docs/topics/impala_iceberg.xml
M fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java
A testdata/workloads/functional-query/queries/QueryTest/iceberg-create-table-like-non-iceberg.test
M testdata/workloads/functional-query/queries/QueryTest/iceberg-negative.test
M tests/query_test/test_iceberg.py
7 files changed, 497 insertions(+), 13 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/33/23733/5
--
To view, visit http://gerrit.cloudera.org:8080/23733
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id162f217e49e9f396419b09815b92eb7f351881e
Gerrit-Change-Number: 23733
Gerrit-PatchSet: 5
Gerrit-Owner: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Vanko <dv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Mihaly Szjatinya <ms...@pm.me>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-13299: Support CREATE TABLE LIKE for Iceberg from HDFS sources
Posted by "Arnab Karmakar (Code Review)" <ge...@cloudera.org>.
Arnab Karmakar has posted comments on this change. ( http://gerrit.cloudera.org:8080/23733 )
Change subject: IMPALA-13299: Support CREATE TABLE LIKE for Iceberg from HDFS sources
......................................................................
Patch Set 5:
Thanks for the tip Zoltan, will keep it in mind next time onwards
--
To view, visit http://gerrit.cloudera.org:8080/23733
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id162f217e49e9f396419b09815b92eb7f351881e
Gerrit-Change-Number: 23733
Gerrit-PatchSet: 5
Gerrit-Owner: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Vanko <dv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Mihaly Szjatinya <ms...@pm.me>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 29 Jan 2026 16:05:09 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13299: Support CREATE TABLE LIKE for Iceberg from HDFS sources
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/23733 )
Change subject: IMPALA-13299: Support CREATE TABLE LIKE for Iceberg from HDFS sources
......................................................................
Patch Set 5: Code-Review+2
LGTM!
--
To view, visit http://gerrit.cloudera.org:8080/23733
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id162f217e49e9f396419b09815b92eb7f351881e
Gerrit-Change-Number: 23733
Gerrit-PatchSet: 5
Gerrit-Owner: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Vanko <dv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Mihaly Szjatinya <ms...@pm.me>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 02 Feb 2026 10:52:23 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13299: Support CREATE TABLE LIKE for Iceberg from HDFS sources
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23733 )
Change subject: IMPALA-13299: Support CREATE TABLE LIKE for Iceberg from HDFS sources
......................................................................
Patch Set 6: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/23733
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id162f217e49e9f396419b09815b92eb7f351881e
Gerrit-Change-Number: 23733
Gerrit-PatchSet: 6
Gerrit-Owner: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Vanko <dv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Mihaly Szjatinya <ms...@pm.me>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 02 Feb 2026 10:52:41 +0000
Gerrit-HasComments: No