[GitHub] [skywalking-java] wu-sheng commented on a diff in pull request #460: Fix servicecomb plugin trace break

["wu-sheng (via GitHub)" <gi...@apache.org>]

wu-sheng commented on code in PR #460:
URL: https://github.com/apache/skywalking-java/pull/460#discussion_r1111953323


##########
apm-sniffer/apm-sdk-plugin/servicecomb-plugin/servicecomb-java-chassis-2.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/servicecomb/v2/ProducerOperationHandlerInterceptor.java:
##########
@@ -52,6 +52,13 @@ public void beforeMethod(EnhancedInstance objInst, Method method, Object[] allAr
         SpanLayer.asRPCFramework(span);
     }
 
+    private String getHeadValue(Invocation invocation, String key) {
+        if (invocation.getContext().containsKey("sw8")) {

Review Comment:
   ```suggestion
           if (invocation.getContext().containsKey(key)) {
   ```
   
   Hard code `sw8` is wrong. We have more headers than this. Notice, your method is in the `while`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org