You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Chris Douglas (JIRA)" <ji...@apache.org> on 2008/11/06 02:46:46 UTC
[jira] Created: (HADOOP-4600) JspHelper should be a singleton
JspHelper should be a singleton
-------------------------------
Key: HADOOP-4600
URL: https://issues.apache.org/jira/browse/HADOOP-4600
Project: Hadoop Core
Issue Type: Improvement
Components: dfs
Reporter: Chris Douglas
Priority: Minor
Servlets creating JspHelper instances initialize a set of statics and use the empty instance as a handle to class methods. Instead, JspHelper should either be a singleton with instance fields or its methods should also be static.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4600) JspHelper should be a singleton
Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Douglas updated HADOOP-4600:
----------------------------------
Attachment: 4600-0.patch
> JspHelper should be a singleton
> -------------------------------
>
> Key: HADOOP-4600
> URL: https://issues.apache.org/jira/browse/HADOOP-4600
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Chris Douglas
> Priority: Minor
> Attachments: 4600-0.patch
>
>
> Servlets creating JspHelper instances initialize a set of statics and use the empty instance as a handle to class methods. Instead, JspHelper should either be a singleton with instance fields or its methods should also be static.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4600) JspHelper should be a singleton
Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Douglas updated HADOOP-4600:
----------------------------------
Status: Open (was: Patch Available)
Patch is no longer in sync with trunk. Also, the marginal benefit of making this a singleton doesn't fix what ails this class.
> JspHelper should be a singleton
> -------------------------------
>
> Key: HADOOP-4600
> URL: https://issues.apache.org/jira/browse/HADOOP-4600
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Chris Douglas
> Priority: Minor
> Attachments: 4600-0.patch
>
>
> Servlets creating JspHelper instances initialize a set of statics and use the empty instance as a handle to class methods. Instead, JspHelper should either be a singleton with instance fields or its methods should also be static.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4600) JspHelper should be a singleton
Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Douglas updated HADOOP-4600:
----------------------------------
Status: Patch Available (was: Open)
> JspHelper should be a singleton
> -------------------------------
>
> Key: HADOOP-4600
> URL: https://issues.apache.org/jira/browse/HADOOP-4600
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Chris Douglas
> Priority: Minor
> Attachments: 4600-0.patch
>
>
> Servlets creating JspHelper instances initialize a set of statics and use the empty instance as a handle to class methods. Instead, JspHelper should either be a singleton with instance fields or its methods should also be static.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4600) JspHelper should be a singleton
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12646052#action_12646052 ]
Hadoop QA commented on HADOOP-4600:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12393560/4600-0.patch
against trunk revision 712344.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.
-1 javadoc. The javadoc tool appears to have generated 1 warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 Eclipse classpath. The patch retains Eclipse classpath integrity.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3562/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3562/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3562/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3562/console
This message is automatically generated.
> JspHelper should be a singleton
> -------------------------------
>
> Key: HADOOP-4600
> URL: https://issues.apache.org/jira/browse/HADOOP-4600
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Chris Douglas
> Priority: Minor
> Attachments: 4600-0.patch
>
>
> Servlets creating JspHelper instances initialize a set of statics and use the empty instance as a handle to class methods. Instead, JspHelper should either be a singleton with instance fields or its methods should also be static.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.