You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hawq.apache.org by chiyang10000 <gi...@git.apache.org> on 2018/01/05 00:25:00 UTC
[GitHub] incubator-hawq pull request #1328: HAWQ-1578. Regression Test (Feature->Rang...
GitHub user chiyang10000 opened a pull request:
https://github.com/apache/incubator-hawq/pull/1328
HAWQ-1578. Regression Test (Feature->Ranger)Failed
Due to some unknown issue (`ERROR: remote component error (0): (libchurl.c:897)`), I could not set up the test environment to verify my fix.
Please help to apply the patch into your test environment to verify it. Thanks!
@interma @radarwave
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/chiyang10000/incubator-hawq HAWQ-1578
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-hawq/pull/1328.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1328
----
commit f67caa41d4035062bb5ea789aa1256c45fa3af4e
Author: Chiyang Wan <ch...@...>
Date: 2018-01-05T00:21:27Z
HAWQ-1578. Regression Test (Feature->Ranger)Failed
----
---
[GitHub] incubator-hawq pull request #1328: HAWQ-1578. Regression Test (Feature->Rang...
Posted by interma <gi...@git.apache.org>.
Github user interma commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1328#discussion_r160081148
--- Diff: src/backend/access/external/plugstorage.c ---
@@ -89,6 +94,11 @@ void getExternalTableTypeInStr(const char formatType,
*formatterName = NULL;
}
else if (fmttype_is_custom(formatType))
+ {
+ *formatterType = ExternalTableType_CUSTOM;
+ *formatterName = NULL;
+ }
+ else if (fmttype_is_custom(formatType))
--- End diff --
There is a same if condition above (`fmttype_is_custom(formatType)`).
Is one of them useless?
---
[GitHub] incubator-hawq pull request #1328: HAWQ-1578. Regression Test (Feature->Rang...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-hawq/pull/1328
---
[GitHub] incubator-hawq pull request #1328: HAWQ-1578. Regression Test (Feature->Rang...
Posted by chiyang10000 <gi...@git.apache.org>.
Github user chiyang10000 commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1328#discussion_r160105954
--- Diff: src/backend/access/external/plugstorage.c ---
@@ -89,6 +94,11 @@ void getExternalTableTypeInStr(const char formatType,
*formatterName = NULL;
}
else if (fmttype_is_custom(formatType))
+ {
+ *formatterType = ExternalTableType_CUSTOM;
+ *formatterName = NULL;
+ }
+ else if (fmttype_is_custom(formatType))
--- End diff --
Yes. The latter branch is disabled temporarily, serving as a workaround to fix the PXF issue. Once the pluggable storage framework is well tested, this workaround will be dropped.
---
[GitHub] incubator-hawq issue #1328: HAWQ-1578. Regression Test (Feature->Ranger)Fail...
Posted by radarwave <gi...@git.apache.org>.
Github user radarwave commented on the issue:
https://github.com/apache/incubator-hawq/pull/1328
+1
---
[GitHub] incubator-hawq pull request #1328: HAWQ-1578. Regression Test (Feature->Rang...
Posted by interma <gi...@git.apache.org>.
Github user interma commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1328#discussion_r160306937
--- Diff: src/backend/access/external/plugstorage.c ---
@@ -89,6 +94,11 @@ void getExternalTableTypeInStr(const char formatType,
*formatterName = NULL;
}
else if (fmttype_is_custom(formatType))
+ {
+ *formatterType = ExternalTableType_CUSTOM;
+ *formatterName = NULL;
+ }
+ else if (fmttype_is_custom(formatType))
--- End diff --
Thanks!
---