You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by knight9999 <gi...@git.apache.org> on 2016/06/24 00:16:08 UTC

[GitHub] cordova-ios pull request #231: Fix Macos Japanese Filename Problem. (Change ...

GitHub user knight9999 opened a pull request:

    https://github.com/apache/cordova-ios/pull/231

    Fix Macos Japanese Filename Problem. (Change NFD projectName to NFC t\u2026

    This request fixes the NFC / NFD problem. (Filename String for Mac)
    In Mac, The filename is treated as NFD.
    However, the target name in xcode is treated as NFC.
    Therefore, cordova build fails when we use the specific Japanese name for project title.
    (For example, 
    
        cordova create \u30b5\u30f3\u30d7\u30eb com.example.sample \u30b5\u30f3\u30d7\u30eb
        cordova platform add ios
        cordova build
    
    ==> Fail.
    Because the \u30b5\u30f3\u30d7\u30eb in NFC is different from and \u30b5\u30f3\u30d7\u30eb in NFD.)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/knight9999/cordova-ios fix_macos_Japanese_filename_problem

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-ios/pull/231.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #231
    
----
commit fa63fad4562ed2219235b0b863b8f1f9c6c8d6fc
Author: Kenichi Naito <fi...@gmail.com>
Date:   2016-06-24T00:10:29Z

    Fix Macos Japanese Filename Problem. (Change NFD projectName to NFC targetName)

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-ios issue #231: Fix Macos Japanese Filename Problem. (Change NFD pro...

Posted by knight9999 <gi...@git.apache.org>.
Github user knight9999 commented on the issue:

    https://github.com/apache/cordova-ios/pull/231
  
    As you say, 4.2.0 works successfully. I only tested with 4.1.1.
    Sorry, I withdraw this request. Thanks! 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-ios issue #231: Fix Macos Japanese Filename Problem. (Change NFD pro...

Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the issue:

    https://github.com/apache/cordova-ios/pull/231
  
    I believe this was only a problem with 4.1.1 and below. Please try with 4.2.0, just released today. 
    I arrived at a similar fix: https://issues.apache.org/jira/browse/CB-11401 but it was already fixed in 4.2.0 using other means.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-ios issue #231: Fix Macos Japanese Filename Problem. (Change NFD pro...

Posted by masahirotanaka <gi...@git.apache.org>.
Github user masahirotanaka commented on the issue:

    https://github.com/apache/cordova-ios/pull/231
  
    @shazron @stevengill Let me know if you need more explanation. It's the locale issue, but this causes some apps having specific commonly used Japanese characters to fail building.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-ios pull request #231: Fix Macos Japanese Filename Problem. (Change ...

Posted by knight9999 <gi...@git.apache.org>.
Github user knight9999 closed the pull request at:

    https://github.com/apache/cordova-ios/pull/231


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org