[jira] [Comment Edited] (CALCITE-5554) Add DAYOFWEEK and DAYOFYEAR as valid synonyms of DOW, DOY

["Tanner Clary (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CALCITE-5554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17698581#comment-17698581 ] 

Tanner Clary edited comment on CALCITE-5554 at 3/9/23 7:38 PM:
---------------------------------------------------------------

[~julianhyde] After thinking about it some more, I think some changes to the EXTRACT() implementation could be useful. For instance, the "SQL_TSI_" aliases are currently not valid either, while they are for other date/time functions. What do you think? I'm working on the parsing warnings as well.


was (Author: JIRAUSER298151):
[~julianhyde] After thinking about it some more, I think some changes to the EXTRACT() implementation could be useful. For instance, the "SQL_TSI_" aliases are currently not valid either, while they are for other date/time functions. What do you think?

> Add DAYOFWEEK and DAYOFYEAR as valid synonyms of DOW, DOY
> ---------------------------------------------------------
>
>                 Key: CALCITE-5554
>                 URL: https://issues.apache.org/jira/browse/CALCITE-5554
>             Project: Calcite
>          Issue Type: Improvement
>            Reporter: Tanner Clary
>            Assignee: Tanner Clary
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 1h
>  Remaining Estimate: 0h
>
> Currently, a query such as: {{EXTRACT(DAYOFWEEK FROM DATE '2008-12-25');}} is invalid while {{EXTRACT(DOW FROM DATE '2008-12-25')}} is acceptable. BigQuery (and perhaps other dialects) accept the non-abbreviated version as a valid time unit. After this change, DAYOFWEEK and DAYOFYEAR would both be synonyms of DOW and DOY, respectively. 
> [Relevant BigQuery Docs|https://cloud.google.com/bigquery/docs/reference/standard-sql/date_functions#extract]
> Any comments, questions, or suggestions for the linked PR are highly appreciated. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)