You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@uniffle.apache.org by ro...@apache.org on 2023/02/24 06:52:15 UTC
[incubator-uniffle] branch branch-0.7 updated: [#647][FOLLOWUP] set coordinator id before ApplicationMaster (#654)
This is an automated email from the ASF dual-hosted git repository.
roryqi pushed a commit to branch branch-0.7
in repository https://gitbox.apache.org/repos/asf/incubator-uniffle.git
The following commit(s) were added to refs/heads/branch-0.7 by this push:
new 69311c3a [#647][FOLLOWUP] set coordinator id before ApplicationMaster (#654)
69311c3a is described below
commit 69311c3a0bce9d25b9ca8a3d361f41aa83c2f45c
Author: advancedxy <xi...@apache.org>
AuthorDate: Fri Feb 24 14:50:44 2023 +0800
[#647][FOLLOWUP] set coordinator id before ApplicationMaster (#654)
### What changes were proposed in this pull request?
set coordinator id before ApplicationMaster construction, otherwise uuid is used for ` AbstractSelectStorageStrategy`
### Why are the changes needed?
Follow up of #647
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Manually verified
---
.../src/main/java/org/apache/uniffle/coordinator/CoordinatorServer.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/coordinator/src/main/java/org/apache/uniffle/coordinator/CoordinatorServer.java b/coordinator/src/main/java/org/apache/uniffle/coordinator/CoordinatorServer.java
index a946062a..a016df6a 100644
--- a/coordinator/src/main/java/org/apache/uniffle/coordinator/CoordinatorServer.java
+++ b/coordinator/src/main/java/org/apache/uniffle/coordinator/CoordinatorServer.java
@@ -149,6 +149,7 @@ public class CoordinatorServer extends ReconfigurableBase {
jettyServer = new JettyServer(coordinatorConf);
// register metrics first to avoid NPE problem when add dynamic metrics
registerMetrics();
+ coordinatorConf.setString(CoordinatorUtils.COORDINATOR_ID, id);
this.applicationManager = new ApplicationManager(coordinatorConf);
SecurityConfig securityConfig = null;
@@ -162,7 +163,6 @@ public class CoordinatorServer extends ReconfigurableBase {
}
SecurityContextFactory.get().init(securityConfig);
- coordinatorConf.setString(CoordinatorUtils.COORDINATOR_ID, id);
// load default hadoop configuration
Configuration hadoopConf = new Configuration();