You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bifromq.apache.org by "liaodn (via GitHub)" <gi...@apache.org> on 2026/04/20 06:07:34 UTC
[PR] feat(starter): support configurable multi-dimensional metricsTags (Part of #243) [bifromq]
liaodn opened a new pull request, #245:
URL: https://github.com/apache/bifromq/pull/245
- Add metricsTags config option to define multiple global labels in standalone.yml
- Keep clusterConfig.env as default metricsTags to ensure backward compatibility
- Add clusterEnv tag to base-cluster Messenger and TCPTransport metrics
- Include clusterEnv in AgentHost member list tags
BREAKING CHANGE: Global metrics now use metricsTags config instead of single clusterConfig.env injection. To migrate, move the original env value to metricsTags config.
Example config:
```
metricsTags:
region: gz
deployment: canary
env: Test
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bifromq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(starter): support configurable multi-dimensional metricsTags (Part of #243) [bifromq]
Posted by "popduke (via GitHub)" <gi...@apache.org>.
popduke merged PR #245:
URL: https://github.com/apache/bifromq/pull/245
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bifromq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(starter): support configurable multi-dimensional metricsTags (Part of #243) [bifromq]
Posted by "Gujiawei-Edinburgh (via GitHub)" <gi...@apache.org>.
Gujiawei-Edinburgh commented on PR #245:
URL: https://github.com/apache/bifromq/pull/245#issuecomment-4296288134
> LGTM, what do u think? @Gujiawei-Edinburgh
Looks good. But one thing I am confused is the precedence handling mentioned in [issue](https://github.com/apache/bifromq/issues/243). From current changes, it is more like injecting env to low level tags.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bifromq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org