You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@thrift.apache.org by GitBox <gi...@apache.org> on 2022/03/11 02:32:10 UTC

[GitHub] [thrift] Jimexist edited a comment on pull request #2529: THRIFT-5524: [java lib] add jdk8-with-postfix for option_type

Jimexist edited a comment on pull request #2529:
URL: https://github.com/apache/thrift/pull/2529#issuecomment-1064711013


   > Build is green, yet I'm unsure how to move forward with this.
   
   thanks for the review @Jens-G 
   
   both:
   - this #2529 and
   - #2525 
   
   are additive, back-compatible changes, and #2525 is a subset of this (or this change is based on #2525). So either we can merge that first or merge this as is and close that.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org