You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/02/04 22:42:47 UTC

[GitHub] [incubator-superset] nytai opened a new pull request #9086: [dashboard] fix, add filter support to match FAB's filter functionality 

nytai opened a new pull request #9086: [dashboard] fix, add filter support to match FAB's filter functionality 
URL: https://github.com/apache/incubator-superset/pull/9086
 
 
   ### CATEGORY
   
   Choose one
   
   - [ ] Bug Fix
   - [ ] Enhancement (new features, refinement)
   - [ ] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   
   ### TEST PLAN
   <!--- What steps should be taken to verify the changes -->
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   ### REVIEWERS
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] rusackas commented on a change in pull request #9086: [dashboard, chart] fix, add filter support to match FAB's filter functionality

Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #9086: [dashboard, chart] fix, add filter support to match FAB's filter functionality 
URL: https://github.com/apache/incubator-superset/pull/9086#discussion_r382737475
 
 

 ##########
 File path: superset-frontend/src/components/ListView/ListView.tsx
 ##########
 @@ -28,11 +28,15 @@ import {
   Row,
   // @ts-ignore
 } from 'react-bootstrap';
+// @ts-ignore
+import { default as SelectComponent } from 'react-select';
 
 Review comment:
   silly NIT/question - just wondering why you chose this over `import SelectComponent from 'react-select';`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on issue #9086: [dashboard, chart] fix, add filter support to match FAB's filter functionality

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #9086: [dashboard, chart] fix, add filter support to match FAB's filter functionality 
URL: https://github.com/apache/incubator-superset/pull/9086#issuecomment-582190613
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9086?src=pr&el=h1) Report
   > Merging [#9086](https://codecov.io/gh/apache/incubator-superset/pull/9086?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/3efdfc53456aa702d01fee90c17b79ba9531c9b8?src=pr&el=desc) will **decrease** coverage by `0.19%`.
   > The diff coverage is `60.6%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9086/graphs/tree.svg?width=650&token=KsB0fHcx6l&height=150&src=pr)](https://codecov.io/gh/apache/incubator-superset/pull/9086?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff            @@
   ##           master    #9086     +/-   ##
   =========================================
   - Coverage   59.13%   58.93%   -0.2%     
   =========================================
     Files         372      372             
     Lines       11938    11987     +49     
     Branches     2925     2936     +11     
   =========================================
   + Hits         7059     7065      +6     
   - Misses       4699     4742     +43     
     Partials      180      180
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9086?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...frontend/src/views/dashboardList/DashboardList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9086/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL2Rhc2hib2FyZExpc3QvRGFzaGJvYXJkTGlzdC50c3g=) | `59.34% <40.9%> (-10.38%)` | :arrow_down: |
   | [...uperset-frontend/src/views/chartList/ChartList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9086/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL2NoYXJ0TGlzdC9DaGFydExpc3QudHN4) | `63.39% <42.1%> (-11.1%)` | :arrow_down: |
   | [...rset-frontend/src/components/ListView/ListView.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9086/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvTGlzdFZpZXcudHN4) | `86.02% <70.73%> (-6.39%)` | :arrow_down: |
   | [superset-frontend/src/components/ListView/utils.ts](https://codecov.io/gh/apache/incubator-superset/pull/9086/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvdXRpbHMudHM=) | `94.44% <82.35%> (-4.02%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9086?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9086?src=pr&el=footer). Last update [3efdfc5...38e07de](https://codecov.io/gh/apache/incubator-superset/pull/9086?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] rusackas commented on a change in pull request #9086: [dashboard, chart] fix, add filter support to match FAB's filter functionality

Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #9086: [dashboard, chart] fix, add filter support to match FAB's filter functionality 
URL: https://github.com/apache/incubator-superset/pull/9086#discussion_r382737475
 
 

 ##########
 File path: superset-frontend/src/components/ListView/ListView.tsx
 ##########
 @@ -28,11 +28,15 @@ import {
   Row,
   // @ts-ignore
 } from 'react-bootstrap';
+// @ts-ignore
+import { default as SelectComponent } from 'react-select';
 
 Review comment:
   silly NIT/question - just curious why you chose this over `import SelectComponent from 'react-select';`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] rusackas commented on a change in pull request #9086: [dashboard, chart] fix, add filter support to match FAB's filter functionality

Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #9086: [dashboard, chart] fix, add filter support to match FAB's filter functionality 
URL: https://github.com/apache/incubator-superset/pull/9086#discussion_r382737475
 
 

 ##########
 File path: superset-frontend/src/components/ListView/ListView.tsx
 ##########
 @@ -28,11 +28,15 @@ import {
   Row,
   // @ts-ignore
 } from 'react-bootstrap';
+// @ts-ignore
+import { default as SelectComponent } from 'react-select';
 
 Review comment:
   silly NIT/question - just curious why you chose this over `import SelectComponent from 'react-select';`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] mistercrunch merged pull request #9086: [dashboard, chart] fix, add filter support to match FAB's filter functionality

Posted by GitBox <gi...@apache.org>.
mistercrunch merged pull request #9086: [dashboard, chart] fix, add filter support to match FAB's filter functionality 
URL: https://github.com/apache/incubator-superset/pull/9086
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io commented on issue #9086: [dashboard] fix, add filter support to match FAB's filter functionality

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #9086: [dashboard] fix, add filter support to match FAB's filter functionality 
URL: https://github.com/apache/incubator-superset/pull/9086#issuecomment-582190613
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9086?src=pr&el=h1) Report
   > Merging [#9086](https://codecov.io/gh/apache/incubator-superset/pull/9086?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/6cb4ce0e192830b73d10c66f8f557388ba944ca1?src=pr&el=desc) will **decrease** coverage by `0.08%`.
   > The diff coverage is `67.56%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9086/graphs/tree.svg?width=650&token=KsB0fHcx6l&height=150&src=pr)](https://codecov.io/gh/apache/incubator-superset/pull/9086?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9086      +/-   ##
   ==========================================
   - Coverage   59.15%   59.06%   -0.09%     
   ==========================================
     Files         370      370              
     Lines       11818    11851      +33     
     Branches     2900     2910      +10     
   ==========================================
   + Hits         6991     7000       +9     
   - Misses       4648     4672      +24     
     Partials      179      179
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9086?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...t/assets/src/views/dashboardList/DashboardList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9086/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aWV3cy9kYXNoYm9hcmRMaXN0L0Rhc2hib2FyZExpc3QudHN4) | `64.16% <47.05%> (-9.23%)` | :arrow_down: |
   | [...perset/assets/src/components/ListView/ListView.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9086/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL0xpc3RWaWV3L0xpc3RWaWV3LnRzeA==) | `85.86% <70%> (-6.34%)` | :arrow_down: |
   | [superset/assets/src/components/ListView/utils.ts](https://codecov.io/gh/apache/incubator-superset/pull/9086/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL0xpc3RWaWV3L3V0aWxzLnRz) | `94.44% <82.35%> (-4.02%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9086?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9086?src=pr&el=footer). Last update [6cb4ce0...3a5eeef](https://codecov.io/gh/apache/incubator-superset/pull/9086?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on issue #9086: [dashboard] fix, add filter support to match FAB's filter functionality

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #9086: [dashboard] fix, add filter support to match FAB's filter functionality 
URL: https://github.com/apache/incubator-superset/pull/9086#issuecomment-582190613
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9086?src=pr&el=h1) Report
   > Merging [#9086](https://codecov.io/gh/apache/incubator-superset/pull/9086?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/30b7064e309c8f6d080e1c81ab3684b4a949a496?src=pr&el=desc) will **decrease** coverage by `0.15%`.
   > The diff coverage is `65.26%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9086/graphs/tree.svg?width=650&token=KsB0fHcx6l&height=150&src=pr)](https://codecov.io/gh/apache/incubator-superset/pull/9086?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9086      +/-   ##
   ==========================================
   - Coverage    59.1%   58.94%   -0.16%     
   ==========================================
     Files         372      372              
     Lines       11922    11966      +44     
     Branches     2919     2931      +12     
   ==========================================
   + Hits         7046     7053       +7     
   - Misses       4694     4731      +37     
     Partials      182      182
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9086?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...frontend/src/views/dashboardList/DashboardList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9086/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL2Rhc2hib2FyZExpc3QvRGFzaGJvYXJkTGlzdC50c3g=) | `63.86% <50%> (-9.29%)` | :arrow_down: |
   | [...uperset-frontend/src/views/chartList/ChartList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9086/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL2NoYXJ0TGlzdC9DaGFydExpc3QudHN4) | `65.45% <55%> (-9.3%)` | :arrow_down: |
   | [...rset-frontend/src/components/ListView/ListView.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9086/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvTGlzdFZpZXcudHN4) | `85.86% <70%> (-6.34%)` | :arrow_down: |
   | [superset-frontend/src/components/ListView/utils.ts](https://codecov.io/gh/apache/incubator-superset/pull/9086/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvdXRpbHMudHM=) | `94.44% <82.35%> (-4.02%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9086?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9086?src=pr&el=footer). Last update [30b7064...7d2186a](https://codecov.io/gh/apache/incubator-superset/pull/9086?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org